* [PATCH 1/1] tiny-init: fix bashism
[not found] <cover.1375430111.git.Qi.Chen@windriver.com>
@ 2013-08-02 7:56 ` Qi.Chen
2013-08-02 14:05 ` Darren Hart
0 siblings, 1 reply; 3+ messages in thread
From: Qi.Chen @ 2013-08-02 7:56 UTC (permalink / raw)
To: poky; +Cc: dvhart, Zhangle.Yang
From: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
meta-yocto/recipes-core/tiny-init/files/init | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-yocto/recipes-core/tiny-init/files/init b/meta-yocto/recipes-core/tiny-init/files/init
index 4b78f01..9140e95 100644
--- a/meta-yocto/recipes-core/tiny-init/files/init
+++ b/meta-yocto/recipes-core/tiny-init/files/init
@@ -15,7 +15,7 @@ ifup lo
# Allow for distro or local customizations
if [ -f /etc/rc.local ] ; then
- source /etc/rc.local
+ . /etc/rc.local
fi
# Become session leader and try to find a real tty (e.g. ttyS0)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] tiny-init: fix bashism
2013-08-02 7:56 ` [PATCH 1/1] tiny-init: fix bashism Qi.Chen
@ 2013-08-02 14:05 ` Darren Hart
2013-08-05 1:28 ` ChenQi
0 siblings, 1 reply; 3+ messages in thread
From: Darren Hart @ 2013-08-02 14:05 UTC (permalink / raw)
To: Qi.Chen; +Cc: poky, Zhangle.Yang
On Fri, 2013-08-02 at 15:56 +0800, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
I understand this is a simple fix, but please provide a commit log. In
this case, something like the following would suffice:
"source" is a bashism, replace it with the posix shell compliant "."
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Acked-by: Darren Hart <dvhart@linux.intel.com>
> ---
> meta-yocto/recipes-core/tiny-init/files/init | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-yocto/recipes-core/tiny-init/files/init b/meta-yocto/recipes-core/tiny-init/files/init
> index 4b78f01..9140e95 100644
> --- a/meta-yocto/recipes-core/tiny-init/files/init
> +++ b/meta-yocto/recipes-core/tiny-init/files/init
> @@ -15,7 +15,7 @@ ifup lo
>
> # Allow for distro or local customizations
> if [ -f /etc/rc.local ] ; then
> - source /etc/rc.local
> + . /etc/rc.local
> fi
>
> # Become session leader and try to find a real tty (e.g. ttyS0)
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] tiny-init: fix bashism
2013-08-02 14:05 ` Darren Hart
@ 2013-08-05 1:28 ` ChenQi
0 siblings, 0 replies; 3+ messages in thread
From: ChenQi @ 2013-08-05 1:28 UTC (permalink / raw)
To: Darren Hart; +Cc: poky, Zhangle.Yang
On 08/02/2013 10:05 PM, Darren Hart wrote:
> On Fri, 2013-08-02 at 15:56 +0800, Qi.Chen@windriver.com wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
> I understand this is a simple fix, but please provide a commit log. In
> this case, something like the following would suffice:
>
> "source" is a bashism, replace it with the posix shell compliant "."
Thanks.
Comment added and V2 sent.
Best Regards,
Chen Qi
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> Acked-by: Darren Hart <dvhart@linux.intel.com>
>
>
>> ---
>> meta-yocto/recipes-core/tiny-init/files/init | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-yocto/recipes-core/tiny-init/files/init b/meta-yocto/recipes-core/tiny-init/files/init
>> index 4b78f01..9140e95 100644
>> --- a/meta-yocto/recipes-core/tiny-init/files/init
>> +++ b/meta-yocto/recipes-core/tiny-init/files/init
>> @@ -15,7 +15,7 @@ ifup lo
>>
>> # Allow for distro or local customizations
>> if [ -f /etc/rc.local ] ; then
>> - source /etc/rc.local
>> + . /etc/rc.local
>> fi
>>
>> # Become session leader and try to find a real tty (e.g. ttyS0)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-05 1:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1375430111.git.Qi.Chen@windriver.com>
2013-08-02 7:56 ` [PATCH 1/1] tiny-init: fix bashism Qi.Chen
2013-08-02 14:05 ` Darren Hart
2013-08-05 1:28 ` ChenQi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.