All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
To: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	"mturquette@linaro.org" <mturquette@linaro.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit
Date: Mon, 5 Aug 2013 16:04:56 +0300	[thread overview]
Message-ID: <51FFA2F8.6040200@nvidia.com> (raw)
In-Reply-To: <51FF487F.6000007@nvidia.com>

On 08/05/2013 09:38 AM, Prashant Gaikwad wrote:
> On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote:
>> On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote:
>>> The lock bit on PLL_U does not seem to be working correctly and
>>> sometimes never gets set when waiting for the PLL to come up.
>>> Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.
>> Peter, Prashant,
>>
>> I think you said that the lock bits should work on Tegra30 (albeit they
>> don't on Tegra20)? Can you remind me if the do/don't?
>>
>> If Peter and Prashant are OK with this patch, feel free to take my ack.
> 
> Hi Tuomas,
> 
> Sorry for the delayed response. Please make sure that avdd_usb_pll 
> regulator is enabled before enabling PLLU and utmip parameters are 
> configured properly.

As far as I can see, avdd_usb_pll is connected to the vio_reg regulator on Cardhu,
which is marked as regulator-always-on. And the same regulator is connected to
eg. VDDIO_UART on the chip, so I presume almost nothing would work if that regulator
would not be on...

> If this this regulator is not enabled then you will get this kind of 
> timeout when enabling PLLU.
> 
> Thanks,
> Prashant
> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

      reply	other threads:[~2013-08-05 13:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31 17:42 [PATCH] Clock changes for Tegra30 USB Host support Tuomas Tynkkynen
2013-07-31 17:42 ` Tuomas Tynkkynen
     [not found] ` <1375292551-7933-1-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-31 17:42   ` [PATCH] clk: tegra30: Don't wait for PLL_U lock bit Tuomas Tynkkynen
2013-07-31 17:42     ` Tuomas Tynkkynen
     [not found]     ` <1375292551-7933-2-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-31 21:04       ` Stephen Warren
2013-07-31 21:04         ` Stephen Warren
     [not found]         ` <51F97BEA.7040006-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-05  6:38           ` Prashant Gaikwad
2013-08-05  6:38             ` Prashant Gaikwad
2013-08-05 13:04             ` Tuomas Tynkkynen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FFA2F8.6040200@nvidia.com \
    --to=ttynkkynen@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.