[PATCH] Clock changes for Tegra30 USB Host support

[PATCH] Clock changes for Tegra30 USB Host support

[Tuomas Tynkkynen]

Hi all,

This patch is required for USB support on Tegra30 due to a likely hardware
bug in the PLL_U oscillator which clocks the USB complex.

Tuomas Tynkkynen (1):
  clk: tegra30: Don't wait for PLL_U lock bit

 drivers/clk/tegra/clk-tegra30.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.1.5

[PATCH] Clock changes for Tegra30 USB Host support

[Tuomas Tynkkynen]

Hi all,

This patch is required for USB support on Tegra30 due to a likely hardware
bug in the PLL_U oscillator which clocks the USB complex.

Tuomas Tynkkynen (1):
  clk: tegra30: Don't wait for PLL_U lock bit

 drivers/clk/tegra/clk-tegra30.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.1.5

[PATCH] clk: tegra30: Don't wait for PLL_U lock bit

[Tuomas Tynkkynen]

The lock bit on PLL_U does not seem to be working correctly and
sometimes never gets set when waiting for the PLL to come up.
Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.

Signed-off-by: Tuomas Tynkkynen <ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 drivers/clk/tegra/clk-tegra30.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index e2c6ca0..9103fc8 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -971,7 +971,7 @@ static void __init tegra30_pll_init(void)
 	/* PLLU */
 	clk = tegra_clk_register_pll("pll_u", "pll_ref", clk_base, pmc_base, 0,
 			    0, &pll_u_params, TEGRA_PLLU | TEGRA_PLL_HAS_CPCON |
-			    TEGRA_PLL_SET_LFCON | TEGRA_PLL_USE_LOCK,
+			    TEGRA_PLL_SET_LFCON,
 			    pll_u_freq_table,
 			    NULL);
 	clk_register_clkdev(clk, "pll_u", NULL);
-- 
1.8.1.5

[PATCH] clk: tegra30: Don't wait for PLL_U lock bit

[Tuomas Tynkkynen]

The lock bit on PLL_U does not seem to be working correctly and
sometimes never gets set when waiting for the PLL to come up.
Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.

Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
---
 drivers/clk/tegra/clk-tegra30.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index e2c6ca0..9103fc8 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -971,7 +971,7 @@ static void __init tegra30_pll_init(void)
 	/* PLLU */
 	clk = tegra_clk_register_pll("pll_u", "pll_ref", clk_base, pmc_base, 0,
 			    0, &pll_u_params, TEGRA_PLLU | TEGRA_PLL_HAS_CPCON |
-			    TEGRA_PLL_SET_LFCON | TEGRA_PLL_USE_LOCK,
+			    TEGRA_PLL_SET_LFCON,
 			    pll_u_freq_table,
 			    NULL);
 	clk_register_clkdev(clk, "pll_u", NULL);
-- 
1.8.1.5

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

[Stephen Warren]

On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote:
> The lock bit on PLL_U does not seem to be working correctly and
> sometimes never gets set when waiting for the PLL to come up.
> Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.

Peter, Prashant,

I think you said that the lock bits should work on Tegra30 (albeit they
don't on Tegra20)? Can you remind me if the do/don't?

If Peter and Prashant are OK with this patch, feel free to take my ack.

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

[Stephen Warren]

On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote:
> The lock bit on PLL_U does not seem to be working correctly and
> sometimes never gets set when waiting for the PLL to come up.
> Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.

Peter, Prashant,

I think you said that the lock bits should work on Tegra30 (albeit they
don't on Tegra20)? Can you remind me if the do/don't?

If Peter and Prashant are OK with this patch, feel free to take my ack.

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

[Prashant Gaikwad]

On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote:
> On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote:
>> The lock bit on PLL_U does not seem to be working correctly and
>> sometimes never gets set when waiting for the PLL to come up.
>> Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.
> Peter, Prashant,
>
> I think you said that the lock bits should work on Tegra30 (albeit they
> don't on Tegra20)? Can you remind me if the do/don't?
>
> If Peter and Prashant are OK with this patch, feel free to take my ack.

Hi Tuomas,

Sorry for the delayed response. Please make sure that avdd_usb_pll 
regulator is enabled before enabling PLLU and utmip parameters are 
configured properly.
If this this regulator is not enabled then you will get this kind of 
timeout when enabling PLLU.

Thanks,
Prashant

> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

[Prashant Gaikwad]

On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote:
> On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote:
>> The lock bit on PLL_U does not seem to be working correctly and
>> sometimes never gets set when waiting for the PLL to come up.
>> Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.
> Peter, Prashant,
>
> I think you said that the lock bits should work on Tegra30 (albeit they
> don't on Tegra20)? Can you remind me if the do/don't?
>
> If Peter and Prashant are OK with this patch, feel free to take my ack.

Hi Tuomas,

Sorry for the delayed response. Please make sure that avdd_usb_pll 
regulator is enabled before enabling PLLU and utmip parameters are 
configured properly.
If this this regulator is not enabled then you will get this kind of 
timeout when enabling PLLU.

Thanks,
Prashant

> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

[Tuomas Tynkkynen]

On 08/05/2013 09:38 AM, Prashant Gaikwad wrote:
> On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote:
>> On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote:
>>> The lock bit on PLL_U does not seem to be working correctly and
>>> sometimes never gets set when waiting for the PLL to come up.
>>> Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay.
>> Peter, Prashant,
>>
>> I think you said that the lock bits should work on Tegra30 (albeit they
>> don't on Tegra20)? Can you remind me if the do/don't?
>>
>> If Peter and Prashant are OK with this patch, feel free to take my ack.
> 
> Hi Tuomas,
> 
> Sorry for the delayed response. Please make sure that avdd_usb_pll 
> regulator is enabled before enabling PLLU and utmip parameters are 
> configured properly.

As far as I can see, avdd_usb_pll is connected to the vio_reg regulator on Cardhu,
which is marked as regulator-always-on. And the same regulator is connected to
eg. VDDIO_UART on the chip, so I presume almost nothing would work if that regulator
would not be on...

> If this this regulator is not enabled then you will get this kind of 
> timeout when enabling PLLU.
> 
> Thanks,
> Prashant
> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>