All of lore.kernel.org
 help / color / mirror / Atom feed
From: gubbaven@codeaurora.org
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	Balakrishna Godavarthi <bgodavar@codeaurora.org>,
	hemantg@codeaurora.org, Johan Hedberg <johan.hedberg@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Rocky Liao <rjliao@codeaurora.org>, Rob Herring <robh@kernel.org>,
	Sean Paul <seanpaul@chromium.org>,
	Claire Chang <tientzu@chromium.org>,
	yshavit@google.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout
Date: Tue, 09 Jun 2020 15:51:06 +0000	[thread overview]
Message-ID: <51c4dfe5daf8497bd99a013458d93b92@codeaurora.org> (raw)
In-Reply-To: <d3444be6-28e6-bef5-08cf-6038620f65c6@web.de>

Hi Markus,

Sure we will update in next patch set.

Regards,
Lakshmi Narayna.
On 2020-06-04 23:54, Markus Elfring wrote:
>> Due to race conditions between qca_hw_error and qca_controller_memdump
>> during SSR timeout,the same pointer is freed twice.
> 
> This is an unfortunate software situation.
> 
> 
>> Which results to double free error.
> 
> How do you think about to omit this sentence from the change 
> description?
> 
> 
>> Now a lock is acquired while SSR state moved to timeout.
> 
> I suggest to convert this information into an imperative wording.
> 
> Would you like to add the tag “Fixes” to the commit message?
> 
> Regards,
> Markus

WARNING: multiple messages have this Message-ID (diff)
From: gubbaven@codeaurora.org
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	Balakrishna Godavarthi <bgodavar@codeaurora.org>,
	hemantg@codeaurora.org, Johan Hedberg <johan.hedberg@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Rocky Liao <rjliao@codeaurora.org>, Rob Herring <robh@kernel.org>,
	Sean Paul <seanpaul@chromium.org>,
	Claire Chang <tientzu@chromium.org>,
	yshavit@google.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout
Date: Tue, 09 Jun 2020 21:20:43 +0530	[thread overview]
Message-ID: <51c4dfe5daf8497bd99a013458d93b92@codeaurora.org> (raw)
In-Reply-To: <d3444be6-28e6-bef5-08cf-6038620f65c6@web.de>

Hi Markus,

Sure we will update in next patch set.

Regards,
Lakshmi Narayna.
On 2020-06-04 23:54, Markus Elfring wrote:
>> Due to race conditions between qca_hw_error and qca_controller_memdump
>> during SSR timeout,the same pointer is freed twice.
> 
> This is an unfortunate software situation.
> 
> 
>> Which results to double free error.
> 
> How do you think about to omit this sentence from the change 
> description?
> 
> 
>> Now a lock is acquired while SSR state moved to timeout.
> 
> I suggest to convert this information into an imperative wording.
> 
> Would you like to add the tag “Fixes” to the commit message?
> 
> Regards,
> Markus

  reply	other threads:[~2020-06-09 15:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 18:24 [PATCH] Bluetooth: hci_qca: Fix double free during SSR timeout Markus Elfring
2020-06-04 18:24 ` Markus Elfring
2020-06-09 15:50 ` gubbaven [this message]
2020-06-09 15:51   ` gubbaven
2020-06-10 14:54 ` Greg KH
2020-06-10 14:54   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51c4dfe5daf8497bd99a013458d93b92@codeaurora.org \
    --to=gubbaven@codeaurora.org \
    --cc=Markus.Elfring@web.de \
    --cc=bgodavar@codeaurora.org \
    --cc=hemantg@codeaurora.org \
    --cc=johan.hedberg@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mka@chromium.org \
    --cc=rjliao@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=tientzu@chromium.org \
    --cc=yshavit@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.