[PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume

[PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume

[Brian Austin]

Beep Volume Min/Max was backwards.
Change to SOC_SONGLE_SX_TLV for correct volume representation

Signed-off-by: Brian Austin <brian.austin@cirrus.com>
---
  sound/soc/codecs/cs42l52.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c
index 987f728..ee25f32 100644
--- a/sound/soc/codecs/cs42l52.c
+++ b/sound/soc/codecs/cs42l52.c
@@ -451,7 +451,7 @@ static const struct snd_kcontrol_new cs42l52_snd_controls[] = {
  	SOC_ENUM("Beep Pitch", beep_pitch_enum),
  	SOC_ENUM("Beep on Time", beep_ontime_enum),
  	SOC_ENUM("Beep off Time", beep_offtime_enum),
-	SOC_SINGLE_TLV("Beep Volume", CS42L52_BEEP_VOL, 0, 0x1f, 0x07, hl_tlv),
+	SOC_SINGLE_SX_TLV("Beep Volume", CS42L52_BEEP_VOL, 0, 0x07, 0x1f, hl_tlv),
  	SOC_SINGLE("Beep Mixer Switch", CS42L52_BEEP_TONE_CTL, 5, 1, 1),
  	SOC_ENUM("Beep Treble Corner Freq", beep_treble_enum),
  	SOC_ENUM("Beep Bass Corner Freq", beep_bass_enum),
-- 
1.7.10.4

Re: [PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 307 bytes --]

On Mon, Aug 05, 2013 at 03:08:47PM -0500, Brian Austin wrote:
> Beep Volume Min/Max was backwards.
> Change to SOC_SONGLE_SX_TLV for correct volume representation

This doesn't apply against v3.11-rc4 - can you check what's going on
there please?  I don't see any obvious issues by eye which is
worrying...

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume

[Brian Austin]

On Mon, 5 Aug 2013, Mark Brown wrote:

> On Mon, Aug 05, 2013 at 03:08:47PM -0500, Brian Austin wrote:
>> Beep Volume Min/Max was backwards.
>> Change to SOC_SONGLE_SX_TLV for correct volume representation
>
> This doesn't apply against v3.11-rc4 - can you check what's going on
> there please?  I don't see any obvious issues by eye which is
> worrying...
>
huh,  I just did a fresh pull of for-next and applied and it did fine...
It is SINGLE instead of SONGLE though :) But that wasn't the patch itself

Re: [PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume

[Lars-Peter Clausen]

On 08/05/2013 10:31 PM, Brian Austin wrote:
> On Mon, 5 Aug 2013, Mark Brown wrote:
>
>> On Mon, Aug 05, 2013 at 03:08:47PM -0500, Brian Austin wrote:
>>> Beep Volume Min/Max was backwards.
>>> Change to SOC_SONGLE_SX_TLV for correct volume representation
>>
>> This doesn't apply against v3.11-rc4 - can you check what's going on
>> there please?  I don't see any obvious issues by eye which is
>> worrying...
>>
> huh,  I just did a fresh pull of for-next and applied and it did fine...
> It is SINGLE instead of SONGLE though :) But that wasn't the patch itself
>

Looks like your mail client replaced the tabs in the patch with spaces.

- Lars

Re: [PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume

[Austin, Brian]

On Aug 5, 2013, at 15:34, "Lars-Peter Clausen" <lars@metafoo.de> wrote:

> On 08/05/2013 10:31 PM, Brian Austin wrote:
>> On Mon, 5 Aug 2013, Mark Brown wrote:
>> 
>>> On Mon, Aug 05, 2013 at 03:08:47PM -0500, Brian Austin wrote:
>>>> Beep Volume Min/Max was backwards.
>>>> Change to SOC_SONGLE_SX_TLV for correct volume representation
>>> 
>>> This doesn't apply against v3.11-rc4 - can you check what's going on
>>> there please?  I don't see any obvious issues by eye which is
>>> worrying...
>> huh,  I just did a fresh pull of for-next and applied and it did fine...
>> It is SINGLE instead of SONGLE though :) But that wasn't the patch itself
> 
> Looks like your mail client replaced the tabs in the patch with spaces.
> 
> - Lars
> 
Ok, so I guess FWD from pine won't work.  Good grief. I'll have to fix my git mailer tomorrow.

Sorry for the delay

[PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume

[brian.austin]

From: Brian Austin <brian.austin@cirrus.com>

Beep Volume Min/Max was backwards.
Change to SOC_SONGLE_SX_TLV for correct volume representation

Signed-off-by: Brian Austin <brian.austin@cirrus.com>
---
 sound/soc/codecs/cs42l52.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c
index 987f728..ee25f32 100644
--- a/sound/soc/codecs/cs42l52.c
+++ b/sound/soc/codecs/cs42l52.c
@@ -451,7 +451,7 @@ static const struct snd_kcontrol_new cs42l52_snd_controls[] = {
 	SOC_ENUM("Beep Pitch", beep_pitch_enum),
 	SOC_ENUM("Beep on Time", beep_ontime_enum),
 	SOC_ENUM("Beep off Time", beep_offtime_enum),
-	SOC_SINGLE_TLV("Beep Volume", CS42L52_BEEP_VOL, 0, 0x1f, 0x07, hl_tlv),
+	SOC_SINGLE_SX_TLV("Beep Volume", CS42L52_BEEP_VOL, 0, 0x07, 0x1f, hl_tlv),
 	SOC_SINGLE("Beep Mixer Switch", CS42L52_BEEP_TONE_CTL, 5, 1, 1),
 	SOC_ENUM("Beep Treble Corner Freq", beep_treble_enum),
 	SOC_ENUM("Beep Bass Corner Freq", beep_bass_enum),
-- 
1.7.10.4

Re: [PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 254 bytes --]

On Tue, Aug 06, 2013 at 12:57:21PM -0500, brian.austin@cirrus.com wrote:
> From: Brian Austin <brian.austin@cirrus.com>
> 
> Beep Volume Min/Max was backwards.
> Change to SOC_SONGLE_SX_TLV for correct volume representation

Applied both, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]