From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: hannes@cmpxchg.org, mhocko@suse.cz, bsingharora@gmail.com,
kamezawa.hiroyu@jp.fujitsu.com, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] cgroup, memcg: move cgroup_event implementation to memcg
Date: Tue, 6 Aug 2013 10:21:06 +0800 [thread overview]
Message-ID: <52005D92.1090103@huawei.com> (raw)
In-Reply-To: <5200593C.7090005@huawei.com>
On 2013/8/6 10:02, Li Zefan wrote:
>> static struct cftype mem_cgroup_files[] = {
>> {
>> .name = "usage_in_bytes",
>> @@ -5973,6 +6192,12 @@ static struct cftype mem_cgroup_files[] = {
>> .read_u64 = mem_cgroup_hierarchy_read,
>> },
>> {
>> + .name = "cgroup.event_control",
>> + .write_string = cgroup_write_event_control,
>> + .flags = CFTYPE_NO_PREFIX,
>> + .mode = S_IWUGO,
>> + },
>
> One of the misdesign of cgroup eventfd is, cgroup.event_control is
> totally redunant...
>
ok. write_string() is needed to accept arguments and pass them to
the event register function. still not good.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <hannes@cmpxchg.org>, <mhocko@suse.cz>, <bsingharora@gmail.com>,
<kamezawa.hiroyu@jp.fujitsu.com>, <cgroups@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] cgroup, memcg: move cgroup_event implementation to memcg
Date: Tue, 6 Aug 2013 10:21:06 +0800 [thread overview]
Message-ID: <52005D92.1090103@huawei.com> (raw)
In-Reply-To: <5200593C.7090005@huawei.com>
On 2013/8/6 10:02, Li Zefan wrote:
>> static struct cftype mem_cgroup_files[] = {
>> {
>> .name = "usage_in_bytes",
>> @@ -5973,6 +6192,12 @@ static struct cftype mem_cgroup_files[] = {
>> .read_u64 = mem_cgroup_hierarchy_read,
>> },
>> {
>> + .name = "cgroup.event_control",
>> + .write_string = cgroup_write_event_control,
>> + .flags = CFTYPE_NO_PREFIX,
>> + .mode = S_IWUGO,
>> + },
>
> One of the misdesign of cgroup eventfd is, cgroup.event_control is
> totally redunant...
>
ok. write_string() is needed to accept arguments and pass them to
the event register function. still not good.
next prev parent reply other threads:[~2013-08-06 2:21 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 16:07 [PATCHSET cgroup/for-3.12] cgroup: make cgroup_event specific to memcg Tejun Heo
2013-08-04 16:07 ` Tejun Heo
2013-08-04 16:07 ` Tejun Heo
2013-08-04 16:07 ` [PATCH 1/5] cgroup: implement CFTYPE_NO_PREFIX Tejun Heo
2013-08-04 16:07 ` Tejun Heo
2013-08-04 16:07 ` [PATCH 2/5] cgroup: export __cgroup_from_dentry() and __cgroup_dput() Tejun Heo
2013-08-04 16:07 ` Tejun Heo
2013-08-05 2:58 ` Li Zefan
2013-08-05 2:58 ` Li Zefan
[not found] ` <51FF14C5.4040003-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-05 15:40 ` Tejun Heo
2013-08-05 15:40 ` Tejun Heo
2013-08-05 15:40 ` Tejun Heo
[not found] ` <1375632446-2581-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-05 17:08 ` [PATCH v2 2/5] cgroup: make __cgroup_from_dentry() and __cgroup_dput() global Tejun Heo
2013-08-05 17:08 ` Tejun Heo
2013-08-05 17:08 ` Tejun Heo
2013-08-04 16:07 ` [PATCH 3/5] cgroup, memcg: move cgroup_event implementation to memcg Tejun Heo
2013-08-04 16:07 ` Tejun Heo
2013-08-05 3:14 ` Li Zefan
2013-08-05 3:14 ` Li Zefan
2013-08-05 3:14 ` Li Zefan
[not found] ` <1375632446-2581-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-05 17:09 ` [PATCH v2 " Tejun Heo
2013-08-05 17:09 ` Tejun Heo
2013-08-05 17:09 ` Tejun Heo
2013-08-06 2:02 ` Li Zefan
2013-08-06 2:02 ` Li Zefan
2013-08-06 2:21 ` Li Zefan [this message]
2013-08-06 2:21 ` Li Zefan
2013-08-06 3:26 ` [PATCH " Balbir Singh
2013-08-06 3:26 ` Balbir Singh
2013-08-06 14:09 ` Tejun Heo
2013-08-06 14:09 ` Tejun Heo
2013-08-06 16:03 ` Balbir Singh
2013-08-06 16:03 ` Balbir Singh
2013-08-04 16:07 ` [PATCH 4/5] cgroup, memcg: move cgroup->event_list[_lock] and event callbacks into memcg Tejun Heo
2013-08-04 16:07 ` Tejun Heo
2013-08-04 16:07 ` [PATCH 5/5] memcg: rename cgroup_event to mem_cgroup_event Tejun Heo
2013-08-04 16:07 ` Tejun Heo
2013-08-05 3:26 ` Li Zefan
2013-08-05 3:26 ` Li Zefan
[not found] ` <1375632446-2581-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-05 17:10 ` [PATCH v2 " Tejun Heo
2013-08-05 17:10 ` Tejun Heo
2013-08-05 17:10 ` Tejun Heo
[not found] ` <1375632446-2581-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-05 16:01 ` [PATCHSET cgroup/for-3.12] cgroup: make cgroup_event specific to memcg Michal Hocko
2013-08-05 16:01 ` Michal Hocko
2013-08-05 16:01 ` Michal Hocko
2013-08-05 16:29 ` Tejun Heo
2013-08-05 16:29 ` Tejun Heo
2013-08-05 19:16 ` Michal Hocko
2013-08-05 19:16 ` Michal Hocko
2013-08-05 19:44 ` Tejun Heo
2013-08-05 19:44 ` Tejun Heo
[not found] ` <20130805194431.GD23751-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-08-06 15:58 ` Michal Hocko
2013-08-06 15:58 ` Michal Hocko
2013-08-06 15:58 ` Michal Hocko
2013-08-06 16:15 ` Tejun Heo
2013-08-06 16:15 ` Tejun Heo
2013-08-07 12:18 ` Michal Hocko
2013-08-07 12:18 ` Michal Hocko
2013-08-07 12:43 ` Tejun Heo
2013-08-07 12:43 ` Tejun Heo
[not found] ` <20130807124321.GA27006-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-07 13:26 ` Michal Hocko
2013-08-07 13:26 ` Michal Hocko
2013-08-07 13:26 ` Michal Hocko
2013-08-07 13:36 ` Tejun Heo
2013-08-07 13:36 ` Tejun Heo
2013-08-08 2:53 ` Li Zefan
2013-08-08 2:53 ` Li Zefan
2013-08-09 1:00 ` Tejun Heo
2013-08-09 1:00 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52005D92.1090103@huawei.com \
--to=lizefan@huawei.com \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.