From: Tuomas Tynkkynen <ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
Cc: "balbi-l0cyMroinI0@public.gmane.org"
<balbi-l0cyMroinI0@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org"
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Subject: Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support
Date: Tue, 6 Aug 2013 22:16:25 +0300 [thread overview]
Message-ID: <52014B89.9040106@nvidia.com> (raw)
In-Reply-To: <520141F2.4060907-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
On 08/06/2013 09:35 PM, Sergei Shtylyov wrote:
> Hello.
>
[...]
>>
>> + match = of_match_device(tegra_ehci_of_match, &pdev->dev);
>> + if (!match) {
>> + dev_err(&pdev->dev, "Error: No device match found\n");
>> + return -ENODEV;
>> + }
>> + soc_config = (struct tegra_ehci_soc_config *)match->data;
>
> Aren't casts from 'const void *' automatic?
>
> WBR, Sergei
>
Indeed they are, but those explicit casts seem to be used in many places in the kernel.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "balbi@ti.com" <balbi@ti.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support
Date: Tue, 6 Aug 2013 22:16:25 +0300 [thread overview]
Message-ID: <52014B89.9040106@nvidia.com> (raw)
In-Reply-To: <520141F2.4060907@cogentembedded.com>
On 08/06/2013 09:35 PM, Sergei Shtylyov wrote:
> Hello.
>
[...]
>>
>> + match = of_match_device(tegra_ehci_of_match, &pdev->dev);
>> + if (!match) {
>> + dev_err(&pdev->dev, "Error: No device match found\n");
>> + return -ENODEV;
>> + }
>> + soc_config = (struct tegra_ehci_soc_config *)match->data;
>
> Aren't casts from 'const void *' automatic?
>
> WBR, Sergei
>
Indeed they are, but those explicit casts seem to be used in many places in the kernel.
next prev parent reply other threads:[~2013-08-06 19:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 18:08 [PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support Tuomas Tynkkynen
2013-08-06 18:08 ` Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 1/6] usb: host: add has_tdi_phy_lpm capability bit Tuomas Tynkkynen
2013-08-06 18:08 ` Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 2/6] usb: phy: tegra: Fix wrong PHY parameters Tuomas Tynkkynen
2013-08-06 18:08 ` Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 3/6] usb: phy: tegra: Tegra30 support Tuomas Tynkkynen
2013-08-06 18:08 ` Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 4/6] Documentation: New DT parameters for tegra30-usb-phy Tuomas Tynkkynen
2013-08-06 18:08 ` Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 5/6] usb: phy: tegra: Program new PHY parameters Tuomas Tynkkynen
2013-08-06 18:08 ` Tuomas Tynkkynen
[not found] ` <1375812518-3847-1-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-06 18:08 ` [PATCH v2 6/6] usb: host: tegra: Tegra30 support Tuomas Tynkkynen
2013-08-06 18:08 ` Tuomas Tynkkynen
2013-08-06 18:35 ` Sergei Shtylyov
[not found] ` <520141F2.4060907-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-08-06 19:16 ` Tuomas Tynkkynen [this message]
2013-08-06 19:16 ` Tuomas Tynkkynen
[not found] ` <52014B89.9040106-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-06 19:27 ` Sergei Shtylyov
2013-08-06 19:27 ` Sergei Shtylyov
[not found] ` <52014E0F.10404-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-08-09 13:37 ` Felipe Balbi
2013-08-09 13:37 ` Felipe Balbi
2013-08-06 19:46 ` [PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support Stephen Warren
2013-08-06 19:46 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52014B89.9040106@nvidia.com \
--to=ttynkkynen-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.