* [PATCH 0/2] KVM: PPC: Book3E HV: Rework to sync the software state
@ 2013-08-06 9:31 ` Tiejun Chen
0 siblings, 0 replies; 10+ messages in thread
From: Tiejun Chen @ 2013-08-06 9:31 UTC (permalink / raw)
To: agraf; +Cc: kvm, kvm-ppc, scottwood
For more detail please have a look at this :)
http://patchwork.ozlabs.org/patch/257974/
http://ns1.yosemitephotos.net/lists/kvm-ppc/msg07430.html
Tiejun Chen (2):
Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"
KVM: PPC: Book3E HV: call SOFT_DISABLE_INTS to sync the software state
arch/powerpc/kvm/booke.c | 11 -----------
arch/powerpc/kvm/bookehv_interrupts.S | 10 ++++++++++
2 files changed, 10 insertions(+), 11 deletions(-)
Tiejun
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 0/2] KVM: PPC: Book3E HV: Rework to sync the software state
@ 2013-08-06 9:31 ` Tiejun Chen
0 siblings, 0 replies; 10+ messages in thread
From: Tiejun Chen @ 2013-08-06 9:31 UTC (permalink / raw)
To: agraf; +Cc: kvm, kvm-ppc, scottwood
For more detail please have a look at this :)
http://patchwork.ozlabs.org/patch/257974/
http://ns1.yosemitephotos.net/lists/kvm-ppc/msg07430.html
Tiejun Chen (2):
Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"
KVM: PPC: Book3E HV: call SOFT_DISABLE_INTS to sync the software state
arch/powerpc/kvm/booke.c | 11 -----------
arch/powerpc/kvm/bookehv_interrupts.S | 10 ++++++++++
2 files changed, 10 insertions(+), 11 deletions(-)
Tiejun
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/2] Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"
2013-08-06 9:31 ` Tiejun Chen
@ 2013-08-06 9:31 ` Tiejun Chen
-1 siblings, 0 replies; 10+ messages in thread
From: Tiejun Chen @ 2013-08-06 9:31 UTC (permalink / raw)
To: agraf; +Cc: kvm, kvm-ppc, scottwood
We should revert this commit to rework.
Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
---
arch/powerpc/kvm/booke.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 17722d8..7653c9c 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -833,17 +833,6 @@ int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu,
int s;
int idx;
-#ifdef CONFIG_PPC64
- WARN_ON(local_paca->irq_happened != 0);
-#endif
-
- /*
- * We enter with interrupts disabled in hardware, but
- * we need to call hard_irq_disable anyway to ensure that
- * the software state is kept in sync.
- */
- hard_irq_disable();
-
/* update before a new last_exit_type is rewritten */
kvmppc_update_timing_stats(vcpu);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/2] Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"
@ 2013-08-06 9:31 ` Tiejun Chen
0 siblings, 0 replies; 10+ messages in thread
From: Tiejun Chen @ 2013-08-06 9:31 UTC (permalink / raw)
To: agraf; +Cc: kvm, kvm-ppc, scottwood
We should revert this commit to rework.
Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
---
arch/powerpc/kvm/booke.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 17722d8..7653c9c 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -833,17 +833,6 @@ int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu,
int s;
int idx;
-#ifdef CONFIG_PPC64
- WARN_ON(local_paca->irq_happened != 0);
-#endif
-
- /*
- * We enter with interrupts disabled in hardware, but
- * we need to call hard_irq_disable anyway to ensure that
- * the software state is kept in sync.
- */
- hard_irq_disable();
-
/* update before a new last_exit_type is rewritten */
kvmppc_update_timing_stats(vcpu);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"
2013-08-06 9:31 ` Tiejun Chen
@ 2013-08-06 20:50 ` Scott Wood
-1 siblings, 0 replies; 10+ messages in thread
From: Scott Wood @ 2013-08-06 20:50 UTC (permalink / raw)
To: Tiejun Chen; +Cc: agraf, kvm, kvm-ppc
On Tue, 2013-08-06 at 17:31 +0800, Tiejun Chen wrote:
> We should revert this commit to rework.
>
> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
This breaks bisect.
-Scott
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"
@ 2013-08-06 20:50 ` Scott Wood
0 siblings, 0 replies; 10+ messages in thread
From: Scott Wood @ 2013-08-06 20:50 UTC (permalink / raw)
To: Tiejun Chen; +Cc: agraf, kvm, kvm-ppc
On Tue, 2013-08-06 at 17:31 +0800, Tiejun Chen wrote:
> We should revert this commit to rework.
>
> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
This breaks bisect.
-Scott
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"
2013-08-06 20:50 ` Scott Wood
@ 2013-08-07 1:58 ` "“tiejun.chen”"
-1 siblings, 0 replies; 10+ messages in thread
From: "“tiejun.chen”" @ 2013-08-07 1:58 UTC (permalink / raw)
To: Scott Wood; +Cc: agraf, kvm, kvm-ppc
On 08/07/2013 04:50 AM, Scott Wood wrote:
> On Tue, 2013-08-06 at 17:31 +0800, Tiejun Chen wrote:
>> We should revert this commit to rework.
>>
>> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
>
> This breaks bisect.
Hmm...
Maybe I can squash these two patches into one.
Tiejun
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()"
@ 2013-08-07 1:58 ` "“tiejun.chen”"
0 siblings, 0 replies; 10+ messages in thread
From: "“tiejun.chen”" @ 2013-08-07 1:58 UTC (permalink / raw)
To: Scott Wood; +Cc: agraf, kvm, kvm-ppc
On 08/07/2013 04:50 AM, Scott Wood wrote:
> On Tue, 2013-08-06 at 17:31 +0800, Tiejun Chen wrote:
>> We should revert this commit to rework.
>>
>> Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
>
> This breaks bisect.
Hmm...
Maybe I can squash these two patches into one.
Tiejun
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] KVM: PPC: Book3E HV: call SOFT_DISABLE_INTS to sync the software state
2013-08-06 9:31 ` Tiejun Chen
@ 2013-08-06 9:31 ` Tiejun Chen
-1 siblings, 0 replies; 10+ messages in thread
From: Tiejun Chen @ 2013-08-06 9:31 UTC (permalink / raw)
To: agraf; +Cc: kvm, kvm-ppc, scottwood
We enter with interrupts disabled in hardware, but we need to
call SOFT_DISABLE_INTS anyway to ensure that the software state
is kept in sync.
Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
---
arch/powerpc/kvm/bookehv_interrupts.S | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
index e8ed7d6..4deaf2e 100644
--- a/arch/powerpc/kvm/bookehv_interrupts.S
+++ b/arch/powerpc/kvm/bookehv_interrupts.S
@@ -33,6 +33,8 @@
#ifdef CONFIG_64BIT
#include <asm/exception-64e.h>
+#include <asm/hw_irq.h>
+#include <asm/irqflags.h>
#else
#include "../kernel/head_booke.h" /* for THREAD_NORMSAVE() */
#endif
@@ -465,6 +467,14 @@ _GLOBAL(kvmppc_resume_host)
mtspr SPRN_EPCR, r3
isync
+#ifdef CONFIG_64BIT
+ /*
+ * We enter with interrupts disabled in hardware, but
+ * we need to call SOFT_DISABLE_INTS anyway to ensure
+ * that the software state is kept in sync.
+ */
+ SOFT_DISABLE_INTS(r3,r5)
+#endif
/* Switch to kernel stack and jump to handler. */
PPC_LL r3, HOST_RUN(r1)
mr r5, r14 /* intno */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] KVM: PPC: Book3E HV: call SOFT_DISABLE_INTS to sync the software state
@ 2013-08-06 9:31 ` Tiejun Chen
0 siblings, 0 replies; 10+ messages in thread
From: Tiejun Chen @ 2013-08-06 9:31 UTC (permalink / raw)
To: agraf; +Cc: kvm, kvm-ppc, scottwood
We enter with interrupts disabled in hardware, but we need to
call SOFT_DISABLE_INTS anyway to ensure that the software state
is kept in sync.
Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
---
arch/powerpc/kvm/bookehv_interrupts.S | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
index e8ed7d6..4deaf2e 100644
--- a/arch/powerpc/kvm/bookehv_interrupts.S
+++ b/arch/powerpc/kvm/bookehv_interrupts.S
@@ -33,6 +33,8 @@
#ifdef CONFIG_64BIT
#include <asm/exception-64e.h>
+#include <asm/hw_irq.h>
+#include <asm/irqflags.h>
#else
#include "../kernel/head_booke.h" /* for THREAD_NORMSAVE() */
#endif
@@ -465,6 +467,14 @@ _GLOBAL(kvmppc_resume_host)
mtspr SPRN_EPCR, r3
isync
+#ifdef CONFIG_64BIT
+ /*
+ * We enter with interrupts disabled in hardware, but
+ * we need to call SOFT_DISABLE_INTS anyway to ensure
+ * that the software state is kept in sync.
+ */
+ SOFT_DISABLE_INTS(r3,r5)
+#endif
/* Switch to kernel stack and jump to handler. */
PPC_LL r3, HOST_RUN(r1)
mr r5, r14 /* intno */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-08-07 1:58 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06 9:31 [PATCH 0/2] KVM: PPC: Book3E HV: Rework to sync the software state Tiejun Chen
2013-08-06 9:31 ` Tiejun Chen
2013-08-06 9:31 ` [PATCH 1/2] Revert "kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit()" Tiejun Chen
2013-08-06 9:31 ` Tiejun Chen
2013-08-06 20:50 ` Scott Wood
2013-08-06 20:50 ` Scott Wood
2013-08-07 1:58 ` "“tiejun.chen”"
2013-08-07 1:58 ` "“tiejun.chen”"
2013-08-06 9:31 ` [PATCH 2/2] KVM: PPC: Book3E HV: call SOFT_DISABLE_INTS to sync the software state Tiejun Chen
2013-08-06 9:31 ` Tiejun Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.