From: Sudeep.KarkadaNagesha@arm.com (Sudeep KarkadaNagesha)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: mach-mvebu: remove redundant DT parsing and validation
Date: Thu, 08 Aug 2013 15:54:55 +0100 [thread overview]
Message-ID: <5203B13F.4060009@arm.com> (raw)
In-Reply-To: <1374579164-30255-4-git-send-email-Sudeep.KarkadaNagesha@arm.com>
On 23/07/13 12:32, Sudeep KarkadaNagesha wrote:
> From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
>
> arm_dt_init_cpu_maps parses the device tree, validates and sets the
> cpu_possible_mask appropriately. It is unnecessary to do another DT
> parse to get the number of cpus, use num_possible_cpus instead.
>
Hi Gregory,
Does this change look fine ?
If OK, not sure if you prefer to pick up this or want me to send to
arm-soc guys.
Regards,
Sudeep
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
> ---
> arch/arm/mach-mvebu/platsmp.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c
> index ce81d30..2e4508a 100644
> --- a/arch/arm/mach-mvebu/platsmp.c
> +++ b/arch/arm/mach-mvebu/platsmp.c
> @@ -87,28 +87,11 @@ static int armada_xp_boot_secondary(unsigned int cpu, struct task_struct *idle)
>
> static void __init armada_xp_smp_init_cpus(void)
> {
> - struct device_node *np;
> - unsigned int i, ncores;
> + unsigned int ncores = num_possible_cpus();
>
> - np = of_find_node_by_name(NULL, "cpus");
> - if (!np)
> - panic("No 'cpus' node found\n");
> -
> - ncores = of_get_child_count(np);
> if (ncores == 0 || ncores > ARMADA_XP_MAX_CPUS)
> panic("Invalid number of CPUs in DT\n");
>
> - /* Limit possible CPUs to defconfig */
> - if (ncores > nr_cpu_ids) {
> - pr_warn("SMP: %d CPUs physically present. Only %d configured.",
> - ncores, nr_cpu_ids);
> - pr_warn("Clipping CPU count to %d\n", nr_cpu_ids);
> - ncores = nr_cpu_ids;
> - }
> -
> - for (i = 0; i < ncores; i++)
> - set_cpu_possible(i, true);
> -
> set_smp_cross_call(armada_mpic_send_doorbell);
> }
>
>
next prev parent reply other threads:[~2013-08-08 14:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 11:32 [PATCH 0/5] ARM: DT: remove redundant DT related code Sudeep KarkadaNagesha
2013-07-23 11:32 ` [PATCH 1/5] ARM: keystone: remove redundant smp_init_cpus definition Sudeep KarkadaNagesha
2013-07-23 13:26 ` Santosh Shilimkar
2013-07-23 11:32 ` [PATCH 2/5] ARM: vexpress: remove redundant vexpress_dt_cpus_num to get cpu count Sudeep KarkadaNagesha
2013-08-09 9:25 ` Sudeep KarkadaNagesha
2013-07-23 11:32 ` [PATCH 3/5] ARM: mach-mvebu: remove redundant DT parsing and validation Sudeep KarkadaNagesha
2013-08-08 14:54 ` Sudeep KarkadaNagesha [this message]
2013-08-08 15:19 ` Gregory CLEMENT
2013-08-08 15:50 ` Jason Cooper
2013-08-09 13:11 ` Jason Cooper
2013-07-23 11:32 ` [PATCH 4/5] ARM: highbank: remove redundant smp_init_cpus definition Sudeep KarkadaNagesha
2013-07-23 15:03 ` Rob Herring
2013-07-23 15:34 ` Sudeep KarkadaNagesha
2013-07-23 11:32 ` [PATCH 5/5] ARM: zynq: remove unnecessary setting of cpu_present_mask Sudeep KarkadaNagesha
2013-07-23 12:31 ` [PATCH 0/5] ARM: DT: remove redundant DT related code Michal Simek
2013-07-23 12:36 ` Sudeep KarkadaNagesha
2013-07-23 19:45 ` Nicolas Pitre
2013-07-24 10:48 ` Sudeep KarkadaNagesha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203B13F.4060009@arm.com \
--to=sudeep.karkadanagesha@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.