All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	Stephen Warren <swarren@nvidia.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <Mark.Rutland@arm.com>
Subject: Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.
Date: Thu, 8 Aug 2013 22:41:20 +0530	[thread overview]
Message-ID: <5203D138.4030107@nvidia.com> (raw)
In-Reply-To: <52014E50.6030508@wwwdotorg.org>

On Wednesday 07 August 2013 12:58 AM, Stephen Warren wrote:
> (CC'ing DT bindings maintainers too, hence quoting a bit of the patch)
>
> On 08/06/2013 08:12 AM, Laxman Dewangan wrote:
>> Many of Key device tree bindings uses the constant number as key code
>> which matches with kernel header key code and then comment as follows
>> for reference/better readability:
>> 	linux,code = <102>; /* KEY_HOME */
>>
>> Create a DT header which defines all the key code so that DT key bindings
>> can use it as follows:
>> 	linux,code = <KEY_HOME>;
> This looks fine to me.
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
>
> A comment in support of the patch: This is adding OS-specific content to
> the DT. However, the bindings this header file supports are already
> written that way. There's not really any alternative here, since some
> numbering scheme had to be chosen for keycodes, and it may as well be
> the same set as the first/primary OS that'll use the binding.
>
> As far as merging it, this patch should probably go through the core DT
> tree, perhaps in a topic branch so that e.g. Tegra an MVEBU can merge it
> in to apply your subsequent patches (or we can just wait until the next
> kernel release to merge them in).

Do I need to include anyone for this patch to be applied or can go 
through Dmitry's input git branch?


WARNING: multiple messages have this Message-ID (diff)
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.
Date: Thu, 8 Aug 2013 22:41:20 +0530	[thread overview]
Message-ID: <5203D138.4030107@nvidia.com> (raw)
In-Reply-To: <52014E50.6030508@wwwdotorg.org>

On Wednesday 07 August 2013 12:58 AM, Stephen Warren wrote:
> (CC'ing DT bindings maintainers too, hence quoting a bit of the patch)
>
> On 08/06/2013 08:12 AM, Laxman Dewangan wrote:
>> Many of Key device tree bindings uses the constant number as key code
>> which matches with kernel header key code and then comment as follows
>> for reference/better readability:
>> 	linux,code = <102>; /* KEY_HOME */
>>
>> Create a DT header which defines all the key code so that DT key bindings
>> can use it as follows:
>> 	linux,code = <KEY_HOME>;
> This looks fine to me.
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
>
> A comment in support of the patch: This is adding OS-specific content to
> the DT. However, the bindings this header file supports are already
> written that way. There's not really any alternative here, since some
> numbering scheme had to be chosen for keycodes, and it may as well be
> the same set as the first/primary OS that'll use the binding.
>
> As far as merging it, this patch should probably go through the core DT
> tree, perhaps in a topic branch so that e.g. Tegra an MVEBU can merge it
> in to apply your subsequent patches (or we can just wait until the next
> kernel release to merge them in).

Do I need to include anyone for this patch to be applied or can go 
through Dmitry's input git branch?

  reply	other threads:[~2013-08-08 16:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06 14:12 [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes Laxman Dewangan
2013-08-06 14:12 ` Laxman Dewangan
2013-08-06 14:12 ` Laxman Dewangan
     [not found] ` <1375798370-2231-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-06 14:12   ` [PATCH 2/2] ARM: tegra: use dt-binding header for key code Laxman Dewangan
2013-08-06 14:12     ` Laxman Dewangan
2013-08-06 14:12     ` Laxman Dewangan
     [not found]     ` <1375798370-2231-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-06 19:28       ` Stephen Warren
2013-08-06 19:28         ` Stephen Warren
2013-08-06 19:28         ` Stephen Warren
2013-08-06 14:28 ` [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes Jason Cooper
2013-08-06 14:28   ` Jason Cooper
2013-08-06 19:28 ` Stephen Warren
2013-08-06 19:28   ` Stephen Warren
2013-08-08 17:11   ` Laxman Dewangan [this message]
2013-08-08 17:11     ` Laxman Dewangan
     [not found]     ` <5203D138.4030107-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-08 17:13       ` Dmitry Torokhov
2013-08-08 17:13         ` Dmitry Torokhov
2013-08-08 17:13         ` Dmitry Torokhov
2013-08-08 17:25         ` Stephen Warren
2013-08-08 17:25           ` Stephen Warren
     [not found]           ` <5203D487.5020507-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-12 17:15             ` Dmitry Torokhov
2013-08-12 17:15               ` Dmitry Torokhov
2013-08-12 17:15               ` Dmitry Torokhov
2013-08-12 17:59               ` Stephen Warren
2013-08-12 17:59                 ` Stephen Warren
     [not found]                 ` <52092299.4080104-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-19 14:53                   ` Laxman Dewangan
2013-08-19 14:53                     ` Laxman Dewangan
2013-08-19 14:53                     ` Laxman Dewangan
     [not found]                     ` <52123152.9070408-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-19 16:24                       ` Stephen Warren
2013-08-19 16:24                         ` Stephen Warren
2013-08-19 16:24                         ` Stephen Warren
2013-08-19 22:35                         ` Rob Herring
2013-08-19 22:35                           ` Rob Herring
2013-08-08 17:32         ` Laxman Dewangan
2013-08-08 17:32           ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5203D138.4030107@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=Mark.Rutland@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ian.campbell@citrix.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.