All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Marc C <marc.ceeeee@gmail.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED
Date: Thu, 08 Aug 2013 21:50:11 +0400	[thread overview]
Message-ID: <5203DA53.6000800@cogentembedded.com> (raw)
In-Reply-To: <1375946182-2831-2-git-send-email-marc.ceeeee@gmail.com>

Hello.

On 08/08/2013 11:16 AM, Marc C wrote:

> From: Marc Carino <marc.ceeeee@gmail.com>

> Add support for the following ATA opcodes, which are present
> in SATA 3.1 and T13 ATA ACS-3:

>          SEND FPDMA QUEUED
>          RECEIVE FPDMA QUEUED

> Signed-off-by: Marc Carino <marc.ceeeee@gmail.com>

[...]

> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index ee0bd95..dd26211 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
[...]
> @@ -509,6 +525,8 @@ struct ata_taskfile {
>   	u8			device;
>
>   	u8			command;	/* IO operation */
> +
> +	u32			auxiliary;

    You are still basing your work on the wrong branch -- you should use Tejun 
Heo's libata.git, 'for-3.12' branch. And you haven't removed this field from 
'struct ata_taskfile'...

WBR, Sergei


  reply	other threads:[~2013-08-08 17:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08  7:16 [PATCH v2 0/2] Introduce new SATA queued commands Marc C
2013-08-08  7:16 ` [PATCH v2 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED Marc C
2013-08-08 17:50   ` Sergei Shtylyov [this message]
2013-08-08 17:52   ` Sergei Shtylyov
2013-08-08 18:58     ` Marc C
2013-08-08 19:03       ` Sergei Shtylyov
2013-08-08 19:07         ` Sergei Shtylyov
2013-08-09 16:18         ` Tejun Heo
2013-08-08  7:16 ` [PATCH v2 2/2] libata: Add support for queued DSM TRIM Marc C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5203DA53.6000800@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=marc.ceeeee@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.