From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Marc C <marc.ceeeee@gmail.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED
Date: Thu, 08 Aug 2013 23:03:55 +0400 [thread overview]
Message-ID: <5203EB9B.3050206@cogentembedded.com> (raw)
In-Reply-To: <CAO1A-8DqjSAZ=GD6_BxxaBxvbsbYTUuPZSc-odr=bikUk3FtAg@mail.gmail.com>
Hello.
On 08/08/2013 10:58 PM, Marc C wrote:
>> How about non-AHCI FIS-based controllers?
> Right. Since it's cost prohibitive for me to test exhaustively on
> non-AHCI FIS-based controllers, do you think it would be acceptable to
You can mark your patch as RFT (request for testing) in this case.
> add a new ATA host flag... something like, ATA_FLAG_AHCI, which would
> denote the controller as being AHCI-based? Then the flag could be used
> to gate processing of READ/WRITE/SEND/RECEIVE FPDMA commands that have
> the 'auxiliary' field set. Or, I could add a big fat warning print
> whenever an ata_queued_cmd is passed to the drivers with a non-zero
> 'auxiliary' value.
I was rather thinking about a flag (ATA_FLAG_FIS_BASED, maybe) marking a
controller as FIS-based, so that libata would know whether it can issue the
new commands using the 'auxiliary' value.
> Regards,
> Marc
WBR, Sergei
next prev parent reply other threads:[~2013-08-08 19:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 7:16 [PATCH v2 0/2] Introduce new SATA queued commands Marc C
2013-08-08 7:16 ` [PATCH v2 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED Marc C
2013-08-08 17:50 ` Sergei Shtylyov
2013-08-08 17:52 ` Sergei Shtylyov
2013-08-08 18:58 ` Marc C
2013-08-08 19:03 ` Sergei Shtylyov [this message]
2013-08-08 19:07 ` Sergei Shtylyov
2013-08-09 16:18 ` Tejun Heo
2013-08-08 7:16 ` [PATCH v2 2/2] libata: Add support for queued DSM TRIM Marc C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203EB9B.3050206@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-ide@vger.kernel.org \
--cc=marc.ceeeee@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.