From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, liuj97@gmail.com,
kosaki.motohiro@gmail.com
Subject: Re: [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
Date: Fri, 09 Aug 2013 09:58:11 +0900 [thread overview]
Message-ID: <52043EA3.3080704@samsung.com> (raw)
In-Reply-To: <3049413.HnxJdeugZK@amdc1032>
On 07/31/2013 08:48 PM, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, July 31, 2013 01:17:46 PM Bartlomiej Zolnierkiewicz wrote:
>> Hi,
>>
>> On Wednesday, July 31, 2013 05:50:02 PM Joonyoung Shim wrote:
>>> This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>> Could you please also include commit descriptions, i.e.
>> commit cea27eb2a202959783f81254c48c250ddd80e129 ("mm/memory-hotplug: fix
>> lowmem count overflow when offline pages")?
>>
>>> Fixed to adjust totalhigh_pages when hot-removing memory by commit
>>> 3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
>>> duplicated decreasing of totalhigh_pages.
>> Could you please describe it a bit more (because it is non-obvious) how
>> the commit cea27eb effectively does the same totalhigh_pages adjustment
>> that is present in the commit 3dcc057?
> Err, the other way around. How the commit 3dcc057 ("mm: correctly update
> zone->managed_pages") does what cea27eb ("mm/memory-hotplug: fix lowmem
> count overflow when offline pages") did.
>
OK, i updated to patch v2.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, liuj97@gmail.com,
kosaki.motohiro@gmail.com
Subject: Re: [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"
Date: Fri, 09 Aug 2013 09:58:11 +0900 [thread overview]
Message-ID: <52043EA3.3080704@samsung.com> (raw)
In-Reply-To: <3049413.HnxJdeugZK@amdc1032>
On 07/31/2013 08:48 PM, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, July 31, 2013 01:17:46 PM Bartlomiej Zolnierkiewicz wrote:
>> Hi,
>>
>> On Wednesday, July 31, 2013 05:50:02 PM Joonyoung Shim wrote:
>>> This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>> Could you please also include commit descriptions, i.e.
>> commit cea27eb2a202959783f81254c48c250ddd80e129 ("mm/memory-hotplug: fix
>> lowmem count overflow when offline pages")?
>>
>>> Fixed to adjust totalhigh_pages when hot-removing memory by commit
>>> 3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
>>> duplicated decreasing of totalhigh_pages.
>> Could you please describe it a bit more (because it is non-obvious) how
>> the commit cea27eb effectively does the same totalhigh_pages adjustment
>> that is present in the commit 3dcc057?
> Err, the other way around. How the commit 3dcc057 ("mm: correctly update
> zone->managed_pages") does what cea27eb ("mm/memory-hotplug: fix lowmem
> count overflow when offline pages") did.
>
OK, i updated to patch v2.
Thanks.
next prev parent reply other threads:[~2013-08-09 0:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 8:50 [PATCH] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages" Joonyoung Shim
2013-07-31 8:50 ` Joonyoung Shim
2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
2013-07-31 11:17 ` Bartlomiej Zolnierkiewicz
2013-07-31 11:48 ` Bartlomiej Zolnierkiewicz
2013-07-31 11:48 ` Bartlomiej Zolnierkiewicz
2013-08-09 0:58 ` Joonyoung Shim [this message]
2013-08-09 0:58 ` Joonyoung Shim
2013-08-04 7:49 ` Wanpeng Li
2013-08-04 7:49 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52043EA3.3080704@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.