[Cocci] disjunction and parens

[Cocci] disjunction and parens

[ron minnich]

I've never been sure what to do about this error:

[rminnich at localhost akaros]$ spatch --sp-file !$ kern/src/chan.c
spatch --sp-file scripts/spatch/waserror.cocci kern/src/chan.c
init_defs_builtins: /usr/share/coccinelle/standard.h
Fatal error: exception Failure("normal parenthesis in line 5 matched
to disjunction parenthesis on line 7 column 0

Spatch is:

@@
type T;
identifier f;
@@
T F(...,
+struct errbuf *errbuf
){...}

What did I do wrong here?
_______________________________________________
Cocci mailing list
Cocci at diku.dk
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)

[Cocci] Re: disjunction and parens

[ron minnich]

Coccinnelle is always right, that's the rule.

Fixed spatch:

@@
type T;
identifier f;
@@
T f(...
+, struct errbuf *errbuf)
-)
{...}



On Wed, Aug 7, 2013 at 8:21 AM, ron minnich <rminnich@gmail.com> wrote:
> I've never been sure what to do about this error:
>
> [rminnich at localhost akaros]$ spatch --sp-file !$ kern/src/chan.c
> spatch --sp-file scripts/spatch/waserror.cocci kern/src/chan.c
> init_defs_builtins: /usr/share/coccinelle/standard.h
> Fatal error: exception Failure("normal parenthesis in line 5 matched
> to disjunction parenthesis on line 7 column 0
>
> Spatch is:
>
> @@
> type T;
> identifier f;
> @@
> T F(...,
> +struct errbuf *errbuf
> ){...}
>
> What did I do wrong here?
_______________________________________________
Cocci mailing list
Cocci at diku.dk
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)

[Cocci] disjunction and parens

[Michael Stefaniuc]

On 08/07/2013 05:21 PM, ron minnich wrote:
> I've never been sure what to do about this error:
> 
> [rminnich at localhost akaros]$ spatch --sp-file !$ kern/src/chan.c
> spatch --sp-file scripts/spatch/waserror.cocci kern/src/chan.c
> init_defs_builtins: /usr/share/coccinelle/standard.h
> Fatal error: exception Failure("normal parenthesis in line 5 matched
> to disjunction parenthesis on line 7 column 0
> 
> Spatch is:
> 
> @@
> type T;
> identifier f;
> @@
> T F(...,
> +struct errbuf *errbuf
> ){...}
> 
> What did I do wrong here?
) is special when it is on the first column in a line. If you add a
space before it, it will just work. It is a good practice to start code
matching lines with a space; like the context lines in the unified diff
format.

bye
	michael