From: Kumar Gaurav <kumargauravgupta3@gmail.com>
To: Kumar Gaurav <kumargauravgupta3@gmail.com>
Cc: davem@davemloft.net, jiri@resnulli.us,
gregkh@linuxfoundation.org, yongjun_wei@trendmicro.com.cn,
konszert@marvell.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED
Date: Fri, 09 Aug 2013 18:43:30 +0000 [thread overview]
Message-ID: <52053582.6050207@gmail.com> (raw)
In-Reply-To: <1376072759-11814-1-git-send-email-kumargauravgupta3@gmail.com>
It's a single patch. Please don't be confused with the subject [PATCH
17/17]. I forgot to edit this before sending.
my apology for mistake
On Friday 09 August 2013 11:55 PM, Kumar Gaurav wrote:
> Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
> of more than 80 chars on single line by sliting the line in two.
>
> Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
> ---
> drivers/net/ethernet/lantiq_etop.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> index bfdb0686..04c3a82 100644
> --- a/drivers/net/ethernet/lantiq_etop.c
> +++ b/drivers/net/ethernet/lantiq_etop.c
> @@ -282,7 +282,7 @@ ltq_etop_hw_init(struct net_device *dev)
>
> if (IS_TX(i)) {
> ltq_dma_alloc_tx(&ch->dma);
> - request_irq(irq, ltq_etop_dma_irq, IRQF_DISABLED,
> + request_irq(irq, ltq_etop_dma_irq, 0,
> "etop_tx", priv);
> } else if (IS_RX(i)) {
> ltq_dma_alloc_rx(&ch->dma);
> @@ -291,7 +291,7 @@ ltq_etop_hw_init(struct net_device *dev)
> if (ltq_etop_alloc_skb(ch))
> return -ENOMEM;
> ch->dma.desc = 0;
> - request_irq(irq, ltq_etop_dma_irq, IRQF_DISABLED,
> + request_irq(irq, ltq_etop_dma_irq, 0,
> "etop_rx", priv);
> }
> ch->dma.irq = irq;
> @@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
> if (err)
> goto err_netdev;
>
> - /* Set addr_assign_type here, ltq_etop_set_mac_address would reset it. */
> + /* Set addr_assign_type here,
> + *ltq_etop_set_mac_address would reset it.
> + */
> if (random_mac)
> dev->addr_assign_type = NET_ADDR_RANDOM;
>
WARNING: multiple messages have this Message-ID (diff)
From: Kumar Gaurav <kumargauravgupta3@gmail.com>
To: Kumar Gaurav <kumargauravgupta3@gmail.com>
Cc: davem@davemloft.net, jiri@resnulli.us,
gregkh@linuxfoundation.org, yongjun_wei@trendmicro.com.cn,
konszert@marvell.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED
Date: Sat, 10 Aug 2013 00:01:30 +0530 [thread overview]
Message-ID: <52053582.6050207@gmail.com> (raw)
In-Reply-To: <1376072759-11814-1-git-send-email-kumargauravgupta3@gmail.com>
It's a single patch. Please don't be confused with the subject [PATCH
17/17]. I forgot to edit this before sending.
my apology for mistake
On Friday 09 August 2013 11:55 PM, Kumar Gaurav wrote:
> Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
> of more than 80 chars on single line by sliting the line in two.
>
> Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
> ---
> drivers/net/ethernet/lantiq_etop.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> index bfdb0686..04c3a82 100644
> --- a/drivers/net/ethernet/lantiq_etop.c
> +++ b/drivers/net/ethernet/lantiq_etop.c
> @@ -282,7 +282,7 @@ ltq_etop_hw_init(struct net_device *dev)
>
> if (IS_TX(i)) {
> ltq_dma_alloc_tx(&ch->dma);
> - request_irq(irq, ltq_etop_dma_irq, IRQF_DISABLED,
> + request_irq(irq, ltq_etop_dma_irq, 0,
> "etop_tx", priv);
> } else if (IS_RX(i)) {
> ltq_dma_alloc_rx(&ch->dma);
> @@ -291,7 +291,7 @@ ltq_etop_hw_init(struct net_device *dev)
> if (ltq_etop_alloc_skb(ch))
> return -ENOMEM;
> ch->dma.desc = 0;
> - request_irq(irq, ltq_etop_dma_irq, IRQF_DISABLED,
> + request_irq(irq, ltq_etop_dma_irq, 0,
> "etop_rx", priv);
> }
> ch->dma.irq = irq;
> @@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
> if (err)
> goto err_netdev;
>
> - /* Set addr_assign_type here, ltq_etop_set_mac_address would reset it. */
> + /* Set addr_assign_type here,
> + *ltq_etop_set_mac_address would reset it.
> + */
> if (random_mac)
> dev->addr_assign_type = NET_ADDR_RANDOM;
>
next prev parent reply other threads:[~2013-08-09 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 18:25 [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED Kumar Gaurav
2013-08-09 18:37 ` Kumar Gaurav
2013-08-09 18:31 ` Kumar Gaurav [this message]
2013-08-09 18:43 ` Kumar Gaurav
2013-08-09 19:38 ` Sergei Shtylyov
2013-08-09 19:38 ` Sergei Shtylyov
2013-08-09 20:00 ` Kumar Gaurav
2013-08-09 20:12 ` Kumar Gaurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52053582.6050207@gmail.com \
--to=kumargauravgupta3@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=konszert@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.