From: walter harms <wharms@bfs.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arch/arm/mach-pxa/stargate2.c: use ARRAY_AND_SIZE consistently
Date: Sun, 11 Aug 2013 07:34:40 +0000 [thread overview]
Message-ID: <52073E90.2030008@bfs.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1308110745030.2072@localhost6.localdomain6>
Am 11.08.2013 07:48, schrieb Julia Lawall:
> On Sun, 11 Aug 2013, Dan Carpenter wrote:
>
>> ARRAY_AND_SIZE() macro is horrible, and I would like it if it were
>> removed. What I meant before was just that probably people will
>> probably complain if we try to remove it.
>
> Well, I could either wait for someone to defend it, or send a patch
> getting rid of it and see what happens... I can't see what could go wrong
> with
>
> f(...,
> - ARRAY_AND_SIZE(e)
> + e, ARRAY_SIZE(e)
> , ...)
>
> so it should be an easy patch to create.
>
if it is not to much work, send a patch to get rid of it.
It seems all agree that the disadvantages outweighs it
advantages.
just my 2 cents,
wh
WARNING: multiple messages have this Message-ID (diff)
From: wharms@bfs.de (walter harms)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arch/arm/mach-pxa/stargate2.c: use ARRAY_AND_SIZE consistently
Date: Sun, 11 Aug 2013 09:34:40 +0200 [thread overview]
Message-ID: <52073E90.2030008@bfs.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1308110745030.2072@localhost6.localdomain6>
Am 11.08.2013 07:48, schrieb Julia Lawall:
> On Sun, 11 Aug 2013, Dan Carpenter wrote:
>
>> ARRAY_AND_SIZE() macro is horrible, and I would like it if it were
>> removed. What I meant before was just that probably people will
>> probably complain if we try to remove it.
>
> Well, I could either wait for someone to defend it, or send a patch
> getting rid of it and see what happens... I can't see what could go wrong
> with
>
> f(...,
> - ARRAY_AND_SIZE(e)
> + e, ARRAY_SIZE(e)
> , ...)
>
> so it should be an easy patch to create.
>
if it is not to much work, send a patch to get rid of it.
It seems all agree that the disadvantages outweighs it
advantages.
just my 2 cents,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
kernel-janitors@vger.kernel.org,
Eric Miao <eric.y.miao@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/arm/mach-pxa/stargate2.c: use ARRAY_AND_SIZE consistently
Date: Sun, 11 Aug 2013 09:34:40 +0200 [thread overview]
Message-ID: <52073E90.2030008@bfs.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1308110745030.2072@localhost6.localdomain6>
Am 11.08.2013 07:48, schrieb Julia Lawall:
> On Sun, 11 Aug 2013, Dan Carpenter wrote:
>
>> ARRAY_AND_SIZE() macro is horrible, and I would like it if it were
>> removed. What I meant before was just that probably people will
>> probably complain if we try to remove it.
>
> Well, I could either wait for someone to defend it, or send a patch
> getting rid of it and see what happens... I can't see what could go wrong
> with
>
> f(...,
> - ARRAY_AND_SIZE(e)
> + e, ARRAY_SIZE(e)
> , ...)
>
> so it should be an easy patch to create.
>
if it is not to much work, send a patch to get rid of it.
It seems all agree that the disadvantages outweighs it
advantages.
just my 2 cents,
wh
next prev parent reply other threads:[~2013-08-11 7:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 15:25 [PATCH] arch/arm/mach-pxa/stargate2.c: use ARRAY_AND_SIZE consistently Julia Lawall
2013-08-10 15:25 ` Julia Lawall
2013-08-10 15:25 ` Julia Lawall
2013-08-10 15:32 ` Joe Perches
2013-08-10 15:32 ` Joe Perches
2013-08-10 15:32 ` Joe Perches
2013-08-10 15:38 ` Julia Lawall
2013-08-10 15:38 ` Julia Lawall
2013-08-10 15:38 ` Julia Lawall
2013-08-10 15:59 ` Joe Perches
2013-08-10 15:59 ` Joe Perches
2013-08-10 15:59 ` Joe Perches
2013-08-10 17:49 ` walter harms
2013-08-10 17:49 ` walter harms
2013-08-10 17:49 ` walter harms
2013-08-10 22:33 ` Dan Carpenter
2013-08-10 22:33 ` Dan Carpenter
2013-08-10 22:33 ` Dan Carpenter
2013-08-11 5:48 ` Julia Lawall
2013-08-11 5:48 ` Julia Lawall
2013-08-11 5:48 ` Julia Lawall
2013-08-11 7:34 ` walter harms [this message]
2013-08-11 7:34 ` walter harms
2013-08-11 7:34 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52073E90.2030008@bfs.de \
--to=wharms@bfs.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.