From: Heiko Stuebner <heiko@sntech.de>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Elaine Zhang <zhangqing@rock-chips.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
mturquette@baylibre.com, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
cl@rock-chips.com, xxx@rock-chips.com, xf@rock-chips.com,
huangtao@rock-chips.com
Subject: Re: [PATCH v3 3/4] clk: rockchip: add support for half divider
Date: Fri, 06 Jul 2018 19:19:11 +0200 [thread overview]
Message-ID: <5208192.saTfdjLqfi@phil> (raw)
In-Reply-To: <153089585197.143105.10633953093490493144@swboyd.mtv.corp.google.com>
Am Freitag, 6. Juli 2018, 18:50:51 CEST schrieb Stephen Boyd:
> Quoting Elaine Zhang (2018-06-14 19:16:50)
> >
> > diff --git a/drivers/clk/rockchip/clk-half-divider.c b/drivers/clk/rockchip/clk-half-divider.c
> > new file mode 100644
> > index 000000000000..fb7a6501e0c1
> > --- /dev/null
> > +++ b/drivers/clk/rockchip/clk-half-divider.c
> > @@ -0,0 +1,230 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2018 Fuzhou Rockchip Electronics Co., Ltd
> > + */
> > +
> > +#include <linux/slab.h>
> > +#include <linux/bitops.h>
> > +#include <linux/regmap.h>
> > +#include <linux/clk.h>
>
> Is this include used?
nope, and so are bitops and regmap as well.
I've amended the commit patch accordingly.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/4] clk: rockchip: add support for half divider
Date: Fri, 06 Jul 2018 19:19:11 +0200 [thread overview]
Message-ID: <5208192.saTfdjLqfi@phil> (raw)
In-Reply-To: <153089585197.143105.10633953093490493144@swboyd.mtv.corp.google.com>
Am Freitag, 6. Juli 2018, 18:50:51 CEST schrieb Stephen Boyd:
> Quoting Elaine Zhang (2018-06-14 19:16:50)
> >
> > diff --git a/drivers/clk/rockchip/clk-half-divider.c b/drivers/clk/rockchip/clk-half-divider.c
> > new file mode 100644
> > index 000000000000..fb7a6501e0c1
> > --- /dev/null
> > +++ b/drivers/clk/rockchip/clk-half-divider.c
> > @@ -0,0 +1,230 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2018 Fuzhou Rockchip Electronics Co., Ltd
> > + */
> > +
> > +#include <linux/slab.h>
> > +#include <linux/bitops.h>
> > +#include <linux/regmap.h>
> > +#include <linux/clk.h>
>
> Is this include used?
nope, and so are bitops and regmap as well.
I've amended the commit patch accordingly.
Heiko
next prev parent reply other threads:[~2018-07-06 17:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 2:16 [PATCH v3 0/4] clk: rockchip: support clock controller for px30 SoC Elaine Zhang
2018-06-15 2:16 ` Elaine Zhang
2018-06-15 2:16 ` [PATCH v3 1/4] dt-bindings: add bindings for px30 clock controller Elaine Zhang
2018-06-15 2:16 ` Elaine Zhang
2018-06-20 18:14 ` Rob Herring
2018-06-20 18:14 ` Rob Herring
2018-06-15 2:16 ` [PATCH v3 2/4] clk: rockchip: add dt-binding header for px30 Elaine Zhang
2018-06-15 2:16 ` Elaine Zhang
2018-06-15 2:16 ` [PATCH v3 3/4] clk: rockchip: add support for half divider Elaine Zhang
2018-06-15 2:16 ` Elaine Zhang
2018-07-06 16:50 ` Stephen Boyd
2018-07-06 16:50 ` Stephen Boyd
2018-07-06 16:50 ` Stephen Boyd
2018-07-06 16:50 ` Stephen Boyd
2018-07-06 17:19 ` Heiko Stuebner [this message]
2018-07-06 17:19 ` Heiko Stuebner
2018-07-06 17:49 ` Stephen Boyd
2018-07-06 17:49 ` Stephen Boyd
2018-07-06 17:49 ` Stephen Boyd
2018-06-15 2:16 ` [PATCH v3 4/4] clk: rockchip: add clock controller for px30 Elaine Zhang
2018-06-15 2:16 ` Elaine Zhang
2018-07-04 10:08 ` [PATCH v3 0/4] clk: rockchip: support clock controller for px30 SoC Heiko Stuebner
2018-07-04 10:08 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5208192.saTfdjLqfi@phil \
--to=heiko@sntech.de \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=xf@rock-chips.com \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.