All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ying Xue <ying.xue@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: <dingtianhong@huawei.com>, <jon.maloy@ericsson.com>,
	<allan.stephens@windriver.com>,
	<tipc-discussion@lists.sourceforge.net>, <netdev@vger.kernel.org>,
	<wangweidong1@huawei.com>
Subject: Re: [PATCH v2] tipc: avoid possible deadlock while enable and disable bearer
Date: Mon, 12 Aug 2013 13:03:46 +0800	[thread overview]
Message-ID: <52086CB2.3050006@windriver.com> (raw)
In-Reply-To: <20130811.215939.1897644088555839854.davem@davemloft.net>

On 08/12/2013 12:59 PM, David Miller wrote:
> From: Ying Xue <ying.xue@windriver.com>
> Date: Fri, 9 Aug 2013 17:34:05 +0800
> 
>>
>>> The problem is that the tipc_link_delete() will cancel the timer disc_timeout() when
>>> the b_ptr->lock is hold, but the disc_timeout() still call b_ptr->lock to finish the
>>> work, so the dead lock occurs.
>>>
>>> We should unlock the b_ptr->lock when del the disc_timeout().
>>>
>>> Remove link_timeout() still met the same problem, the patch:
>>>
>>> http://article.gmane.org/gmane.network.tipc.general/4380
>>>
>>> fix the problem, so no need to send patch for fix link_timeout() deadlock warming.
>>>
>>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
>>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>>> Cc: Ying Xue <ying.xue@windriver.com>
>>
>> Ack-by: Ying Xue <ying.xue@windriver.com>
> 
> The proper syntax is "Acked-by: " not "Ack-by: "
> 

Thanks, I knew :)

Regards,
Ying

> Applied.
> 
> 

      reply	other threads:[~2013-08-12  5:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  9:12 [PATCH v2] tipc: avoid possible deadlock while enable and disable bearer Ding Tianhong
2013-08-09  9:34 ` Ying Xue
2013-08-12  4:59   ` David Miller
2013-08-12  5:03     ` Ying Xue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52086CB2.3050006@windriver.com \
    --to=ying.xue@windriver.com \
    --cc=allan.stephens@windriver.com \
    --cc=davem@davemloft.net \
    --cc=dingtianhong@huawei.com \
    --cc=jon.maloy@ericsson.com \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=wangweidong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.