From: Chris Metcalf <cmetcalf@tilera.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] tilegx: Add tty serial support for TILE-Gx on-chip UART
Date: Mon, 12 Aug 2013 14:56:37 -0400 [thread overview]
Message-ID: <52092FE5.8030006@tilera.com> (raw)
In-Reply-To: <20130812184329.GB19875@kroah.com>
On 8/12/2013 2:43 PM, Greg Kroah-Hartman wrote:
> On Mon, Aug 12, 2013 at 02:11:44PM -0400, Chris Metcalf wrote:
>> +/*
>> + * Enable modem status interrupts.
>> + */
>> +static void tilegx_enable_ms(struct uart_port *port)
>> +{
>> + /* N/A */
>> +}
>> +
>> +/*
>> + * Control the transmission of a break signal.
>> + */
>> +static void tilegx_break_ctl(struct uart_port *port, int break_state)
>> +{
>> + /* N/A */
>> +}
> For most of these "empty" callbacks, you shouldn't have to declare them
> at all, and all should work just fine.
I may be missing something, but it looks like drivers/tty/serial/serial_core.c
calls all of the "empty" callbacks unconditionally, so some definition
is required.
> Other than that minor nit, at first glance this looks fine to me.
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks!
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
WARNING: multiple messages have this Message-ID (diff)
From: Chris Metcalf <cmetcalf@tilera.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] tilegx: Add tty serial support for TILE-Gx on-chip UART
Date: Mon, 12 Aug 2013 14:56:37 -0400 [thread overview]
Message-ID: <52092FE5.8030006@tilera.com> (raw)
In-Reply-To: <20130812184329.GB19875@kroah.com>
On 8/12/2013 2:43 PM, Greg Kroah-Hartman wrote:
> On Mon, Aug 12, 2013 at 02:11:44PM -0400, Chris Metcalf wrote:
>> +/*
>> + * Enable modem status interrupts.
>> + */
>> +static void tilegx_enable_ms(struct uart_port *port)
>> +{
>> + /* N/A */
>> +}
>> +
>> +/*
>> + * Control the transmission of a break signal.
>> + */
>> +static void tilegx_break_ctl(struct uart_port *port, int break_state)
>> +{
>> + /* N/A */
>> +}
> For most of these "empty" callbacks, you shouldn't have to declare them
> at all, and all should work just fine.
I may be missing something, but it looks like drivers/tty/serial/serial_core.c
calls all of the "empty" callbacks unconditionally, so some definition
is required.
> Other than that minor nit, at first glance this looks fine to me.
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks!
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2013-08-12 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 18:11 [PATCH] tilegx: Add tty serial support for TILE-Gx on-chip UART Chris Metcalf
2013-08-12 18:11 ` Chris Metcalf
2013-08-12 18:43 ` Greg Kroah-Hartman
2013-08-12 18:56 ` Chris Metcalf [this message]
2013-08-12 18:56 ` Chris Metcalf
2013-08-12 20:23 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52092FE5.8030006@tilera.com \
--to=cmetcalf@tilera.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.