From: b.brezillon@overkiz.com (boris brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework
Date: Mon, 12 Aug 2013 22:46:38 +0200 [thread overview]
Message-ID: <520949AE.6080207@overkiz.com> (raw)
In-Reply-To: <20130812180851.GF27954@radagast>
Hello Felipe
On 12/08/2013 20:08, Felipe Balbi wrote:
> On Mon, Aug 12, 2013 at 03:52:01PM +0200, Nicolas Ferre wrote:
>> On 01/08/2013 08:18, Boris BREZILLON :
>>> The AT91 PMC (Power Management Controller) provides an USB clock used by
>>> USB Full Speed host (ohci) and USB Full Speed device (udc).
>>> The usb drivers (ohci and udc) must configure this clock to 48Mhz.
>>> This configuration was formely done in mach-at91/clock.c, but this
>>> implementation will be removed when moving to common clk framework.
>>>
>>> This patch adds support for usb clock retrieval and configuration, and is
>>> backward compatible with the current at91 clk implementation (if usb clk
>>> is not found, it does not configure/enable it).
>>>
>>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> I don't have the original, where is it ? Was it not Cced to linux-usb ?
> Can someone resend with Nicolas' Acked-by in place ?
>
This mail was sent to linux-usb at vger.kernel.org and to you (balbi at ti.com).
It may have been filtered.
Anyway, you asked me to rework the 2nd version (which I did).
I think it's better to review the 3rd one
(https://lkml.org/lkml/2013/8/2/102).
Best Regards,
Boris
WARNING: multiple messages have this Message-ID (diff)
From: boris brezillon <b.brezillon@overkiz.com>
To: balbi@ti.com
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework
Date: Mon, 12 Aug 2013 22:46:38 +0200 [thread overview]
Message-ID: <520949AE.6080207@overkiz.com> (raw)
In-Reply-To: <20130812180851.GF27954@radagast>
Hello Felipe
On 12/08/2013 20:08, Felipe Balbi wrote:
> On Mon, Aug 12, 2013 at 03:52:01PM +0200, Nicolas Ferre wrote:
>> On 01/08/2013 08:18, Boris BREZILLON :
>>> The AT91 PMC (Power Management Controller) provides an USB clock used by
>>> USB Full Speed host (ohci) and USB Full Speed device (udc).
>>> The usb drivers (ohci and udc) must configure this clock to 48Mhz.
>>> This configuration was formely done in mach-at91/clock.c, but this
>>> implementation will be removed when moving to common clk framework.
>>>
>>> This patch adds support for usb clock retrieval and configuration, and is
>>> backward compatible with the current at91 clk implementation (if usb clk
>>> is not found, it does not configure/enable it).
>>>
>>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> I don't have the original, where is it ? Was it not Cced to linux-usb ?
> Can someone resend with Nicolas' Acked-by in place ?
>
This mail was sent to linux-usb@vger.kernel.org and to you (balbi@ti.com).
It may have been filtered.
Anyway, you asked me to rework the 2nd version (which I did).
I think it's better to review the 3rd one
(https://lkml.org/lkml/2013/8/2/102).
Best Regards,
Boris
next prev parent reply other threads:[~2013-08-12 20:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 6:18 [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework Boris BREZILLON
2013-08-01 6:18 ` Boris BREZILLON
2013-08-12 13:52 ` Nicolas Ferre
2013-08-12 13:52 ` Nicolas Ferre
2013-08-12 18:08 ` Felipe Balbi
2013-08-12 18:08 ` Felipe Balbi
2013-08-12 20:46 ` boris brezillon [this message]
2013-08-12 20:46 ` boris brezillon
2013-08-12 20:42 ` boris brezillon
2013-08-12 20:42 ` boris brezillon
2013-08-13 7:06 ` Nicolas Ferre
2013-08-13 7:06 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520949AE.6080207@overkiz.com \
--to=b.brezillon@overkiz.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.