From: Benoit Cousson <bcousson@baylibre.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Benoit Cousson <benoit.cousson@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Enric Balletbo <eballetbo@gmail.com>,
Ezequiel Garcia <elezegarcia@gmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Afzal Mohammed <afzal@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH 0/2] ARM: dts: AM33XX: node definition cleanups
Date: Tue, 13 Aug 2013 13:45:22 +0200 [thread overview]
Message-ID: <520A1C52.7070401@baylibre.com> (raw)
In-Reply-To: <1376154311-10184-1-git-send-email-javier.martinez@collabora.co.uk>
+ Few TI folks to review and test.
On 10/08/2013 19:05, Javier Martinez Canillas wrote:
> Hi,
>
> While reviewing the submission of a DT file for a new board
> based on the am3352 SoC, I noticed that am33xx*.dts files needed
> some cleanups. All am33xx based board files redefine device nodes
> that are already defined in the included am33xx.dtsi file.
>
> This not only makes the DTS harder to maintain without any benefit
> but also leaks SoC internal details to board files such as how the
> OCP interconnect is modeled (currently just a flat representation)
> and the addresses of some IP modules that are part of the SoC and
> are not going to change from board to board.
>
> This patch-set cleans these board files and is composed of the
> following patches:
>
> [PATCH 1/2] ARM: dts: AM33XX: use pinmux node defined in included
> [PATCH 2/2] ARM: dts: AM33XX: don't redefine OCP bus and device
>
> NOTE: I don't own any of these am33xx based boards so I was only
> able to build test the changes. However I compared the generated
> dtb before and after the changes and the disassembled DTS with
> dtc -I dtb -O dts foo.dtb > bar.dts are identical.
>
> Even though the binary dtb is the same and there shouldn't be
> any visible changes, boot testing will be highly appreciated.
Thanks it looks good to me.
Regards,
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: bcousson@baylibre.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] ARM: dts: AM33XX: node definition cleanups
Date: Tue, 13 Aug 2013 13:45:22 +0200 [thread overview]
Message-ID: <520A1C52.7070401@baylibre.com> (raw)
In-Reply-To: <1376154311-10184-1-git-send-email-javier.martinez@collabora.co.uk>
+ Few TI folks to review and test.
On 10/08/2013 19:05, Javier Martinez Canillas wrote:
> Hi,
>
> While reviewing the submission of a DT file for a new board
> based on the am3352 SoC, I noticed that am33xx*.dts files needed
> some cleanups. All am33xx based board files redefine device nodes
> that are already defined in the included am33xx.dtsi file.
>
> This not only makes the DTS harder to maintain without any benefit
> but also leaks SoC internal details to board files such as how the
> OCP interconnect is modeled (currently just a flat representation)
> and the addresses of some IP modules that are part of the SoC and
> are not going to change from board to board.
>
> This patch-set cleans these board files and is composed of the
> following patches:
>
> [PATCH 1/2] ARM: dts: AM33XX: use pinmux node defined in included
> [PATCH 2/2] ARM: dts: AM33XX: don't redefine OCP bus and device
>
> NOTE: I don't own any of these am33xx based boards so I was only
> able to build test the changes. However I compared the generated
> dtb before and after the changes and the disassembled DTS with
> dtc -I dtb -O dts foo.dtb > bar.dts are identical.
>
> Even though the binary dtb is the same and there shouldn't be
> any visible changes, boot testing will be highly appreciated.
Thanks it looks good to me.
Regards,
Benoit
next prev parent reply other threads:[~2013-08-13 11:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 17:05 [PATCH 0/2] ARM: dts: AM33XX: node definition cleanups Javier Martinez Canillas
2013-08-10 17:05 ` Javier Martinez Canillas
2013-08-10 17:05 ` [PATCH 1/2] ARM: dts: AM33XX: use pinmux node defined in included file Javier Martinez Canillas
2013-08-10 17:05 ` Javier Martinez Canillas
2013-08-10 17:05 ` [PATCH 2/2] ARM: dts: AM33XX: don't redefine OCP bus and device nodes Javier Martinez Canillas
2013-08-10 17:05 ` Javier Martinez Canillas
2013-08-13 11:45 ` Benoit Cousson [this message]
2013-08-13 11:45 ` [PATCH 0/2] ARM: dts: AM33XX: node definition cleanups Benoit Cousson
2013-08-14 10:21 ` Mohammed, Afzal
2013-08-14 10:21 ` Mohammed, Afzal
2013-08-16 9:25 ` Rajendra Nayak
2013-08-16 9:25 ` Rajendra Nayak
2013-08-16 10:47 ` Benoit Cousson
2013-08-16 10:47 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A1C52.7070401@baylibre.com \
--to=bcousson@baylibre.com \
--cc=afzal@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=eballetbo@gmail.com \
--cc=elezegarcia@gmail.com \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.