From: Gabor Juhos <juhosg@openwrt.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, John Crispin <blogic@openwrt.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] MIPS: add driver for the built-in PCI controller of the RT3883 SoC
Date: Wed, 14 Aug 2013 10:30:30 +0200 [thread overview]
Message-ID: <520B4026.6060908@openwrt.org> (raw)
In-Reply-To: <52090650.3000309@imgtec.com>
2013.08.12. 17:59 keltezéssel, James Hogan írta:
> On 09/08/13 17:03, Gabor Juhos wrote:
>> + - status: either "disabled" or "okay"
>
> Is this really a required property? If it's using the generic code for
> it then I think it will be treated as "okay" if omitted.
You are right, it is optional. The driver explicitly does not checks the
presence of the property. However instead of removing this part from the doc, I
would change the text to indicate that the property is optional.
> In any case I don't think this property is normally documented in these
> bindings docs (I couldn't find any other instances of it).
It is documented in mvebu-pci.txt as well, at least in 3.11-rc5.
-Gabor
WARNING: multiple messages have this Message-ID (diff)
From: Gabor Juhos <juhosg@openwrt.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, John Crispin <blogic@openwrt.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] MIPS: add driver for the built-in PCI controller of the RT3883 SoC
Date: Wed, 14 Aug 2013 10:30:30 +0200 [thread overview]
Message-ID: <520B4026.6060908@openwrt.org> (raw)
In-Reply-To: <52090650.3000309@imgtec.com>
2013.08.12. 17:59 keltez�ssel, James Hogan �rta:
> On 09/08/13 17:03, Gabor Juhos wrote:
>> + - status: either "disabled" or "okay"
>
> Is this really a required property? If it's using the generic code for
> it then I think it will be treated as "okay" if omitted.
You are right, it is optional. The driver explicitly does not checks the
presence of the property. However instead of removing this part from the doc, I
would change the text to indicate that the property is optional.
> In any case I don't think this property is normally documented in these
> bindings docs (I couldn't find any other instances of it).
It is documented in mvebu-pci.txt as well, at least in 3.11-rc5.
-Gabor
next prev parent reply other threads:[~2013-08-14 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 16:03 [PATCH] MIPS: add driver for the built-in PCI controller of the RT3883 SoC Gabor Juhos
2013-08-12 15:59 ` James Hogan
2013-08-12 15:59 ` James Hogan
2013-08-14 8:30 ` Gabor Juhos [this message]
2013-08-14 8:30 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520B4026.6060908@openwrt.org \
--to=juhosg@openwrt.org \
--cc=blogic@openwrt.org \
--cc=devicetree@vger.kernel.org \
--cc=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.