From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/4] arm, am33xx: add defines for gmii_sel_register bits
Date: Wed, 14 Aug 2013 09:51:35 -0400 [thread overview]
Message-ID: <520B8B67.6030801@ti.com> (raw)
In-Reply-To: <520B23CD.4000203@ti.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/14/2013 02:29 AM, Mugunthan V N wrote:
> On Monday 12 August 2013 11:06 PM, Mugunthan V N wrote:
>> On Monday 12 August 2013 07:52 PM, Tom Rini wrote:
>>>>>> +#define GMII2_SEL_MII 0x0
>>>>>>>>> +#define GMII2_SEL_RMII 0x4 +#define
>>>>>>>>> GMII2_SEL_RGMII 0x8 +#define GMII2_SEL_NOTUSED
>>>>>>>>> 0xc
>>>>>>> NOTUSED not needed as it is not supposed to be used.
>>>>> same here ...
>>> I think "Not Used" in the TRM here means "this port is not
>>> used" rather than "this combination of bits is not to be used",
>>> so the changes are correct.
>> But having this define is not useful as far as I can think of as
>> there is not abstraction API for this to check what user is
>> passing. But I leave it to Tom's decision to have this change or
>> not.
>>
>> Other than this the patch looks good to me. Acked-by: Mugunthan V
>> N <mugunthanvnm@ti.com>
>>
>>
> I had a discussion with the hardware team internally and the
> comment is *When these bits are set to 11b the RGMII is selected
> with internal delay mode which was not timing closed. Therefore
> this register setting is not supported so it should not be used.
> The respective pin multiplexing should be used to deselect any
> unused CPGMAC pins.*c The same will be updated in the TRM soon. So
> can you remove NOTUSED define and resubmit the patch again and can
> include my Acked-by in your next version patch.
Along with fixing the boards that set these bits to not set them
please, thanks!
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSC4tmAAoJENk4IS6UOR1Wn98P/ia2XzqBG//s8gxhKSn39QIb
K2m3U/X1qiAFlibWhCgje6j7C1wBE0vHEn/ef/XP9+sCKRUZJHjFlaPKH4UO8l4d
sMTPrz+n2OHpVPN/pQmc/tpA3D8KWHUo0OzIT3kvnonLyfUPT0qDEZ3qw1++1QmE
1LMqCQzubkrjJogN0TgzXYaKLG7IeGYev/XdaL8xRcpzsTz6DTlBDb62Inzidag2
yFY2Lb+/e0O7ji5iamevOdmniFEcXusQq2w98KavMxyeYG/TkKaMcWHegoayUmOC
BJVUAbMQlRMsqzad9+w9x/TTDZ+Hb5jg8mTC61PmurWwOj99AbLgYipkVcIAScft
TLO5bNHlDuj5Gk+4kU2R+5JAuPWLlKXTtmffsl6GLFcKHU0OsLGoPUGwVcn9SZax
1b0VG3ojFfk5hNRpQMaK6LUtQI6aPbr67GKP/1osJR0kZF2fTlRe9i/Sc1caJxhm
GoHT7S+DbPA7pLFQfetz4V2EsHwe6IQuErhkG45Pia2zTzhjz05PGfKeRBubuuUH
rjv6cwfamPfZ/OLzG0Ju61UHCVgVjbjUAkL84GYuAfsSttfxZYDVC37Rdyhx+MYm
xSf0czR+q4qJaRWfwndCLNtcTrCP6OLKKSDer9CZkWNWSQnqBuMyUxlsWUrAyGpv
daPZyMqV/kg5X47ToECn
=txIN
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-08-14 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:53 [U-Boot] [PATCH v3 0/4] arm, am335x: add support for siemens boards Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 1/4] arm, am33xx: add defines for gmii_sel_register bits Heiko Schocher
2013-07-30 8:40 ` Mugunthan V N
2013-07-31 6:20 ` Heiko Schocher
2013-08-12 14:22 ` Tom Rini
2013-08-12 17:36 ` Mugunthan V N
2013-08-14 6:29 ` Mugunthan V N
2013-08-14 13:51 ` Tom Rini [this message]
2013-07-30 7:53 ` [U-Boot] [PATCH v3 2/4] arm, spl: add watchdog library to SPL Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 3/4] arm, am335x: add watchdog support Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 4/4] arm, am335x: add support for 3 siemens boards Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520B8B67.6030801@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.