From: Eric Blake <eblake@redhat.com>
To: Taimoor Mirza <taimoor.mrza@gmail.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Taimoor Mirza <tmirza@codesourcery.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp: Port redirection option behave differently on Linux and Windows
Date: Wed, 14 Aug 2013 10:08:14 -0600 [thread overview]
Message-ID: <520BAB6E.4050806@redhat.com> (raw)
In-Reply-To: <CAO6-N=biX38qFJjH5OjUE=XXnB22k+igutDq+gzhhd=kP6XBLA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
On 08/14/2013 09:49 AM, Taimoor Mirza wrote:
> On Wed, Aug 14, 2013 at 2:20 AM, Eric Blake <eblake@redhat.com> wrote:
>> On 08/13/2013 03:05 PM, Taimoor wrote:
>>> From: Taimoor Mirza <tmirza@codesourcery.com>
>>>
>>> port redirection code uses SO_REUSEADDR socket option before binding to
>>> host port. Behavior of SO_REUSEADDR is different on Windows and Linux.
>>> Relaunching QEMU with same host and guest port redirection values on Linux
>>> throws error but on Windows it does not throw any error.
>>> Problem is discussed in http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03089.html
>>
>> When resending a patch, please use a v2 in the subject line (git
>> send-email --subject-prefix PATCHv2), send as a top-level thread, and
>> include a changelog after the --- divider that explains what changed
>> from v1. See http://wiki.qemu.org/Contribute/SubmitAPatch for more hints.
>
>
> Thanks Eric. Should I resend with changelog of v2 and v2 in subject line?
Yes, doing so will give it better visibility.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Taimoor Mirza <taimoor.mrza@gmail.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Taimoor Mirza <tmirza@codesourcery.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] slirp: Port redirection option behave differently on Linux and Windows
Date: Wed, 14 Aug 2013 10:08:14 -0600 [thread overview]
Message-ID: <520BAB6E.4050806@redhat.com> (raw)
In-Reply-To: <CAO6-N=biX38qFJjH5OjUE=XXnB22k+igutDq+gzhhd=kP6XBLA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
On 08/14/2013 09:49 AM, Taimoor Mirza wrote:
> On Wed, Aug 14, 2013 at 2:20 AM, Eric Blake <eblake@redhat.com> wrote:
>> On 08/13/2013 03:05 PM, Taimoor wrote:
>>> From: Taimoor Mirza <tmirza@codesourcery.com>
>>>
>>> port redirection code uses SO_REUSEADDR socket option before binding to
>>> host port. Behavior of SO_REUSEADDR is different on Windows and Linux.
>>> Relaunching QEMU with same host and guest port redirection values on Linux
>>> throws error but on Windows it does not throw any error.
>>> Problem is discussed in http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03089.html
>>
>> When resending a patch, please use a v2 in the subject line (git
>> send-email --subject-prefix PATCHv2), send as a top-level thread, and
>> include a changelog after the --- divider that explains what changed
>> from v1. See http://wiki.qemu.org/Contribute/SubmitAPatch for more hints.
>
>
> Thanks Eric. Should I resend with changelog of v2 and v2 in subject line?
Yes, doing so will give it better visibility.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-14 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 20:00 [Qemu-trivial] [PATCH] slirp: Port redirection option behave differently on Linux and Windows Taimoor
2013-08-13 20:00 ` [Qemu-devel] " Taimoor
2013-08-13 20:21 ` [Qemu-trivial] " Stefan Weil
2013-08-13 20:21 ` Stefan Weil
2013-08-13 21:02 ` [Qemu-trivial] " Taimoor Mirza
2013-08-13 21:02 ` Taimoor Mirza
2013-08-13 21:05 ` [Qemu-trivial] " Taimoor
2013-08-13 21:05 ` [Qemu-devel] " Taimoor
2013-08-13 21:20 ` [Qemu-trivial] " Eric Blake
2013-08-13 21:20 ` Eric Blake
2013-08-14 15:49 ` [Qemu-trivial] " Taimoor Mirza
2013-08-14 15:49 ` Taimoor Mirza
2013-08-14 16:08 ` Eric Blake [this message]
2013-08-14 16:08 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BAB6E.4050806@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=taimoor.mrza@gmail.com \
--cc=tmirza@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.