All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	eric.y.miao@gmail.com, arnd@arndb.de, s.neumann@raumfeld.com,
	haojian.zhuang@linaro.org, rmk+kernel@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] ASoC: pxa: pxa-ssp: add DT bindings
Date: Thu, 15 Aug 2013 12:51:31 +0200	[thread overview]
Message-ID: <520CB2B3.9050804@gmail.com> (raw)
In-Reply-To: <20130815103358.GY2401@sirena.org.uk>

On 15.08.2013 12:33, Mark Brown wrote:
> On Mon, Aug 12, 2013 at 10:42:38AM +0200, Daniel Mack wrote:
>> The pxa ssp DAI acts as a user of a pxa ssp port, and needs an
>> appropriate 'port' phandle in DT to reference the upstream.
> 
> I've applied this and the rest of the series though I'm not really that
> happy about having a binding for the DAI in the DT since there's at best
> tenouous hardware there.
> 

Hmm, and you don't like the approach either of having upstream ports and
assign users to it via phandles?

Also note that the last patch in that series ("ASoC: pxa: add DT
bindings for pxa2xx-pcm") can be omitted, as Lars pointed out. I'll have
to care for a proper solution at some point.


Daniel

WARNING: multiple messages have this Message-ID (diff)
From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ASoC: pxa: pxa-ssp: add DT bindings
Date: Thu, 15 Aug 2013 12:51:31 +0200	[thread overview]
Message-ID: <520CB2B3.9050804@gmail.com> (raw)
In-Reply-To: <20130815103358.GY2401@sirena.org.uk>

On 15.08.2013 12:33, Mark Brown wrote:
> On Mon, Aug 12, 2013 at 10:42:38AM +0200, Daniel Mack wrote:
>> The pxa ssp DAI acts as a user of a pxa ssp port, and needs an
>> appropriate 'port' phandle in DT to reference the upstream.
> 
> I've applied this and the rest of the series though I'm not really that
> happy about having a binding for the DAI in the DT since there's at best
> tenouous hardware there.
> 

Hmm, and you don't like the approach either of having upstream ports and
assign users to it via phandles?

Also note that the last patch in that series ("ASoC: pxa: add DT
bindings for pxa2xx-pcm") can be omitted, as Lars pointed out. I'll have
to care for a proper solution at some point.


Daniel

  reply	other threads:[~2013-08-15 10:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12  8:42 [PATCH 0/5] ASoC: pxa dmaengine preparation patches Daniel Mack
2013-08-12  8:42 ` Daniel Mack
2013-08-12  8:42 ` [PATCH 1/5] ALSA: move dmaengine implementation from ASoC to ALSA core Daniel Mack
2013-08-12  8:42   ` Daniel Mack
2013-08-12  8:55   ` Daniel Mack
2013-08-12  8:55     ` Daniel Mack
2013-08-15 10:18   ` Mark Brown
2013-08-15 10:18     ` Mark Brown
2013-08-12  8:42 ` [PATCH 2/5] ASoC: pxa: pxa-ssp: add DT bindings Daniel Mack
2013-08-12  8:42   ` Daniel Mack
2013-08-15 10:33   ` Mark Brown
2013-08-15 10:33     ` Mark Brown
2013-08-15 10:51     ` Daniel Mack [this message]
2013-08-15 10:51       ` Daniel Mack
2013-08-15 13:39       ` Mark Brown
2013-08-15 13:39         ` Mark Brown
2013-08-15 13:43         ` Daniel Mack
2013-08-15 13:43           ` Daniel Mack
2013-08-15 14:01           ` Mark Brown
2013-08-15 14:01             ` Mark Brown
2013-08-12  8:42 ` [PATCH 3/5] ASoC: pxa: use snd_dmaengine_dai_dma_data Daniel Mack
2013-08-12  8:42   ` Daniel Mack
2013-08-12  8:42 ` [PATCH 4/5] ASoC: pxa: pxa-ssp: set dma filter data from startup hook Daniel Mack
2013-08-12  8:42   ` Daniel Mack
2013-08-12  8:42 ` [PATCH 5/5] ASoC: pxa: add DT bindings for pxa2xx-pcm Daniel Mack
2013-08-12  8:42   ` Daniel Mack
2013-08-12  9:00   ` Lars-Peter Clausen
2013-08-12  9:00     ` [alsa-devel] " Lars-Peter Clausen
2013-08-12  9:17     ` Daniel Mack
2013-08-12  9:17       ` [alsa-devel] " Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520CB2B3.9050804@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=s.neumann@raumfeld.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.