All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Cousson <bcousson@baylibre.com>
To: Ruslan Bilovol <ruslan.bilovol@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	uri.y@variscite.com, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2 0/2] omap4/twl6030: typical connection to omap4 as a separate dtsi file
Date: Fri, 16 Aug 2013 15:20:38 +0200	[thread overview]
Message-ID: <520E2726.304@baylibre.com> (raw)
In-Reply-To: <CAB=otbTUk68CLmgQsEoefMMFTAnZCAMbZa-yiYmn1b3F1X8BiQ@mail.gmail.com>

Hi Ruslan,

On 16/08/2013 14:04, Ruslan Bilovol wrote:
> Hi Benoit,
> 
> On Wed, Aug 14, 2013 at 4:51 PM, Benoit Cousson <bcousson@baylibre.com> wrote:
>> Hi Ruslan,
>>
>> On 14/08/2013 10:35, Ruslan Bilovol wrote:
>>>
>>> Hello,
>>>
>>> There is no functional changes between v1 and v2 - just
>>> added the patch for omap4-var-som - Uri Yosef confirmed
>>> this board have the same connection of OMAP4<->TWL6030 as
>>> SDP4430 board
>>
>>
>> The series looks good to me, but it will be good to have a test for Panda
>> and Variscite boards before merging it.
> 
> Okay, so I just verified this patch series on PandaBoard ES2. Should I
> resubmit this series with
> fixed commit message?

No, that's fine, I already applied it and fixed the subject and the changelog.

Here it is:

commit 2e25df1e5a4af906a9b25332719ace000063eb0d
Author: Ruslan Bilovol <ruslan.bilovol@ti.com>
Date:   Wed Aug 14 11:35:47 2013 +0300

    ARM: dts: twl6030: Move common configuration for OMAP4 boards in a separate dtsi file
    
    The OMAP4 SoC family uses specially-designed PMIC (power management IC)
    companion chip for power management needs: TWL6030/TWL6032.
    Therefore there is a typical connection of PMIC to OMAP4 so we can
    move it into separate .dtsi file and do not duplicate over
    board-specific files.
    
    Tested on OMAP4 SDP board and compile-tested for Panda board
    
    Signed-off-by: Ruslan Bilovol <ruslan.bilovol@ti.com>
    Signed-off-by: Benoit Cousson <bcousson@baylibre.com>


Just let me know if you are OK with the updated version.

> However I cannot verify the patch for Variscite board because I do not
> own any such board so
> you can drop that patch. But maybe Uri Yosef can verify it. Uri?

It seems that Uri cannot test it right now, so I will have to drop that one.

Thanks,
Benoit

WARNING: multiple messages have this Message-ID (diff)
From: bcousson@baylibre.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] omap4/twl6030: typical connection to omap4 as a separate dtsi file
Date: Fri, 16 Aug 2013 15:20:38 +0200	[thread overview]
Message-ID: <520E2726.304@baylibre.com> (raw)
In-Reply-To: <CAB=otbTUk68CLmgQsEoefMMFTAnZCAMbZa-yiYmn1b3F1X8BiQ@mail.gmail.com>

Hi Ruslan,

On 16/08/2013 14:04, Ruslan Bilovol wrote:
> Hi Benoit,
> 
> On Wed, Aug 14, 2013 at 4:51 PM, Benoit Cousson <bcousson@baylibre.com> wrote:
>> Hi Ruslan,
>>
>> On 14/08/2013 10:35, Ruslan Bilovol wrote:
>>>
>>> Hello,
>>>
>>> There is no functional changes between v1 and v2 - just
>>> added the patch for omap4-var-som - Uri Yosef confirmed
>>> this board have the same connection of OMAP4<->TWL6030 as
>>> SDP4430 board
>>
>>
>> The series looks good to me, but it will be good to have a test for Panda
>> and Variscite boards before merging it.
> 
> Okay, so I just verified this patch series on PandaBoard ES2. Should I
> resubmit this series with
> fixed commit message?

No, that's fine, I already applied it and fixed the subject and the changelog.

Here it is:

commit 2e25df1e5a4af906a9b25332719ace000063eb0d
Author: Ruslan Bilovol <ruslan.bilovol@ti.com>
Date:   Wed Aug 14 11:35:47 2013 +0300

    ARM: dts: twl6030: Move common configuration for OMAP4 boards in a separate dtsi file
    
    The OMAP4 SoC family uses specially-designed PMIC (power management IC)
    companion chip for power management needs: TWL6030/TWL6032.
    Therefore there is a typical connection of PMIC to OMAP4 so we can
    move it into separate .dtsi file and do not duplicate over
    board-specific files.
    
    Tested on OMAP4 SDP board and compile-tested for Panda board
    
    Signed-off-by: Ruslan Bilovol <ruslan.bilovol@ti.com>
    Signed-off-by: Benoit Cousson <bcousson@baylibre.com>


Just let me know if you are OK with the updated version.

> However I cannot verify the patch for Variscite board because I do not
> own any such board so
> you can drop that patch. But maybe Uri Yosef can verify it. Uri?

It seems that Uri cannot test it right now, so I will have to drop that one.

Thanks,
Benoit

  parent reply	other threads:[~2013-08-16 13:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14  8:35 [PATCH v2 0/2] omap4/twl6030: typical connection to omap4 as a separate dtsi file Ruslan Bilovol
2013-08-14  8:35 ` Ruslan Bilovol
2013-08-14  8:35 ` [PATCH v2 1/2] arm: dts: twl6030: " Ruslan Bilovol
2013-08-14  8:35   ` Ruslan Bilovol
2013-08-14  8:35 ` [PATCH v2 2/2] arm: dts: omap4: configure connection to PMIC on Variscite's SOM Ruslan Bilovol
2013-08-14  8:35   ` Ruslan Bilovol
2013-08-14 13:51 ` [PATCH v2 0/2] omap4/twl6030: typical connection to omap4 as a separate dtsi file Benoit Cousson
2013-08-14 13:51   ` Benoit Cousson
2013-08-16 12:04   ` Ruslan Bilovol
2013-08-16 12:04     ` Ruslan Bilovol
     [not found]     ` <CAHooxd7Sg8B-MM38F2ce=vR5ftO6ye2byrXH1-iFous=_AvTLg@mail.gmail.com>
2013-08-16 13:17       ` Benoit Cousson
2013-08-16 13:17         ` Benoit Cousson
2013-08-16 13:20     ` Benoit Cousson [this message]
2013-08-16 13:20       ` Benoit Cousson
2013-08-19  6:14       ` Ruslan Bilovol
2013-08-19  6:14         ` Ruslan Bilovol
2013-08-19 10:04         ` Benoit Cousson
2013-08-19 10:04           ` Benoit Cousson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520E2726.304@baylibre.com \
    --to=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ruslan.bilovol@ti.com \
    --cc=uri.y@variscite.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.