From: Khalid Aziz <khalid.aziz@oracle.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>, akpm@linux-foundation.org
Cc: aarcange@redhat.com, hannes@cmpxchg.org, mgorman@suse.de,
riel@redhat.com, minchan@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] Fix aio performance regression for database caused by THP
Date: Fri, 16 Aug 2013 08:14:41 -0600 [thread overview]
Message-ID: <520E33D1.4040005@oracle.com> (raw)
In-Reply-To: <20130816090425.GA2162@shutemov.name>
On 08/16/2013 03:04 AM, Kirill A. Shutemov wrote:
> On Thu, Aug 15, 2013 at 12:13:09PM -0600, Khalid Aziz wrote:
>>
>> - if (likely(page != page_head && get_page_unless_zero(page_head))) {
>> + /*
>> + * If this is a hugetlbfs page, it can not be split under
>> + * us. Simply increment refcount for head page
>> + */
>> + if (PageHuge(page)) {
>> + page_head = compound_head(page);
>> + atomic_inc(&page_head->_count);
>> + got = true;
>
> Why not just return here and don't increase indentantion level for rest of
> the function?
>
Good point.
Andrew, I can rework the patch if you would like.
Thanks,
Khalid
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Khalid Aziz <khalid.aziz@oracle.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>, akpm@linux-foundation.org
Cc: aarcange@redhat.com, hannes@cmpxchg.org, mgorman@suse.de,
riel@redhat.com, minchan@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] Fix aio performance regression for database caused by THP
Date: Fri, 16 Aug 2013 08:14:41 -0600 [thread overview]
Message-ID: <520E33D1.4040005@oracle.com> (raw)
In-Reply-To: <20130816090425.GA2162@shutemov.name>
On 08/16/2013 03:04 AM, Kirill A. Shutemov wrote:
> On Thu, Aug 15, 2013 at 12:13:09PM -0600, Khalid Aziz wrote:
>>
>> - if (likely(page != page_head && get_page_unless_zero(page_head))) {
>> + /*
>> + * If this is a hugetlbfs page, it can not be split under
>> + * us. Simply increment refcount for head page
>> + */
>> + if (PageHuge(page)) {
>> + page_head = compound_head(page);
>> + atomic_inc(&page_head->_count);
>> + got = true;
>
> Why not just return here and don't increase indentantion level for rest of
> the function?
>
Good point.
Andrew, I can rework the patch if you would like.
Thanks,
Khalid
next prev parent reply other threads:[~2013-08-16 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 18:13 [RFC PATCH] Fix aio performance regression for database caused by THP Khalid Aziz
2013-08-15 18:13 ` Khalid Aziz
2013-08-15 19:34 ` Andi Kleen
2013-08-15 19:34 ` Andi Kleen
2013-08-15 20:15 ` Khalid Aziz
2013-08-15 20:15 ` Khalid Aziz
2013-08-15 21:16 ` Andrew Morton
2013-08-15 21:16 ` Andrew Morton
2013-08-15 23:22 ` Greg KH
2013-08-15 23:22 ` Greg KH
2013-08-16 9:04 ` Kirill A. Shutemov
2013-08-16 9:04 ` Kirill A. Shutemov
2013-08-16 14:14 ` Khalid Aziz [this message]
2013-08-16 14:14 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E33D1.4040005@oracle.com \
--to=khalid.aziz@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.