* [PATCH] ARM: SAMSUNG: Remove unnecessary exynos4_default_sdhci*()
@ 2013-07-15 0:21 Jingoo Han
2013-08-18 20:24 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-07-15 0:21 UTC (permalink / raw)
To: 'Kukjin Kim'; +Cc: linux-samsung-soc, Jingoo Han
Commit 17397a2("ARM: EXYNOS: Remove platform device initialization")
removes calling exynos4_default_sdhci*() functions; thus, these are
not necessary any more.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
arch/arm/plat-samsung/include/plat/sdhci.h | 38 ----------------------------
1 file changed, 38 deletions(-)
diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-samsung/include/plat/sdhci.h
index ce1d0f7..bf65021 100644
--- a/arch/arm/plat-samsung/include/plat/sdhci.h
+++ b/arch/arm/plat-samsung/include/plat/sdhci.h
@@ -260,44 +260,6 @@ static inline void s5pv210_default_sdhci3(void) { }
#endif /* CONFIG_S5PV210_SETUP_SDHCI */
-/* EXYNOS4 SDHCI setup */
-#ifdef CONFIG_EXYNOS4_SETUP_SDHCI
-static inline void exynos4_default_sdhci0(void)
-{
-#ifdef CONFIG_S3C_DEV_HSMMC
- s3c_hsmmc0_def_platdata.cfg_gpio = exynos4_setup_sdhci0_cfg_gpio;
-#endif
-}
-
-static inline void exynos4_default_sdhci1(void)
-{
-#ifdef CONFIG_S3C_DEV_HSMMC1
- s3c_hsmmc1_def_platdata.cfg_gpio = exynos4_setup_sdhci1_cfg_gpio;
-#endif
-}
-
-static inline void exynos4_default_sdhci2(void)
-{
-#ifdef CONFIG_S3C_DEV_HSMMC2
- s3c_hsmmc2_def_platdata.cfg_gpio = exynos4_setup_sdhci2_cfg_gpio;
-#endif
-}
-
-static inline void exynos4_default_sdhci3(void)
-{
-#ifdef CONFIG_S3C_DEV_HSMMC3
- s3c_hsmmc3_def_platdata.cfg_gpio = exynos4_setup_sdhci3_cfg_gpio;
-#endif
-}
-
-#else
-static inline void exynos4_default_sdhci0(void) { }
-static inline void exynos4_default_sdhci1(void) { }
-static inline void exynos4_default_sdhci2(void) { }
-static inline void exynos4_default_sdhci3(void) { }
-
-#endif /* CONFIG_EXYNOS4_SETUP_SDHCI */
-
static inline void s3c_sdhci_setname(int id, char *name)
{
switch (id) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: SAMSUNG: Remove unnecessary exynos4_default_sdhci*()
2013-07-15 0:21 [PATCH] ARM: SAMSUNG: Remove unnecessary exynos4_default_sdhci*() Jingoo Han
@ 2013-08-18 20:24 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2013-08-18 20:24 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Kukjin Kim', linux-samsung-soc
On 07/15/13 09:21, Jingoo Han wrote:
> Commit 17397a2("ARM: EXYNOS: Remove platform device initialization")
> removes calling exynos4_default_sdhci*() functions; thus, these are
> not necessary any more.
>
> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/sdhci.h | 38 ----------------------------
> 1 file changed, 38 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-samsung/include/plat/sdhci.h
> index ce1d0f7..bf65021 100644
> --- a/arch/arm/plat-samsung/include/plat/sdhci.h
> +++ b/arch/arm/plat-samsung/include/plat/sdhci.h
> @@ -260,44 +260,6 @@ static inline void s5pv210_default_sdhci3(void) { }
>
> #endif /* CONFIG_S5PV210_SETUP_SDHCI */
>
> -/* EXYNOS4 SDHCI setup */
> -#ifdef CONFIG_EXYNOS4_SETUP_SDHCI
> -static inline void exynos4_default_sdhci0(void)
> -{
> -#ifdef CONFIG_S3C_DEV_HSMMC
> - s3c_hsmmc0_def_platdata.cfg_gpio = exynos4_setup_sdhci0_cfg_gpio;
> -#endif
> -}
> -
> -static inline void exynos4_default_sdhci1(void)
> -{
> -#ifdef CONFIG_S3C_DEV_HSMMC1
> - s3c_hsmmc1_def_platdata.cfg_gpio = exynos4_setup_sdhci1_cfg_gpio;
> -#endif
> -}
> -
> -static inline void exynos4_default_sdhci2(void)
> -{
> -#ifdef CONFIG_S3C_DEV_HSMMC2
> - s3c_hsmmc2_def_platdata.cfg_gpio = exynos4_setup_sdhci2_cfg_gpio;
> -#endif
> -}
> -
> -static inline void exynos4_default_sdhci3(void)
> -{
> -#ifdef CONFIG_S3C_DEV_HSMMC3
> - s3c_hsmmc3_def_platdata.cfg_gpio = exynos4_setup_sdhci3_cfg_gpio;
> -#endif
> -}
> -
> -#else
> -static inline void exynos4_default_sdhci0(void) { }
> -static inline void exynos4_default_sdhci1(void) { }
> -static inline void exynos4_default_sdhci2(void) { }
> -static inline void exynos4_default_sdhci3(void) { }
> -
> -#endif /* CONFIG_EXYNOS4_SETUP_SDHCI */
> -
> static inline void s3c_sdhci_setname(int id, char *name)
> {
> switch (id) {
Looks good to me, applied.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-18 20:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-15 0:21 [PATCH] ARM: SAMSUNG: Remove unnecessary exynos4_default_sdhci*() Jingoo Han
2013-08-18 20:24 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.