From: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-pm@vger.kernel.org, daniel.lezcano@linaro.org, rjw@sisk.pl,
linux-kernel@vger.kernel.org, dongsheng.wang@freescale.com,
srivatsa.bhat@linux.vnet.ibm.com, preeti@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 5/6] cpuidle/powerpc: Backend-powerpc idle driver for powernv and pseries.
Date: Mon, 19 Aug 2013 10:13:31 +0530 [thread overview]
Message-ID: <5211A273.1080903@linux.vnet.ibm.com> (raw)
In-Reply-To: <1375832471.5600.41.camel@snotra.buserror.net>
On 08/07/2013 05:11 AM, Scott Wood wrote:
> On Wed, 2013-08-07 at 09:30 +1000, Benjamin Herrenschmidt wrote:
>> On Tue, 2013-08-06 at 18:08 -0500, Scott Wood wrote:
>>> Here's another example. get_lppaca() will only build on book3s -- and
>>> yet we get requests for e500 code to use this file.
>>
>> Indeed, Besides there is already accessors afaik for lppaca that compile
>> to nothing on E (and if not they would be trivial to add).
>
> I don't see such an accessor, but if there were, what would happen when
> the caller goes on to dereference that nothing?
>
> There is an accessor for shared_proc specifically (in the spinlock code)
> -- not that it would be much help on booke to just compile away that
> check and always select one of the pseries state tables over the other.
>
> -Scott
Thanks a lot Scott and Ben for the review.
I have addressed the issues in V3 of this patch series which I have just
posted out.
Regards,
Deepthi
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linux-pm@vger.kernel.org, daniel.lezcano@linaro.org,
dongsheng.wang@freescale.com, linux-kernel@vger.kernel.org,
rjw@sisk.pl, srivatsa.bhat@linux.vnet.ibm.com,
preeti@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 5/6] cpuidle/powerpc: Backend-powerpc idle driver for powernv and pseries.
Date: Mon, 19 Aug 2013 10:13:31 +0530 [thread overview]
Message-ID: <5211A273.1080903@linux.vnet.ibm.com> (raw)
In-Reply-To: <1375832471.5600.41.camel@snotra.buserror.net>
On 08/07/2013 05:11 AM, Scott Wood wrote:
> On Wed, 2013-08-07 at 09:30 +1000, Benjamin Herrenschmidt wrote:
>> On Tue, 2013-08-06 at 18:08 -0500, Scott Wood wrote:
>>> Here's another example. get_lppaca() will only build on book3s -- and
>>> yet we get requests for e500 code to use this file.
>>
>> Indeed, Besides there is already accessors afaik for lppaca that compile
>> to nothing on E (and if not they would be trivial to add).
>
> I don't see such an accessor, but if there were, what would happen when
> the caller goes on to dereference that nothing?
>
> There is an accessor for shared_proc specifically (in the spinlock code)
> -- not that it would be much help on booke to just compile away that
> check and always select one of the pseries state tables over the other.
>
> -Scott
Thanks a lot Scott and Ben for the review.
I have addressed the issues in V3 of this patch series which I have just
posted out.
Regards,
Deepthi
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
>
next prev parent reply other threads:[~2013-08-19 4:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 2:58 [PATCH V2 0/6] cpuidle/powerpc: POWERPC cpuidle driver for POWER and POWERNV platforms Deepthi Dharwar
2013-07-31 2:58 ` [PATCH V2 1/6] cpuidle/pseries: Fix kernel command line parameter smt-snooze-delay Deepthi Dharwar
2013-07-31 2:59 ` [PATCH V2 2/6] cpuidle/pseries: Remove dependency of pseries.h file Deepthi Dharwar
2013-07-31 2:59 ` [PATCH V2 3/6] pseries: Move plpar_wrapper.h to powerpc common include/asm location Deepthi Dharwar
2013-07-31 2:59 ` [PATCH V2 4/6] cpuidle/pseries: Move the pseries_idle backend driver to sysdev Deepthi Dharwar
2013-07-31 3:22 ` Wang Dongsheng-B40534
2013-07-31 3:22 ` Wang Dongsheng-B40534
2013-07-31 3:22 ` Wang Dongsheng-B40534
2013-07-31 3:59 ` Preeti U Murthy
2013-07-31 3:59 ` Preeti U Murthy
2013-07-31 5:46 ` Wang Dongsheng-B40534
2013-07-31 5:46 ` Wang Dongsheng-B40534
2013-07-31 5:46 ` Wang Dongsheng-B40534
2013-08-01 4:56 ` Preeti U Murthy
2013-08-01 4:56 ` Preeti U Murthy
2013-07-31 2:59 ` [PATCH V2 5/6] cpuidle/powerpc: Backend-powerpc idle driver for powernv and pseries Deepthi Dharwar
2013-07-31 4:01 ` Wang Dongsheng-B40534
2013-07-31 4:01 ` Wang Dongsheng-B40534
2013-07-31 4:01 ` Wang Dongsheng-B40534
2013-08-06 23:08 ` Scott Wood
2013-08-06 23:08 ` Scott Wood
2013-08-06 23:08 ` Scott Wood
2013-08-06 23:30 ` Benjamin Herrenschmidt
2013-08-06 23:30 ` Benjamin Herrenschmidt
2013-08-06 23:41 ` Scott Wood
2013-08-06 23:41 ` Scott Wood
2013-08-06 23:41 ` Scott Wood
2013-08-19 4:43 ` Deepthi Dharwar [this message]
2013-08-19 4:43 ` Deepthi Dharwar
2013-07-31 2:59 ` [PATCH V2 6/6] cpuidle/powernv: Enable idle powernv cpu to call into the cpuidle framework Deepthi Dharwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5211A273.1080903@linux.vnet.ibm.com \
--to=deepthi@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=daniel.lezcano@linaro.org \
--cc=dongsheng.wang@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@sisk.pl \
--cc=scottwood@freescale.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.