Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable

[Laszlo Ersek <lersek@redhat.com>]

On 08/19/13 14:31, Andreas Färber wrote:
> Am 19.08.2013 12:48, schrieb Miroslav Rezanina:
>> usb-bt-dongle device can't be disabled as there's dependency in vl.c file. This patch add preprocesor condition to be able to disable it.
> 
> Please limit to 76 chars per line (check `git log` output).
> 
>>
>> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
>> ---
>>  hw/usb/Makefile.objs |  1 -
>>  vl.c                 | 18 ++++++++++++++----
>>  2 files changed, 14 insertions(+), 5 deletions(-)
>>
>> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
>> index f9695e7..8892ffd 100644
>> --- a/hw/usb/Makefile.objs
>> +++ b/hw/usb/Makefile.objs
>> @@ -20,7 +20,6 @@ common-obj-$(CONFIG_USB_SERIAL)       += dev-serial.o
>>  common-obj-$(CONFIG_USB_NETWORK)      += dev-network.o
>>  
>>  # FIXME: make configurable too
>> -CONFIG_USB_BLUETOOTH := y
> 
> You probably should delete the FIXME alongside?

What's everyone's opinion about CONFIG_USB_BLUETOOTH=y disappearing from
the default build?

Thanks
Laszlo