All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v1, 5/8] fsl: do not define FSL_SRIO_PCIE_BOOT_MASTER for all P2041 systems
Date: Mon, 19 Aug 2013 17:26:55 +0200	[thread overview]
Message-ID: <5212393F.90302@keymile.com> (raw)
In-Reply-To: <520A97C3.4030806@freescale.com>

On 08/13/2013 10:32 PM, York Sun wrote:
> On 07/26/2013 03:02 AM, Valentin Longchamp wrote:
>> If this #define stays in config_mpc85xx.h, the P2041 based boards must
>> define a lot of SRIO values even if they do not implement a SRIO device.
>>
>> The #define is moved into the P2041RDB board config file where it is
>> used.
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
>>
>> ---
>> include/configs/P2041RDB.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/P2041RDB.h b/include/configs/P2041RDB.h
>> index 4ea8717..523117b 100644
>> --- a/include/configs/P2041RDB.h
>> +++ b/include/configs/P2041RDB.h
>> @@ -399,6 +399,7 @@ unsigned long get_board_sys_clk(unsigned long dummy);
>>   * for slave u-boot IMAGE instored in master memory space,
>>   * PHYS must be aligned based on the SIZE
>>   */
>> +#define CONFIG_SYS_FSL_SRIO_PCIE_BOOT_MASTER
>>  #define CONFIG_SRIO_PCIE_BOOT_IMAGE_MEM_PHYS 0xfef080000ull
>>  #define CONFIG_SRIO_PCIE_BOOT_IMAGE_MEM_BUS1 0xfff80000ull
>>  #define CONFIG_SRIO_PCIE_BOOT_IMAGE_SIZE 0x80000	/* 512K */
> 
> I failed to see what problem this patch fixes. Maybe you were using an
> older copy of u-boot?
> 

I developped all this with an earlier version of u-boot and I missed this one as
I rebased. You are right, this is not needed and fixes nothing.

Valentin

  reply	other threads:[~2013-08-19 15:26 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 10:02 [U-Boot] [PATCH v1 0/8] Support for the kmp204x reference design Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 1/8] km-powerpc: move SYS_MALLOC_LEN out of keymile-common.h Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 2/8] km-powerpc: move CONFIG_FLASH_CFI_MTD to km83xx-common.h Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 3/8] KM: fix typo in default environment Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 4/8] mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it Valentin Longchamp
2013-08-13 20:24   ` [U-Boot] [U-Boot, v1, " York Sun
2013-08-19 15:25     ` Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 5/8] fsl: do not define FSL_SRIO_PCIE_BOOT_MASTER for all P2041 systems Valentin Longchamp
2013-08-13 20:32   ` [U-Boot] [U-Boot, v1, " York Sun
2013-08-19 15:26     ` Valentin Longchamp [this message]
2013-07-26 10:02 ` [U-Boot] [PATCH v1 6/8] net/fman: add a fm_enable_port function Valentin Longchamp
2013-08-13 20:38   ` [U-Boot] [U-Boot, v1, " York Sun
2013-08-19 15:28     ` Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 7/8] mtd/fsl_elbc: take NAND_ECC_SOFT_BCH config option into accout Valentin Longchamp
2013-08-13 20:54   ` Scott Wood
2013-08-19 15:34     ` Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 8/8] mpc85xx: introduce the kmp204x reference design support Valentin Longchamp
2013-08-13 21:38   ` Scott Wood
2013-08-19 15:50     ` Valentin Longchamp
2013-08-20  0:48       ` Scott Wood
2013-08-20  1:02         ` York Sun
2013-08-20 18:20           ` Scott Wood
2013-08-20 18:21             ` Scott Wood
2013-08-20 19:40               ` York Sun
2013-08-20 19:47                 ` Scott Wood
2013-08-20 19:57                   ` York Sun
2013-08-20 20:03                     ` Scott Wood
2013-08-20 20:26                       ` York Sun
2013-08-20 23:24                         ` [U-Boot] [RFC PATCH 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100 Scott Wood
2013-08-20  6:28         ` [U-Boot] [PATCH v1 8/8] mpc85xx: introduce the kmp204x reference design support Valentin Longchamp
2013-08-20 18:18           ` Scott Wood
2013-08-21  6:36             ` Valentin Longchamp
2013-08-21 23:11               ` Scott Wood
2013-08-13 21:44   ` [U-Boot] [U-Boot, v1, " York Sun
2013-08-19 15:51     ` Valentin Longchamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5212393F.90302@keymile.com \
    --to=valentin.longchamp@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.