All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: add overcommit_kbytes sysctl variable
Date: Mon, 19 Aug 2013 09:55:03 -0700	[thread overview]
Message-ID: <52124DE7.8070502@intel.com> (raw)
In-Reply-To: <1376925478-15506-2-git-send-email-jmarchan@redhat.com>

On 08/19/2013 08:17 AM, Jerome Marchand wrote:
> Some applications that run on HPC clusters are designed around the
> availability of RAM and the overcommit ratio is fine tuned to get the
> maximum usage of memory without swapping. With growing memory, the
> 1%-of-all-RAM grain provided by overcommit_ratio has become too coarse
> for these workload (on a 2TB machine it represents no less than
> 20GB).
> 
> This patch adds the new overcommit_kbytes sysctl variable that allow a
> much finer grain.

Instead of introducing yet another tunable, why don't we just make the
ratio that comes in from the user more fine-grained?

	sysctl overcommit_ratio=0.2

We change the internal 'sysctl_overcommit_ratio' to store tenths or
hundreths of a percent (or whatever), then parse the input as two
integers.  I don't think we need fully correct floating point parsing
and rounding here, so it shouldn't be too much of a chore.  It'd
probably end up being less code than you have as it stands.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: add overcommit_kbytes sysctl variable
Date: Mon, 19 Aug 2013 09:55:03 -0700	[thread overview]
Message-ID: <52124DE7.8070502@intel.com> (raw)
In-Reply-To: <1376925478-15506-2-git-send-email-jmarchan@redhat.com>

On 08/19/2013 08:17 AM, Jerome Marchand wrote:
> Some applications that run on HPC clusters are designed around the
> availability of RAM and the overcommit ratio is fine tuned to get the
> maximum usage of memory without swapping. With growing memory, the
> 1%-of-all-RAM grain provided by overcommit_ratio has become too coarse
> for these workload (on a 2TB machine it represents no less than
> 20GB).
> 
> This patch adds the new overcommit_kbytes sysctl variable that allow a
> much finer grain.

Instead of introducing yet another tunable, why don't we just make the
ratio that comes in from the user more fine-grained?

	sysctl overcommit_ratio=0.2

We change the internal 'sysctl_overcommit_ratio' to store tenths or
hundreths of a percent (or whatever), then parse the input as two
integers.  I don't think we need fully correct floating point parsing
and rounding here, so it shouldn't be too much of a chore.  It'd
probably end up being less code than you have as it stands.

  reply	other threads:[~2013-08-19 16:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 15:17 [PATCH 1/2] mm: factor commit limit calculation Jerome Marchand
2013-08-19 15:17 ` Jerome Marchand
2013-08-19 15:17 ` [PATCH 2/2] mm: add overcommit_kbytes sysctl variable Jerome Marchand
2013-08-19 15:17   ` Jerome Marchand
2013-08-19 16:55   ` Dave Hansen [this message]
2013-08-19 16:55     ` Dave Hansen
2013-08-20  8:58     ` Jerome Marchand
2013-08-20  8:58       ` Jerome Marchand
2013-08-21 15:22     ` Jerome Marchand
2013-08-21 15:22       ` Jerome Marchand
2013-08-21 16:23       ` Dave Hansen
2013-08-21 16:23         ` Dave Hansen
2013-08-22  9:25         ` Jerome Marchand
2013-08-22  9:25           ` Jerome Marchand
2013-09-05 12:51   ` [PATCH 2/2 v2] mm: allow to set overcommit ratio more precisely Jerome Marchand
2013-09-05 12:51     ` Jerome Marchand
2013-09-05 14:41     ` Dave Hansen
2013-09-05 14:41       ` Dave Hansen
2013-09-05 14:47       ` Jerome Marchand
2013-09-05 14:47         ` Jerome Marchand
2013-09-05 22:11         ` Pavel Machek
2013-09-05 22:11           ` Pavel Machek
2013-09-06  8:38           ` Jerome Marchand
2013-09-06  8:38             ` Jerome Marchand
2013-09-06 14:11       ` [PATCH 2/2 v3] " Jerome Marchand
2013-09-06 14:11         ` Jerome Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52124DE7.8070502@intel.com \
    --to=dave.hansen@intel.com \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.