* [PATCH] iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers
@ 2013-08-18 13:07 Peter Meerwald
2013-08-19 15:15 ` Pandruvada, Srinivas
0 siblings, 1 reply; 3+ messages in thread
From: Peter Meerwald @ 2013-08-18 13:07 UTC (permalink / raw)
To: linux-iio; +Cc: Peter Meerwald, srinivas pandruvada
IIO_VAL_INT_PLUS_MICRO is the default, no need to return it explicitly
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: srinivas pandruvada <srinivas.pandruvada@intel.com>
---
drivers/iio/accel/hid-sensor-accel-3d.c | 8 --------
drivers/iio/gyro/hid-sensor-gyro-3d.c | 8 --------
drivers/iio/light/hid-sensor-als.c | 8 --------
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 8 --------
4 files changed, 32 deletions(-)
diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index 68df341..46d22f3 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -175,18 +175,10 @@ static int accel_3d_write_raw(struct iio_dev *indio_dev,
return ret;
}
-static int accel_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
-{
- return IIO_VAL_INT_PLUS_MICRO;
-}
-
static const struct iio_info accel_3d_info = {
.driver_module = THIS_MODULE,
.read_raw = &accel_3d_read_raw,
.write_raw = &accel_3d_write_raw,
- .write_raw_get_fmt = &accel_3d_write_raw_get_fmt,
};
/* Function to push data to buffer */
diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
index 9cc8aa1..be95179 100644
--- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
+++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
@@ -175,18 +175,10 @@ static int gyro_3d_write_raw(struct iio_dev *indio_dev,
return ret;
}
-static int gyro_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
-{
- return IIO_VAL_INT_PLUS_MICRO;
-}
-
static const struct iio_info gyro_3d_info = {
.driver_module = THIS_MODULE,
.read_raw = &gyro_3d_read_raw,
.write_raw = &gyro_3d_write_raw,
- .write_raw_get_fmt = &gyro_3d_write_raw_get_fmt,
};
/* Function to push data to buffer */
diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
index 84cf004..e59d00c 100644
--- a/drivers/iio/light/hid-sensor-als.c
+++ b/drivers/iio/light/hid-sensor-als.c
@@ -154,18 +154,10 @@ static int als_write_raw(struct iio_dev *indio_dev,
return ret;
}
-static int als_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
-{
- return IIO_VAL_INT_PLUS_MICRO;
-}
-
static const struct iio_info als_info = {
.driver_module = THIS_MODULE,
.read_raw = &als_read_raw,
.write_raw = &als_write_raw,
- .write_raw_get_fmt = &als_write_raw_get_fmt,
};
/* Function to push data to buffer */
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
index 5a6162d..a98460b 100644
--- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
+++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
@@ -176,18 +176,10 @@ static int magn_3d_write_raw(struct iio_dev *indio_dev,
return ret;
}
-static int magn_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
-{
- return IIO_VAL_INT_PLUS_MICRO;
-}
-
static const struct iio_info magn_3d_info = {
.driver_module = THIS_MODULE,
.read_raw = &magn_3d_read_raw,
.write_raw = &magn_3d_write_raw,
- .write_raw_get_fmt = &magn_3d_write_raw_get_fmt,
};
/* Function to push data to buffer */
--
1.8.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers
2013-08-18 13:07 [PATCH] iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers Peter Meerwald
@ 2013-08-19 15:15 ` Pandruvada, Srinivas
2013-08-19 19:02 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Pandruvada, Srinivas @ 2013-08-19 15:15 UTC (permalink / raw)
To: Peter Meerwald, linux-iio@vger.kernel.org
If IIO_VAL_INT_PLUS_MICRO is by default, then this patch is fine.
-----Original Message-----
From: Peter Meerwald [mailto:pmeerw@pmeerw.net]
Sent: Sunday, August 18, 2013 6:07 AM
To: linux-iio@vger.kernel.org
Cc: Peter Meerwald; Pandruvada, Srinivas
Subject: [PATCH] iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers
IIO_VAL_INT_PLUS_MICRO is the default, no need to return it explicitly
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: srinivas pandruvada <srinivas.pandruvada@intel.com>
---
drivers/iio/accel/hid-sensor-accel-3d.c | 8 --------
drivers/iio/gyro/hid-sensor-gyro-3d.c | 8 --------
drivers/iio/light/hid-sensor-als.c | 8 --------
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 8 --------
4 files changed, 32 deletions(-)
diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index 68df341..46d22f3 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -175,18 +175,10 @@ static int accel_3d_write_raw(struct iio_dev *indio_dev,
return ret;
}
-static int accel_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
-{
- return IIO_VAL_INT_PLUS_MICRO;
-}
-
static const struct iio_info accel_3d_info = {
.driver_module = THIS_MODULE,
.read_raw = &accel_3d_read_raw,
.write_raw = &accel_3d_write_raw,
- .write_raw_get_fmt = &accel_3d_write_raw_get_fmt,
};
/* Function to push data to buffer */
diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
index 9cc8aa1..be95179 100644
--- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
+++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
@@ -175,18 +175,10 @@ static int gyro_3d_write_raw(struct iio_dev *indio_dev,
return ret;
}
-static int gyro_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
-{
- return IIO_VAL_INT_PLUS_MICRO;
-}
-
static const struct iio_info gyro_3d_info = {
.driver_module = THIS_MODULE,
.read_raw = &gyro_3d_read_raw,
.write_raw = &gyro_3d_write_raw,
- .write_raw_get_fmt = &gyro_3d_write_raw_get_fmt,
};
/* Function to push data to buffer */
diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
index 84cf004..e59d00c 100644
--- a/drivers/iio/light/hid-sensor-als.c
+++ b/drivers/iio/light/hid-sensor-als.c
@@ -154,18 +154,10 @@ static int als_write_raw(struct iio_dev *indio_dev,
return ret;
}
-static int als_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
-{
- return IIO_VAL_INT_PLUS_MICRO;
-}
-
static const struct iio_info als_info = {
.driver_module = THIS_MODULE,
.read_raw = &als_read_raw,
.write_raw = &als_write_raw,
- .write_raw_get_fmt = &als_write_raw_get_fmt,
};
/* Function to push data to buffer */
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
index 5a6162d..a98460b 100644
--- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
+++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
@@ -176,18 +176,10 @@ static int magn_3d_write_raw(struct iio_dev *indio_dev,
return ret;
}
-static int magn_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
-{
- return IIO_VAL_INT_PLUS_MICRO;
-}
-
static const struct iio_info magn_3d_info = {
.driver_module = THIS_MODULE,
.read_raw = &magn_3d_read_raw,
.write_raw = &magn_3d_write_raw,
- .write_raw_get_fmt = &magn_3d_write_raw_get_fmt,
};
/* Function to push data to buffer */
--
1.8.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers
2013-08-19 15:15 ` Pandruvada, Srinivas
@ 2013-08-19 19:02 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2013-08-19 19:02 UTC (permalink / raw)
To: Pandruvada, Srinivas; +Cc: Peter Meerwald, linux-iio@vger.kernel.org
On 08/19/13 16:15, Pandruvada, Srinivas wrote:
> If IIO_VAL_INT_PLUS_MICRO is by default, then this patch is fine.
It is, so I'll take that as an Acked-by.
Applied to the togreg branch of iio.git
Thanks,
Jonathan
>
> -----Original Message-----
> From: Peter Meerwald [mailto:pmeerw@pmeerw.net]
> Sent: Sunday, August 18, 2013 6:07 AM
> To: linux-iio@vger.kernel.org
> Cc: Peter Meerwald; Pandruvada, Srinivas
> Subject: [PATCH] iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers
>
> IIO_VAL_INT_PLUS_MICRO is the default, no need to return it explicitly
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: srinivas pandruvada <srinivas.pandruvada@intel.com>
> ---
> drivers/iio/accel/hid-sensor-accel-3d.c | 8 --------
> drivers/iio/gyro/hid-sensor-gyro-3d.c | 8 --------
> drivers/iio/light/hid-sensor-als.c | 8 --------
> drivers/iio/magnetometer/hid-sensor-magn-3d.c | 8 --------
> 4 files changed, 32 deletions(-)
>
> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
> index 68df341..46d22f3 100644
> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
> @@ -175,18 +175,10 @@ static int accel_3d_write_raw(struct iio_dev *indio_dev,
> return ret;
> }
>
> -static int accel_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - long mask)
> -{
> - return IIO_VAL_INT_PLUS_MICRO;
> -}
> -
> static const struct iio_info accel_3d_info = {
> .driver_module = THIS_MODULE,
> .read_raw = &accel_3d_read_raw,
> .write_raw = &accel_3d_write_raw,
> - .write_raw_get_fmt = &accel_3d_write_raw_get_fmt,
> };
>
> /* Function to push data to buffer */
> diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> index 9cc8aa1..be95179 100644
> --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
> +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> @@ -175,18 +175,10 @@ static int gyro_3d_write_raw(struct iio_dev *indio_dev,
> return ret;
> }
>
> -static int gyro_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - long mask)
> -{
> - return IIO_VAL_INT_PLUS_MICRO;
> -}
> -
> static const struct iio_info gyro_3d_info = {
> .driver_module = THIS_MODULE,
> .read_raw = &gyro_3d_read_raw,
> .write_raw = &gyro_3d_write_raw,
> - .write_raw_get_fmt = &gyro_3d_write_raw_get_fmt,
> };
>
> /* Function to push data to buffer */
> diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
> index 84cf004..e59d00c 100644
> --- a/drivers/iio/light/hid-sensor-als.c
> +++ b/drivers/iio/light/hid-sensor-als.c
> @@ -154,18 +154,10 @@ static int als_write_raw(struct iio_dev *indio_dev,
> return ret;
> }
>
> -static int als_write_raw_get_fmt(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - long mask)
> -{
> - return IIO_VAL_INT_PLUS_MICRO;
> -}
> -
> static const struct iio_info als_info = {
> .driver_module = THIS_MODULE,
> .read_raw = &als_read_raw,
> .write_raw = &als_write_raw,
> - .write_raw_get_fmt = &als_write_raw_get_fmt,
> };
>
> /* Function to push data to buffer */
> diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
> index 5a6162d..a98460b 100644
> --- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
> +++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
> @@ -176,18 +176,10 @@ static int magn_3d_write_raw(struct iio_dev *indio_dev,
> return ret;
> }
>
> -static int magn_3d_write_raw_get_fmt(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - long mask)
> -{
> - return IIO_VAL_INT_PLUS_MICRO;
> -}
> -
> static const struct iio_info magn_3d_info = {
> .driver_module = THIS_MODULE,
> .read_raw = &magn_3d_read_raw,
> .write_raw = &magn_3d_write_raw,
> - .write_raw_get_fmt = &magn_3d_write_raw_get_fmt,
> };
>
> /* Function to push data to buffer */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-19 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-18 13:07 [PATCH] iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers Peter Meerwald
2013-08-19 15:15 ` Pandruvada, Srinivas
2013-08-19 19:02 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.