From: Sourav Poddar <sourav.poddar@ti.com>
To: balbi@ti.com
Cc: broonie@kernel.org, spi-devel-general@lists.sourceforge.net,
grant.likely@linaro.org, linux-omap@vger.kernel.org
Subject: Re: [PATCHv10] drivers: spi: Add qspi flash controller
Date: Tue, 20 Aug 2013 18:48:02 +0530 [thread overview]
Message-ID: <52136C8A.1020000@ti.com> (raw)
In-Reply-To: <20130820131429.GB26587@radagast>
On Tuesday 20 August 2013 06:44 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Aug 20, 2013 at 06:35:25PM +0530, Sourav Poddar wrote:
>> +static int qspi_transfer_msg(struct ti_qspi *qspi, struct spi_transfer *t)
>> +{
>> + int ret;
>> +
>> + if (t->tx_buf) {
>> + ret = qspi_write_msg(qspi, t);
>> + if (ret) {
>> + dev_dbg(qspi->dev, "Error while writing\n");
>> + return ret;
>> + }
>> + }
>> +
>> + if (t->rx_buf) {
>> + ret = qspi_read_msg(qspi, t);
>> + if (ret) {
>> + dev_dbg(qspi->dev, "Error while writing\n");
> *READING*
>
hmm..got missed while folding local changes:(.
Will submit an updated patch.
> other than that:
>
> Acked-by: Felipe Balbi<balbi@ti.com>
> Reviewed-by: Felipe Balbi<balbi@ti.com>
>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Sourav Poddar <sourav.poddar@ti.com>
To: <balbi@ti.com>
Cc: <broonie@kernel.org>, <spi-devel-general@lists.sourceforge.net>,
<grant.likely@linaro.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCHv10] drivers: spi: Add qspi flash controller
Date: Tue, 20 Aug 2013 18:48:02 +0530 [thread overview]
Message-ID: <52136C8A.1020000@ti.com> (raw)
In-Reply-To: <20130820131429.GB26587@radagast>
On Tuesday 20 August 2013 06:44 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Aug 20, 2013 at 06:35:25PM +0530, Sourav Poddar wrote:
>> +static int qspi_transfer_msg(struct ti_qspi *qspi, struct spi_transfer *t)
>> +{
>> + int ret;
>> +
>> + if (t->tx_buf) {
>> + ret = qspi_write_msg(qspi, t);
>> + if (ret) {
>> + dev_dbg(qspi->dev, "Error while writing\n");
>> + return ret;
>> + }
>> + }
>> +
>> + if (t->rx_buf) {
>> + ret = qspi_read_msg(qspi, t);
>> + if (ret) {
>> + dev_dbg(qspi->dev, "Error while writing\n");
> *READING*
>
hmm..got missed while folding local changes:(.
Will submit an updated patch.
> other than that:
>
> Acked-by: Felipe Balbi<balbi@ti.com>
> Reviewed-by: Felipe Balbi<balbi@ti.com>
>
Thanks!
next prev parent reply other threads:[~2013-08-20 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 13:05 [PATCHv10] drivers: spi: Add qspi flash controller Sourav Poddar
2013-08-20 13:05 ` Sourav Poddar
2013-08-20 13:14 ` Felipe Balbi
2013-08-20 13:14 ` Felipe Balbi
2013-08-20 13:18 ` Sourav Poddar [this message]
2013-08-20 13:18 ` Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52136C8A.1020000@ti.com \
--to=sourav.poddar@ti.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.