From: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
To: Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
george.cherian-l0cyMroinI0@public.gmane.org,
kishon-l0cyMroinI0@public.gmane.org,
bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()
Date: Wed, 21 Aug 2013 09:41:51 +0300 [thread overview]
Message-ID: <5214612F.4000500@ti.com> (raw)
In-Reply-To: <5213AE04.1070907-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
On 08/20/2013 08:57 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/20/2013 06:56 PM, Roger Quadros wrote:
>
>> omap_get_control_dev() is being deprecated as it doesn't support
>> multiple instances. As control device is present only from OMAP4
>> onwards which supports DT only, we use phandles to get the
>> reference to the control device.
>
>> Also get rid of "ti,has-mailbox" property as it is redundant and
>> we can determine that from whether "ctrl-module" property is present
>> or not. Get rid of has_mailbox from musb_hdrc_platform_data as well.
>
>> Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
> [...]
>
>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>> index ebb46ec..516795b 100644
>> --- a/drivers/usb/musb/omap2430.c
>> +++ b/drivers/usb/musb/omap2430.c
> [...]
>> @@ -509,8 +510,12 @@ static int omap2430_probe(struct platform_device *pdev)
>> glue->dev = &pdev->dev;
>> glue->musb = musb;
>> glue->status = OMAP_MUSB_UNKNOWN;
>> + glue->control_otghs = ERR_PTR(-ENODEV);
>
> Could you please align = with the others above?
OK.
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()
Date: Wed, 21 Aug 2013 09:41:51 +0300 [thread overview]
Message-ID: <5214612F.4000500@ti.com> (raw)
In-Reply-To: <5213AE04.1070907@cogentembedded.com>
On 08/20/2013 08:57 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/20/2013 06:56 PM, Roger Quadros wrote:
>
>> omap_get_control_dev() is being deprecated as it doesn't support
>> multiple instances. As control device is present only from OMAP4
>> onwards which supports DT only, we use phandles to get the
>> reference to the control device.
>
>> Also get rid of "ti,has-mailbox" property as it is redundant and
>> we can determine that from whether "ctrl-module" property is present
>> or not. Get rid of has_mailbox from musb_hdrc_platform_data as well.
>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> [...]
>
>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>> index ebb46ec..516795b 100644
>> --- a/drivers/usb/musb/omap2430.c
>> +++ b/drivers/usb/musb/omap2430.c
> [...]
>> @@ -509,8 +510,12 @@ static int omap2430_probe(struct platform_device *pdev)
>> glue->dev = &pdev->dev;
>> glue->musb = musb;
>> glue->status = OMAP_MUSB_UNKNOWN;
>> + glue->control_otghs = ERR_PTR(-ENODEV);
>
> Could you please align = with the others above?
OK.
cheers,
-roger
next prev parent reply other threads:[~2013-08-21 6:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 14:56 [PATCH v5 0/8] phy: omap-usb: Support multiple instances and new types Roger Quadros
2013-08-20 14:56 ` Roger Quadros
2013-08-20 14:56 ` [PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data Roger Quadros
2013-08-20 14:56 ` Roger Quadros
2013-08-20 15:04 ` thomas.langer
2013-08-20 15:04 ` thomas.langer at lantiq.com
2013-08-21 6:46 ` Roger Quadros
2013-08-21 6:46 ` Roger Quadros
[not found] ` <1377010577-19355-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-08-20 14:56 ` [PATCH v5 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power() Roger Quadros
2013-08-20 14:56 ` Roger Quadros
2013-08-20 14:56 ` [PATCH v5 3/8] usb: phy: omap-usb2: Don't use omap_get_control_dev() Roger Quadros
2013-08-20 14:56 ` Roger Quadros
2013-08-20 14:56 ` [PATCH v5 5/8] usb: musb: omap2430: " Roger Quadros
2013-08-20 14:56 ` Roger Quadros
[not found] ` <1377010577-19355-6-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-08-20 17:57 ` Sergei Shtylyov
2013-08-20 17:57 ` Sergei Shtylyov
[not found] ` <5213AE04.1070907-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-08-21 6:41 ` Roger Quadros [this message]
2013-08-21 6:41 ` Roger Quadros
2013-08-20 14:56 ` [PATCH v5 6/8] usb: phy: omap: get rid of omap_get_control_dev() Roger Quadros
2013-08-20 14:56 ` Roger Quadros
2013-08-20 14:56 ` [PATCH v5 7/8] ARM: dts: omap4: update omap-control-usb nodes Roger Quadros
2013-08-20 14:56 ` Roger Quadros
2013-08-20 14:56 ` [PATCH v5 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev() Roger Quadros
2013-08-20 14:56 ` Roger Quadros
2013-08-20 14:56 ` [PATCH v5 8/8] ARM: dts: omap5: update omap-control-usb node Roger Quadros
2013-08-20 14:56 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214612F.4000500@ti.com \
--to=rogerq-l0cymroini0@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=george.cherian-l0cyMroinI0@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.