All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] win32: build fixes due to io_flush removal
Date: Thu, 22 Aug 2013 16:33:19 +0200	[thread overview]
Message-ID: <5216212F.3060305@weilnetz.de> (raw)
In-Reply-To: <1377178116-28488-1-git-send-email-stefanha@redhat.com>

Am 22.08.2013 15:28, schrieb Stefan Hajnoczi:
> Stefan Weil noticed that the win32 build is broken with my io_flush changes
> applied.  The issues are simple build failures that should have been avoided by
> test building Windows, which I didn't.
>
> To make amends I've set up a mingw cross-compiler and have fixed the build.
> Sorry for the breakage.
>
> I can include this in my block pull request later today if you are happy with
> the patches.
>
> Stefan Hajnoczi (2):
>   aio-win32: replace incorrect AioHandler->opaque usage with ->e
>   win32-aio: drop win32_aio_flush_cb()
>
>  aio-win32.c       |  4 ++--
>  block/win32-aio.c | 10 +---------
>  2 files changed, 3 insertions(+), 11 deletions(-)
>

For both patches:

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Hi Stefan,

thank you for the fast fix. Please include it in your pull request.

Regards,
Stefan

  parent reply	other threads:[~2013-08-22 14:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 13:28 [Qemu-devel] [PATCH 0/2] win32: build fixes due to io_flush removal Stefan Hajnoczi
2013-08-22 13:28 ` [Qemu-devel] [PATCH 1/2] aio-win32: replace incorrect AioHandler->opaque usage with ->e Stefan Hajnoczi
2013-08-22 13:28 ` [Qemu-devel] [PATCH 2/2] win32-aio: drop win32_aio_flush_cb() Stefan Hajnoczi
2013-08-22 14:33 ` Stefan Weil [this message]
2013-08-22 20:05 ` [Qemu-devel] [PATCH 0/2] win32: build fixes due to io_flush removal Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5216212F.3060305@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.