All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabor Juhos <juhosg@openwrt.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	kernel-janitors@vger.kernel.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] MIPS: ath79: simplify platform_get_resource_byname/devm_ioremap_resource
Date: Thu, 22 Aug 2013 17:50:12 +0000	[thread overview]
Message-ID: <52164F54.2070209@openwrt.org> (raw)
In-Reply-To: <1376902316-18520-7-git-send-email-Julia.Lawall@lip6.fr>

2013.08.19. 10:51 keltezéssel, Julia Lawall írta:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Remove unneeded error handling on the result of a call to
> platform_get_resource_byname when the value is passed to devm_ioremap_resource.
> 
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression pdev,res,e,e1;
> expression ret != 0;
> identifier l;
> @@
> 
>   res = platform_get_resource_byname(...);
> - if (res = NULL) { ... \(goto l;\|return ret;\) }
>   e = devm_ioremap_resource(e1, res);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Gabor Juhos <juhosg@openwrt.org>

Thanks!

-Gabor
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Gabor Juhos <juhosg@openwrt.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	kernel-janitors@vger.kernel.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] MIPS: ath79: simplify platform_get_resource_byname/devm_ioremap_resource
Date: Thu, 22 Aug 2013 19:50:12 +0200	[thread overview]
Message-ID: <52164F54.2070209@openwrt.org> (raw)
In-Reply-To: <1376902316-18520-7-git-send-email-Julia.Lawall@lip6.fr>

2013.08.19. 10:51 keltezéssel, Julia Lawall írta:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Remove unneeded error handling on the result of a call to
> platform_get_resource_byname when the value is passed to devm_ioremap_resource.
> 
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression pdev,res,e,e1;
> expression ret != 0;
> identifier l;
> @@
> 
>   res = platform_get_resource_byname(...);
> - if (res == NULL) { ... \(goto l;\|return ret;\) }
>   e = devm_ioremap_resource(e1, res);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Gabor Juhos <juhosg@openwrt.org>

Thanks!

-Gabor

  reply	other threads:[~2013-08-22 17:50 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19  8:51 [PATCH 0/6] simplify platform_get_resource_byname/devm_ioremap_resource Julia Lawall
2013-08-19  8:51 ` Julia Lawall
2013-08-19  8:51 ` Julia Lawall
2013-08-19  8:51 ` Julia Lawall
2013-08-19  8:51 ` [PATCH 1/6] ASoC: omap: " Julia Lawall
2013-08-19  8:51   ` Julia Lawall
2013-08-19  8:51   ` Julia Lawall
2013-08-19 18:02   ` Jarkko Nikula
2013-08-19 18:02     ` Jarkko Nikula
2013-08-19 18:02     ` Jarkko Nikula
2013-08-20 10:51   ` Mark Brown
2013-08-20 10:51     ` Mark Brown
2013-08-19  8:51 ` [PATCH 2/6] watchdog: " Julia Lawall
2013-08-19  8:51   ` Julia Lawall
2013-08-19 13:06   ` Guenter Roeck
2013-08-19 13:06     ` Guenter Roeck
2013-08-19  8:51 ` [PATCH 3/6] mtd: fsmc_nand: " Julia Lawall
2013-08-19  8:51   ` Julia Lawall
2013-08-19  8:51   ` Julia Lawall
2013-08-19 13:38   ` Artem Bityutskiy
2013-08-19 13:38     ` Artem Bityutskiy
2013-08-19 13:38     ` Artem Bityutskiy
2013-08-19  8:51 ` [PATCH 4/6] usb: musb: dsps: " Julia Lawall
2013-08-19  8:51   ` Julia Lawall
2013-08-19 11:17   ` Svenning Sørensen
2013-08-19 11:17     ` Svenning Sørensen
2013-08-19 11:35     ` Julia Lawall
2013-08-19 11:35       ` Julia Lawall
2013-08-19 11:59       ` Svenning Sørensen
2013-08-19 11:59         ` Svenning Sørensen
2013-08-19 12:00         ` Julia Lawall
2013-08-19 12:00           ` Julia Lawall
2013-08-19 11:47     ` [PATCH 4/6 v2] " Julia Lawall
2013-08-19 11:47       ` Julia Lawall
2013-08-19 14:29       ` Sergei Shtylyov
2013-08-19 14:29         ` Sergei Shtylyov
2013-08-19 14:32         ` Julia Lawall
2013-08-19 14:32           ` Julia Lawall
2013-08-19 14:44         ` Dan Carpenter
2013-08-19 14:44           ` Dan Carpenter
2013-08-19  8:51 ` [PATCH 5/6] regulator: ti-abb: " Julia Lawall
2013-08-19  8:51   ` Julia Lawall
2013-08-19  9:10   ` walter harms
2013-08-19  9:10     ` walter harms
2013-08-19  9:12     ` Julia Lawall
2013-08-19  9:12       ` Julia Lawall
2013-08-19 10:12     ` Julia Lawall
2013-08-19 10:12       ` Julia Lawall
2013-08-19 10:17       ` walter harms
2013-08-19 10:17         ` walter harms
2013-08-19 10:23         ` Julia Lawall
2013-08-19 10:23           ` Julia Lawall
2013-08-19 10:16     ` Julia Lawall
2013-08-19 10:16       ` Julia Lawall
2013-08-22 10:15   ` Mark Brown
2013-08-22 10:15     ` Mark Brown
2013-08-19  8:51 ` [PATCH 6/6] MIPS: ath79: " Julia Lawall
2013-08-19  8:51   ` Julia Lawall
2013-08-22 17:50   ` Gabor Juhos [this message]
2013-08-22 17:50     ` Gabor Juhos
2013-08-31  8:09     ` John Crispin
2013-08-31  9:41       ` Gabor Juhos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52164F54.2070209@openwrt.org \
    --to=juhosg@openwrt.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.