From: Robert Yang <liezhi.yang@windriver.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/6] e2fsprogs: only update the icache for ext2_inode
Date: Fri, 23 Aug 2013 09:58:17 +0800 [thread overview]
Message-ID: <5216C1B9.6040205@windriver.com> (raw)
In-Reply-To: <1377192216.5259.6.camel@dvhart-mobl4.amr.corp.intel.com>
On 08/23/2013 01:23 AM, Darren Hart wrote:
> On Thu, 2013-08-22 at 09:13 -0400, Robert Yang wrote:
>> We only read the cache when:
>>
>> bufsize == sizeof(struct ext2_inode)
>>
>> then we should only update the cache in the same condition, otherwise
>> there would be errors, for example:
>>
>> cache[0]: cached ino 14 when bufsize = 128 by ext2fs_write_inode_full()
>> cache[1]: cached ino 14 when bufsize = 156 by ext2fs_read_inode_full()
>>
>> Then update the cache:
>> cache[0]: cached ino 15 when bufsize = 156 by ext2fs_read_inode_full()
>>
>> Then the ino 14 would hit the cache[1] when bufsize = 128 (but it was
>> cached by bufsize = 156), so there would be errors.
>
>> [YOCTO #3848]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>
>
>> +Upstream-Status: [Inappropriate]
>
> Hrm... why is this one inappropriate?
>
Hi Darren, the upstream has changed the icache lot, so this patch is
inappropriate for the upstream, we can drop this patch when we update
the package, I had put this in the patch head.
// Robert
next prev parent reply other threads:[~2013-08-23 1:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 13:13 [PATCH 0/6] replace genext2fs with populate-extfs.sh Robert Yang
2013-08-22 13:13 ` [PATCH 1/6] e2fsprogs: the max length of debugfs argument is too short Robert Yang
2013-08-22 14:48 ` Darren Hart
2013-08-22 13:13 ` [PATCH 2/6] e2fsprogs: let debugfs do sparse copy Robert Yang
2013-08-22 14:52 ` Darren Hart
2013-08-23 2:06 ` Robert Yang
2013-08-23 2:33 ` Rongqing Li
2013-08-23 6:45 ` Robert Yang
2013-08-23 17:06 ` Darren Hart
2013-08-26 1:39 ` Robert Yang
2013-08-22 13:13 ` [PATCH 3/6] e2fsprogs: only update the icache for ext2_inode Robert Yang
2013-08-22 17:23 ` Darren Hart
2013-08-23 1:58 ` Robert Yang [this message]
2013-08-23 17:03 ` Darren Hart
2013-08-22 13:13 ` [PATCH 4/6] e2fsprogs: properly set up extent header in do_write Robert Yang
2013-08-22 17:24 ` Darren Hart
2013-08-23 2:02 ` Robert Yang
2013-08-23 17:04 ` Darren Hart
2013-08-22 13:13 ` [PATCH 5/6] e2fsprogs: add populate-extfs.sh Robert Yang
2013-08-22 17:29 ` Darren Hart
2013-08-23 2:05 ` Robert Yang
2013-08-22 13:13 ` [PATCH 6/6] image_types.bbclass: replace genext2fs with populate-extfs.sh Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5216C1B9.6040205@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.