From: Robert Yang <liezhi.yang@windriver.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/6] e2fsprogs: properly set up extent header in do_write
Date: Fri, 23 Aug 2013 10:02:38 +0800 [thread overview]
Message-ID: <5216C2BE.2080705@windriver.com> (raw)
In-Reply-To: <1377192296.5259.7.camel@dvhart-mobl4.amr.corp.intel.com>
On 08/23/2013 01:24 AM, Darren Hart wrote:
> On Thu, 2013-08-22 at 09:13 -0400, Robert Yang wrote:
>> do_write doesn't fully set up the first extent header on a new
>> inode, so if we write a 0-length file, and don't write any data
>> to the new file, we end up creating something that looks corrupt
>> to kernelspace:
>>
>> EXT4-fs error (device loop0): ext4_ext_check_inode:464: inode #12: comm
>> ls: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
>> depth 0(0)
>>
>> Do something similar to ext4_ext_tree_init() here, and
>> fill out the first extent header upon creation to avoid this.
>>
>> [YOCTO #3848]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>> .../e2fsprogs-1.42.8/debugfs-extent-header.patch | 47 ++++++++++++++++++++
>> .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb | 2 +
>
>> +Upstream-Status: Backport
>
> Should we backport? Or should we just update the revision we use?
>
Yes, I think so, Ted said that he had merge this patch a few days ago, but
I didn't see where is it, I pulled this patch from the linux ext mailing
list.
// Robert
next prev parent reply other threads:[~2013-08-23 2:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 13:13 [PATCH 0/6] replace genext2fs with populate-extfs.sh Robert Yang
2013-08-22 13:13 ` [PATCH 1/6] e2fsprogs: the max length of debugfs argument is too short Robert Yang
2013-08-22 14:48 ` Darren Hart
2013-08-22 13:13 ` [PATCH 2/6] e2fsprogs: let debugfs do sparse copy Robert Yang
2013-08-22 14:52 ` Darren Hart
2013-08-23 2:06 ` Robert Yang
2013-08-23 2:33 ` Rongqing Li
2013-08-23 6:45 ` Robert Yang
2013-08-23 17:06 ` Darren Hart
2013-08-26 1:39 ` Robert Yang
2013-08-22 13:13 ` [PATCH 3/6] e2fsprogs: only update the icache for ext2_inode Robert Yang
2013-08-22 17:23 ` Darren Hart
2013-08-23 1:58 ` Robert Yang
2013-08-23 17:03 ` Darren Hart
2013-08-22 13:13 ` [PATCH 4/6] e2fsprogs: properly set up extent header in do_write Robert Yang
2013-08-22 17:24 ` Darren Hart
2013-08-23 2:02 ` Robert Yang [this message]
2013-08-23 17:04 ` Darren Hart
2013-08-22 13:13 ` [PATCH 5/6] e2fsprogs: add populate-extfs.sh Robert Yang
2013-08-22 17:29 ` Darren Hart
2013-08-23 2:05 ` Robert Yang
2013-08-22 13:13 ` [PATCH 6/6] image_types.bbclass: replace genext2fs with populate-extfs.sh Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5216C2BE.2080705@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.