From: Josh Wu <josh.wu@atmel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: devicetree@vger.kernel.org, artem.bityutskiy@linux.intel.com,
jg1.han@samsung.com, rob.herring@calxeda.com,
yongjun_wei@trendmicro.com.cn, linux-mtd@lists.infradead.org,
grant.likely@linaro.org, plagnioj@jcrosoft.com,
dwmw2@infradead.org
Subject: Re: [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe()
Date: Fri, 23 Aug 2013 11:53:20 +0800 [thread overview]
Message-ID: <5216DCB0.7050909@atmel.com> (raw)
In-Reply-To: <CAPgLHd8an7_iEV1eTNGFmQ8B4CM=FGu0jrov_A=L9JRJ8AFKPA@mail.gmail.com>
On 8/23/2013 10:50 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thank you for catch this. And
Acked-by: Josh Wu <josh.wu@atmel.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 65b302c..093bcf8 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2047,6 +2047,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> dev_err(host->dev, "Cannot get HSMC irq!\n");
> + res = irq;
> goto err_nand_ioremap;
> }
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Josh Wu <josh.wu@atmel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: dwmw2@infradead.org, grant.likely@linaro.org,
rob.herring@calxeda.com, artem.bityutskiy@linux.intel.com,
plagnioj@jcrosoft.com, jg1.han@samsung.com,
yongjun_wei@trendmicro.com.cn, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe()
Date: Fri, 23 Aug 2013 11:53:20 +0800 [thread overview]
Message-ID: <5216DCB0.7050909@atmel.com> (raw)
In-Reply-To: <CAPgLHd8an7_iEV1eTNGFmQ8B4CM=FGu0jrov_A=L9JRJ8AFKPA@mail.gmail.com>
On 8/23/2013 10:50 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thank you for catch this. And
Acked-by: Josh Wu <josh.wu@atmel.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 65b302c..093bcf8 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2047,6 +2047,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> dev_err(host->dev, "Cannot get HSMC irq!\n");
> + res = irq;
> goto err_nand_ioremap;
> }
>
>
next prev parent reply other threads:[~2013-08-23 3:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 2:50 [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe() Wei Yongjun
2013-08-23 2:50 ` Wei Yongjun
2013-08-23 3:53 ` Josh Wu [this message]
2013-08-23 3:53 ` Josh Wu
2013-08-23 3:54 ` Josh Wu
2013-08-23 3:54 ` Josh Wu
2013-08-24 4:44 ` Brian Norris
2013-08-24 4:44 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5216DCB0.7050909@atmel.com \
--to=josh.wu@atmel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@linaro.org \
--cc=jg1.han@samsung.com \
--cc=linux-mtd@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.