Re: [PATCH v6 3/4] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

[Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

On 22/08/2013 18:22, Wolfram Sang wrote:
> 
>> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
>> @@ -5,6 +5,8 @@ Required properties :
>>  
>>   - reg             : Offset and length of the register set for the device
>>   - compatible      : Should be "marvell,mv64xxx-i2c" or "allwinner,sun4i-i2c"
>> +                     or for controller which support the I2C Transaction
>> +                     Generator "marvell,mv64xxx-i2c","marvell,mv7230-i2c"
> 
> Too complicated IMO:
> +			or "marvell,mv7230-i2c".
> 
> DT creators don't need to know about transaction generators. They just
> supply the compatible string and the driver knows the details.
> 
>> +For a controller which support the I2C Transaction Generator:
> 
> "For the Armada XP" - there might be later IP cores on later SoC with
> transaction generators and different errata. They will just get a new
> compatible and the driver know the details.

You're right, I remained to close to my first version when it was a flag
and not a compatible name.

I will follow all your suggestions. A new version is coming soon.

Thanks,

> 
>> +
>> +	i2c@11000 {
>> +		compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
>> +		reg = <0x11000 0x100>;
>> +		interrupts = <29>;
>> +		clock-frequency = <100000>;
>> +	};
>> -- 
>> 1.8.1.2
>>


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com