From: Sudeep.KarkadaNagesha@arm.com (Sudeep KarkadaNagesha)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/6] ARM/ARM64 architected timer updates
Date: Fri, 23 Aug 2013 10:57:47 +0100 [thread overview]
Message-ID: <5217321B.6060306@arm.com> (raw)
In-Reply-To: <20130823092610.GB20186@darko.cambridge.arm.com>
On 23/08/13 10:26, Catalin Marinas wrote:
> On Tue, Aug 20, 2013 at 06:14:52PM +0100, Sudeep KarkadaNagesha wrote:
>> On 13/08/13 18:29, Sudeep KarkadaNagesha wrote:
>>> From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
>>>
>>> This patch series adds support to configure the rate and enable the
>>> event stream for architected timer. The event streams can be used to
>>> impose a timeout on a WFE, to safeguard against any programming error
>>> in case an expected event is not generated or even to implement
>>> wfe-based timeouts for userspace locking implementations.
>>>
>>> Since the timer control register is reset to zero on warm boot, CPU
>>> PM notifier is added to re-initialize it.
>>>
>>> Changes v2->v3:
>>> 1. Moved ARM and ARM64 changes into separate patches
>>> 2. Added native hwcaps definations(ARM/ARM64) and compat-specific
>>> definitions(ARM64) to the users for the event stream feature.
>>
>> Can you review this version of the series ?
>
> I think the series is OK with the follow-up comments addressed. Could
> you please post a v4 to make sure I haven't missed anything?
>
> Another comment I have is whether we should make this feature
> configurable. The reason is mainly hardware validation: if some CPU
> implementation messes the event generation (and on ARMv8 it's a bit more
> complex as this is tied to the exclusive monitor) we risk not detecting
> it because of the event stream.
Yes that seems reasonable. I assume we can enable it by default and we
need to disable it for hardware validation. Let me know if think otherwise.
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v3 0/6] ARM/ARM64 architected timer updates
Date: Fri, 23 Aug 2013 10:57:47 +0100 [thread overview]
Message-ID: <5217321B.6060306@arm.com> (raw)
In-Reply-To: <20130823092610.GB20186@darko.cambridge.arm.com>
On 23/08/13 10:26, Catalin Marinas wrote:
> On Tue, Aug 20, 2013 at 06:14:52PM +0100, Sudeep KarkadaNagesha wrote:
>> On 13/08/13 18:29, Sudeep KarkadaNagesha wrote:
>>> From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
>>>
>>> This patch series adds support to configure the rate and enable the
>>> event stream for architected timer. The event streams can be used to
>>> impose a timeout on a WFE, to safeguard against any programming error
>>> in case an expected event is not generated or even to implement
>>> wfe-based timeouts for userspace locking implementations.
>>>
>>> Since the timer control register is reset to zero on warm boot, CPU
>>> PM notifier is added to re-initialize it.
>>>
>>> Changes v2->v3:
>>> 1. Moved ARM and ARM64 changes into separate patches
>>> 2. Added native hwcaps definations(ARM/ARM64) and compat-specific
>>> definitions(ARM64) to the users for the event stream feature.
>>
>> Can you review this version of the series ?
>
> I think the series is OK with the follow-up comments addressed. Could
> you please post a v4 to make sure I haven't missed anything?
>
> Another comment I have is whether we should make this feature
> configurable. The reason is mainly hardware validation: if some CPU
> implementation messes the event generation (and on ARMv8 it's a bit more
> complex as this is tied to the exclusive monitor) we risk not detecting
> it because of the event stream.
Yes that seems reasonable. I assume we can enable it by default and we
need to disable it for hardware validation. Let me know if think otherwise.
Regards,
Sudeep
next prev parent reply other threads:[~2013-08-23 9:57 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 17:06 [PATCH 0/4] ARM/ARM64 architected timer updates Sudeep KarkadaNagesha
2013-06-18 17:06 ` Sudeep KarkadaNagesha
2013-06-18 17:07 ` [PATCH 1/4] drivers: clocksource: configure event stream for ARM arch timer Sudeep KarkadaNagesha
2013-06-18 17:07 ` Sudeep KarkadaNagesha
2013-06-18 17:07 ` [PATCH 2/4] ARM: arch_timer: add macros for bits in control register Sudeep KarkadaNagesha
2013-06-18 17:07 ` Sudeep KarkadaNagesha
2013-06-18 17:07 ` [PATCH 3/4] ARM/ARM64: arch_timer: remove __cpuinit attribute for arch_counter_set_user_access Sudeep KarkadaNagesha
2013-06-18 17:07 ` Sudeep KarkadaNagesha
2013-06-18 17:58 ` Sudeep KarkadaNagesha
2013-06-18 17:58 ` Sudeep KarkadaNagesha
2013-06-18 17:07 ` [PATCH 4/4] drivers: clocksource: add CPU PM notifier for ARM architected timer Sudeep KarkadaNagesha
2013-06-18 17:07 ` Sudeep KarkadaNagesha
2013-07-02 16:09 ` Jon Medhurst (Tixy)
2013-07-02 16:09 ` Jon Medhurst (Tixy)
2013-07-02 17:24 ` Sudeep KarkadaNagesha
2013-07-02 17:24 ` Sudeep KarkadaNagesha
2013-07-22 11:21 ` [PATCH v2 0/3] ARM/ARM64 architected timer updates Sudeep KarkadaNagesha
2013-07-22 11:21 ` Sudeep KarkadaNagesha
2013-07-22 11:21 ` [PATCH v2 1/3] drivers: clocksource: configure event stream for ARM arch timer Sudeep KarkadaNagesha
2013-07-22 11:21 ` Sudeep KarkadaNagesha
2013-07-23 10:23 ` Catalin Marinas
2013-07-23 10:23 ` Catalin Marinas
2013-07-23 10:33 ` Will Deacon
2013-07-23 10:33 ` Will Deacon
2013-07-23 11:12 ` Catalin Marinas
2013-07-23 11:12 ` Catalin Marinas
2013-07-25 9:45 ` [PATCH v3 " Sudeep KarkadaNagesha
2013-07-25 9:45 ` Sudeep KarkadaNagesha
2013-08-12 13:32 ` Sudeep KarkadaNagesha
2013-08-12 13:32 ` Sudeep KarkadaNagesha
2013-07-22 11:21 ` [PATCH v2 2/3] ARM: arch_timer: add macros for bits in control register Sudeep KarkadaNagesha
2013-07-22 11:21 ` Sudeep KarkadaNagesha
2013-07-22 11:21 ` [PATCH v2 3/3] drivers: clocksource: add CPU PM notifier for ARM architected timer Sudeep KarkadaNagesha
2013-07-22 11:21 ` Sudeep KarkadaNagesha
2013-08-02 9:32 ` [PATCH v2 0/3] ARM/ARM64 architected timer updates Sudeep KarkadaNagesha
2013-08-02 9:32 ` Sudeep KarkadaNagesha
2013-08-02 9:48 ` Daniel Lezcano
2013-08-02 9:48 ` Daniel Lezcano
2013-08-02 9:55 ` Sudeep KarkadaNagesha
2013-08-02 9:55 ` Sudeep KarkadaNagesha
2013-08-02 12:12 ` Daniel Lezcano
2013-08-02 12:12 ` Daniel Lezcano
2013-08-05 16:25 ` Sudeep KarkadaNagesha
2013-08-05 16:25 ` Sudeep KarkadaNagesha
2013-08-06 8:09 ` Daniel Lezcano
2013-08-06 8:09 ` Daniel Lezcano
2013-08-06 9:01 ` Sudeep KarkadaNagesha
2013-08-06 9:01 ` Sudeep KarkadaNagesha
2013-08-12 13:16 ` Daniel Lezcano
2013-08-12 13:16 ` Daniel Lezcano
2013-08-13 17:29 ` [PATCH v3 0/6] " Sudeep KarkadaNagesha
2013-08-13 17:29 ` Sudeep KarkadaNagesha
2013-08-13 17:29 ` [PATCH v3 1/6] ARM/ARM64: arch_timer: add macros for bits in control register Sudeep KarkadaNagesha
2013-08-13 17:29 ` Sudeep KarkadaNagesha
2013-08-14 8:50 ` Daniel Lezcano
2013-08-14 8:50 ` Daniel Lezcano
2013-08-14 9:03 ` Marc Zyngier
2013-08-14 9:03 ` Marc Zyngier
2013-08-14 9:23 ` Daniel Lezcano
2013-08-14 9:23 ` Daniel Lezcano
2013-08-13 17:29 ` [PATCH v3 2/6] drivers: clocksource: configure event stream for ARM arch timer Sudeep KarkadaNagesha
2013-08-13 17:29 ` Sudeep KarkadaNagesha
2013-08-13 17:29 ` [PATCH v3 3/6] ARM: arch_timer: configure and enable event stream Sudeep KarkadaNagesha
2013-08-13 17:29 ` Sudeep KarkadaNagesha
2013-08-13 17:29 ` [PATCH v3 4/6] ARM64: " Sudeep KarkadaNagesha
2013-08-13 17:29 ` Sudeep KarkadaNagesha
2013-08-20 13:27 ` Will Deacon
2013-08-20 13:27 ` Will Deacon
2013-08-20 14:27 ` Sudeep KarkadaNagesha
2013-08-20 14:27 ` Sudeep KarkadaNagesha
2013-08-20 16:16 ` Will Deacon
2013-08-20 16:16 ` Will Deacon
2013-08-20 16:23 ` Sudeep KarkadaNagesha
2013-08-20 16:23 ` Sudeep KarkadaNagesha
2013-08-20 17:08 ` Sudeep KarkadaNagesha
2013-08-20 17:08 ` Sudeep KarkadaNagesha
2013-08-21 17:52 ` Will Deacon
2013-08-21 17:52 ` Will Deacon
2013-08-13 17:29 ` [PATCH v3 5/6] drivers: clocksource: enable hwcaps for event stream on ARM arch timer Sudeep KarkadaNagesha
2013-08-13 17:29 ` Sudeep KarkadaNagesha
2013-08-13 17:29 ` [PATCH v3 6/6] drivers: clocksource: add CPU PM notifier for ARM architected timer Sudeep KarkadaNagesha
2013-08-13 17:29 ` Sudeep KarkadaNagesha
2013-08-14 9:08 ` [PATCH v3 0/6] ARM/ARM64 architected timer updates Daniel Lezcano
2013-08-14 9:08 ` Daniel Lezcano
2013-08-14 9:17 ` Sudeep KarkadaNagesha
2013-08-14 9:17 ` Sudeep KarkadaNagesha
2013-08-14 10:51 ` Daniel Lezcano
2013-08-14 10:51 ` Daniel Lezcano
2013-08-14 11:03 ` Sudeep KarkadaNagesha
2013-08-14 11:03 ` Sudeep KarkadaNagesha
2013-08-14 15:00 ` Daniel Lezcano
2013-08-14 15:00 ` Daniel Lezcano
2013-08-20 17:14 ` Sudeep KarkadaNagesha
2013-08-20 17:14 ` Sudeep KarkadaNagesha
2013-08-23 9:26 ` Catalin Marinas
2013-08-23 9:26 ` Catalin Marinas
2013-08-23 9:57 ` Sudeep KarkadaNagesha [this message]
2013-08-23 9:57 ` Sudeep KarkadaNagesha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217321B.6060306@arm.com \
--to=sudeep.karkadanagesha@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.