From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: patches@linaro.org, qemu-devel@nongnu.org,
"Alexander Graf" <agraf@suse.de>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"KONRAD Frédéric" <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio: Remove unnecessary OBJECT casts
Date: Fri, 23 Aug 2013 16:19:27 +0200 [thread overview]
Message-ID: <52176F6F.9020307@suse.de> (raw)
In-Reply-To: <1377265136-8559-2-git-send-email-peter.maydell@linaro.org>
Am 23.08.2013 15:38, schrieb Peter Maydell:
> There's no need to cast the first argument of object_initialize
> to Object, and it would defeat the ability to check that the
> pointer being passed is to a type large enough for the object.
> Remove these unnecessary casts.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/s390x/s390-virtio-bus.c | 12 ++++++------
> hw/s390x/virtio-ccw.c | 14 +++++++-------
> hw/virtio/virtio-pci.c | 16 ++++++++--------
> 3 files changed, 21 insertions(+), 21 deletions(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Depending on how we proceed we may want to tweak the commit message.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-23 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 13:38 [Qemu-devel] [PATCH 0/2] object_initialize: check size of passed in memory Peter Maydell
2013-08-23 13:38 ` [Qemu-devel] [PATCH 1/2] virtio: Remove unnecessary OBJECT casts Peter Maydell
2013-08-23 14:19 ` Andreas Färber [this message]
2013-08-23 13:38 ` [Qemu-devel] [PATCH 2/2] qom: Make object_initialize and object_initialize_with_type check size Peter Maydell
2013-08-23 14:13 ` [Qemu-devel] [PATCH 0/2] object_initialize: check size of passed in memory Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52176F6F.9020307@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=cornelia.huck@de.ibm.com \
--cc=fred.konrad@greensocs.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.