From: Stephen Warren <swarren@wwwdotorg.org>
To: Nicolin Chen <b42378@freescale.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, lars@metafoo.de,
s.hauer@pengutronix.de, tomasz.figa@gmail.com,
rob.herring@calxeda.com, broonie@kernel.org,
p.zabel@pengutronix.de, shawn.guo@linaro.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v11] ASoC: fsl: Add S/PDIF machine driver
Date: Fri, 23 Aug 2013 13:08:28 -0600 [thread overview]
Message-ID: <5217B32C.5070300@wwwdotorg.org> (raw)
In-Reply-To: <fac39ed91818630e03f81a5f0cf9ddde0e6a3c3a.1377244995.git.b42378@freescale.com>
On 08/23/2013 02:04 AM, Nicolin Chen wrote:
> This patch implements a device-tree-only machine driver for Freescale
> i.MX series Soc. It works with spdif_transmitter/spdif_receiver and
> fsl_spdif.c drivers.
The binding looks reasonable to me now. Thanks.
> diff --git a/sound/soc/fsl/imx-spdif.c b/sound/soc/fsl/imx-spdif.c
> + if (of_property_read_bool(np, "spdif-out")) {
I'd be tempted to safe those property values into a variable so that ...
> + data->txdev = platform_device_register_simple("spdif-dit", -1, NULL, 0);
...
> + data->rxdev = platform_device_register_simple("spdif-dir", -1, NULL, 0);
... those two statements could be conditional upon whether TX/RX were
required too.
However, this isn't a big deal, and could be cleaned up later.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Nicolin Chen <b42378@freescale.com>
Cc: broonie@kernel.org, s.hauer@pengutronix.de,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, lars@metafoo.de,
p.zabel@pengutronix.de, rob.herring@calxeda.com,
shawn.guo@linaro.org, tomasz.figa@gmail.com,
mark.rutland@arm.com
Subject: Re: [PATCH v11] ASoC: fsl: Add S/PDIF machine driver
Date: Fri, 23 Aug 2013 13:08:28 -0600 [thread overview]
Message-ID: <5217B32C.5070300@wwwdotorg.org> (raw)
In-Reply-To: <fac39ed91818630e03f81a5f0cf9ddde0e6a3c3a.1377244995.git.b42378@freescale.com>
On 08/23/2013 02:04 AM, Nicolin Chen wrote:
> This patch implements a device-tree-only machine driver for Freescale
> i.MX series Soc. It works with spdif_transmitter/spdif_receiver and
> fsl_spdif.c drivers.
The binding looks reasonable to me now. Thanks.
> diff --git a/sound/soc/fsl/imx-spdif.c b/sound/soc/fsl/imx-spdif.c
> + if (of_property_read_bool(np, "spdif-out")) {
I'd be tempted to safe those property values into a variable so that ...
> + data->txdev = platform_device_register_simple("spdif-dit", -1, NULL, 0);
...
> + data->rxdev = platform_device_register_simple("spdif-dir", -1, NULL, 0);
... those two statements could be conditional upon whether TX/RX were
required too.
However, this isn't a big deal, and could be cleaned up later.
next prev parent reply other threads:[~2013-08-23 19:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 8:04 [PATCH v11] ASoC: fsl: Add S/PDIF machine driver Nicolin Chen
2013-08-23 8:04 ` Nicolin Chen
2013-08-23 8:04 ` Nicolin Chen
2013-08-23 19:08 ` Stephen Warren [this message]
2013-08-23 19:08 ` Stephen Warren
2013-08-23 19:13 ` Mark Brown
2013-08-23 19:13 ` [alsa-devel] " Mark Brown
2013-08-23 19:13 ` Mark Brown
2013-08-23 19:53 ` Stephen Warren
2013-08-23 19:53 ` [alsa-devel] " Stephen Warren
2013-08-23 19:53 ` Stephen Warren
2013-08-27 2:01 ` Nicolin Chen
2013-08-27 2:01 ` [alsa-devel] " Nicolin Chen
2013-08-27 14:50 ` Mark Brown
2013-08-27 14:50 ` [alsa-devel] " Mark Brown
2013-08-27 15:15 ` Chen Guangyu-B42378
2013-08-27 15:15 ` [alsa-devel] " Chen Guangyu-B42378
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217B32C.5070300@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.