From: Stephen Warren <swarren@wwwdotorg.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: bcousson@baylibre.com, tony@atomide.com,
myungjoo.ham@samsung.com, cw00.choi@samsung.com,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ian.campbell@citrix.com, rob@landley.net,
george.cherian@ti.com, gregkh@linuxfoundation.org,
linux-doc@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
balbi@ti.com
Subject: Re: [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*
Date: Fri, 23 Aug 2013 13:17:34 -0600 [thread overview]
Message-ID: <5217B54E.8070009@wwwdotorg.org> (raw)
In-Reply-To: <52174755.8030506@ti.com>
On 08/23/2013 05:28 AM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Friday 23 August 2013 02:20 AM, Stephen Warren wrote:
>> On 08/22/2013 02:31 AM, Kishon Vijay Abraham I wrote:
>>> The Palmas device contains only a USB VBUS-ID detector, so added a
>>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>>> types for backward compatibility.
>>
>>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
>>
>>> PALMAS USB COMPARATOR
>>> Required Properties:
>>> - - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
>>> + - compatible : Should be "ti,palmas-usb-vid". "ti,twl6035-usb" and
>>> + "ti,palmas-usb" is deprecated and is kept for backward compatibility.
>>
>> So this defines one new value and deprecates the two old values.
>
> yeah.
>>
>> Why isn't a new "ti,twl6035-usb-vid" entry useful? Don't you still need
>
> yeah, it should be added too.
>> SoC-specific compatible values so the driver can enable any SoC-specific
>> bug-fixes/workarounds later if needed?
>
> hmm.. Palmas is external to SoC. So not sure if adding SoC specific compatible
> values is such a good idea.
In this case, but SoC, I meant the Palmas chip rather than the
application processor. Is twl6035 a name for Palmas or something else?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] extcon: palmas: Added a new compatible type *ti, palmas-usb-vid*
Date: Fri, 23 Aug 2013 13:17:34 -0600 [thread overview]
Message-ID: <5217B54E.8070009@wwwdotorg.org> (raw)
In-Reply-To: <52174755.8030506@ti.com>
On 08/23/2013 05:28 AM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Friday 23 August 2013 02:20 AM, Stephen Warren wrote:
>> On 08/22/2013 02:31 AM, Kishon Vijay Abraham I wrote:
>>> The Palmas device contains only a USB VBUS-ID detector, so added a
>>> compatible type *ti,palmas-usb-vid*. Didn't remove the existing compatible
>>> types for backward compatibility.
>>
>>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
>>
>>> PALMAS USB COMPARATOR
>>> Required Properties:
>>> - - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
>>> + - compatible : Should be "ti,palmas-usb-vid". "ti,twl6035-usb" and
>>> + "ti,palmas-usb" is deprecated and is kept for backward compatibility.
>>
>> So this defines one new value and deprecates the two old values.
>
> yeah.
>>
>> Why isn't a new "ti,twl6035-usb-vid" entry useful? Don't you still need
>
> yeah, it should be added too.
>> SoC-specific compatible values so the driver can enable any SoC-specific
>> bug-fixes/workarounds later if needed?
>
> hmm.. Palmas is external to SoC. So not sure if adding SoC specific compatible
> values is such a good idea.
In this case, but SoC, I meant the Palmas chip rather than the
application processor. Is twl6035 a name for Palmas or something else?
next prev parent reply other threads:[~2013-08-23 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 8:31 [PATCH v4] extcon: palmas: Added a new compatible type *ti, palmas-usb-vid* Kishon Vijay Abraham I
2013-08-22 8:31 ` [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* Kishon Vijay Abraham I
2013-08-22 8:31 ` [PATCH v4] extcon: palmas: Added a new compatible type *ti, palmas-usb-vid* Kishon Vijay Abraham I
2013-08-22 20:50 ` [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* Stephen Warren
2013-08-22 20:50 ` [PATCH v4] extcon: palmas: Added a new compatible type *ti, palmas-usb-vid* Stephen Warren
2013-08-23 11:28 ` [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* Kishon Vijay Abraham I
2013-08-23 11:28 ` Kishon Vijay Abraham I
2013-08-23 11:28 ` [PATCH v4] extcon: palmas: Added a new compatible type *ti, palmas-usb-vid* Kishon Vijay Abraham I
2013-08-23 19:17 ` Stephen Warren [this message]
2013-08-23 19:17 ` Stephen Warren
2013-08-26 12:03 ` Kishon Vijay Abraham I
2013-08-26 12:03 ` [PATCH v4] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* Kishon Vijay Abraham I
2013-08-26 12:03 ` [PATCH v4] extcon: palmas: Added a new compatible type *ti, palmas-usb-vid* Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217B54E.8070009@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=george.cherian@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.