From: Eric Blake <eblake@redhat.com>
To: Tobias Markus <tobias@markus-regensburg.de>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Fix segment cache dump
Date: Fri, 23 Aug 2013 15:48:53 -0600 [thread overview]
Message-ID: <5217D8C5.8000408@redhat.com> (raw)
In-Reply-To: <5217D699.7090502@markus-regensburg.de>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On 08/23/2013 03:39 PM, Tobias Markus wrote:
> Alternatively, for readability:
> + cpu_fprintf(f, (sc->flags & DESC_B_MASK || env->hflags & HF_LMA_MASK)
> + ? "DS " : "DS16");
> The upper line would be 82 characters long. I'm not sure how strictly line width is enforced.
> (Other lines in that file (target-i386/helper.c) also exceed the width limit.)
This instance can get below 80 with one more line wrap:
+ cpu_fprintf(f,
+ (sc->flags & DESC_B_MASK || env->hflags &
HF_LMA_MASK)
+ ? "DS " : "DS16");
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-23 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 19:09 [Qemu-devel] [qemu-devel] [PATCH v2] target-i386: Fix segment cache dump Tobias Markus
2013-08-23 20:01 ` Richard Henderson
2013-08-23 21:39 ` [Qemu-devel] " Tobias Markus
2013-08-23 21:48 ` Eric Blake [this message]
2013-08-24 10:40 ` [Qemu-devel] [qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217D8C5.8000408@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=tobias@markus-regensburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.