From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
jiada_wang@mentor.com, robherring2@gmail.com,
grant.likely@linaro.org, broonie@kernel.org, vapier@gentoo.org,
ralf@linux-mips.org, kyungmin.park@samsung.com,
shawn.guo@linaro.org, sebastian.hesselbarth@gmail.com,
LW@KARO-electronics.de, t.figa@samsung.com,
g.liakhovetski@gmx.de, laurent.pinchart@ideasonboard.com,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-mips@linux-mips.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/4] clk: implement clk_unregister
Date: Sat, 24 Aug 2013 01:00:53 +0200 [thread overview]
Message-ID: <5217E9A5.8030503@gmail.com> (raw)
In-Reply-To: <20130823215838.8231.21635@quantum>
On 08/23/2013 11:58 PM, Mike Turquette wrote:
>> +static void clk_nodrv_disable_unprepare(struct clk_hw *hw)
>> > +{
>> > + WARN_ON(1);
>
> Ideally we shouldn't get here, but if we do I guess it could be very
> noisy. How about WARN_ONCE?
Yes, I guess that would be much better. I could resend it tomorrow if
needed.
> After you address Russell's comments in patch #1 I will be happy to take
> this series.
I have posted today v3 addressing Russell's comments. Hopefully patch #3
(the patches got reordered) looks OK now. v3 includes actual assigning
of clk->owner I somehow managed to miss in previous series :/ Please have
a look at it.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] clk: implement clk_unregister
Date: Fri, 23 Aug 2013 23:00:53 +0000 [thread overview]
Message-ID: <5217E9A5.8030503@gmail.com> (raw)
In-Reply-To: <20130823215838.8231.21635@quantum>
On 08/23/2013 11:58 PM, Mike Turquette wrote:
>> +static void clk_nodrv_disable_unprepare(struct clk_hw *hw)
>> > +{
>> > + WARN_ON(1);
>
> Ideally we shouldn't get here, but if we do I guess it could be very
> noisy. How about WARN_ONCE?
Yes, I guess that would be much better. I could resend it tomorrow if
needed.
> After you address Russell's comments in patch #1 I will be happy to take
> this series.
I have posted today v3 addressing Russell's comments. Hopefully patch #3
(the patches got reordered) looks OK now. v3 includes actual assigning
of clk->owner I somehow managed to miss in previous series :/ Please have
a look at it.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: sylvester.nawrocki@gmail.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] clk: implement clk_unregister
Date: Sat, 24 Aug 2013 01:00:53 +0200 [thread overview]
Message-ID: <5217E9A5.8030503@gmail.com> (raw)
In-Reply-To: <20130823215838.8231.21635@quantum>
On 08/23/2013 11:58 PM, Mike Turquette wrote:
>> +static void clk_nodrv_disable_unprepare(struct clk_hw *hw)
>> > +{
>> > + WARN_ON(1);
>
> Ideally we shouldn't get here, but if we do I guess it could be very
> noisy. How about WARN_ONCE?
Yes, I guess that would be much better. I could resend it tomorrow if
needed.
> After you address Russell's comments in patch #1 I will be happy to take
> this series.
I have posted today v3 addressing Russell's comments. Hopefully patch #3
(the patches got reordered) looks OK now. v3 includes actual assigning
of clk->owner I somehow managed to miss in previous series :/ Please have
a look at it.
--
Regards,
Sylwester
next prev parent reply other threads:[~2013-08-23 23:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 17:34 [PATCH v2 0/4] clk: clock deregistration support Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 17:34 ` [PATCH v2 1/4] clk: add common __clk_get(), __clk_put() implementations Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 20:30 ` Russell King - ARM Linux
2013-08-20 20:30 ` Russell King - ARM Linux
2013-08-20 20:30 ` Russell King - ARM Linux
2013-08-23 14:41 ` Sylwester Nawrocki
2013-08-23 14:41 ` Sylwester Nawrocki
2013-08-23 14:41 ` Sylwester Nawrocki
2013-08-23 14:41 ` Sylwester Nawrocki
2013-08-20 17:34 ` [PATCH v2 2/4] clk: implement clk_unregister Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-23 21:58 ` Mike Turquette
2013-08-23 21:58 ` Mike Turquette
2013-08-23 21:58 ` Mike Turquette
2013-08-23 21:58 ` Mike Turquette
2013-08-23 23:00 ` Sylwester Nawrocki [this message]
2013-08-23 23:00 ` Sylwester Nawrocki
2013-08-23 23:00 ` Sylwester Nawrocki
2013-08-20 17:34 ` [PATCH v2 3/4] clk: Provide not locked variant of of_clk_get_from_provider() Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 21:51 ` Russell King - ARM Linux
2013-08-20 21:51 ` Russell King - ARM Linux
2013-08-20 21:51 ` Russell King - ARM Linux
2013-08-20 17:34 ` [PATCH v2 4/4] clkdev: Fix race condition in clock lookup from device tree Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 17:34 ` Sylwester Nawrocki
2013-08-20 21:52 ` Russell King - ARM Linux
2013-08-20 21:52 ` Russell King - ARM Linux
2013-08-20 21:52 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217E9A5.8030503@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=LW@KARO-electronics.de \
--cc=broonie@kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=grant.likely@linaro.org \
--cc=jiada_wang@mentor.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=ralf@linux-mips.org \
--cc=robherring2@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=t.figa@samsung.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.