From: b.brezillon@overkiz.com (boris brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/3] pinctrl: at91: add support for generic pinconf
Date: Sat, 24 Aug 2013 23:43:14 +0200 [thread overview]
Message-ID: <521928F2.4060605@overkiz.com> (raw)
In-Reply-To: <1377379926-11163-1-git-send-email-b.brezillon@overkiz.com>
On 24/08/2013 23:32, Boris BREZILLON wrote:
> Hello,
>
> This patch series is an attempt to add support for generic pin config
> syntax to at91 pinctrl driver.
>
> My primary goal is to add support for output configuration from dt definition.
> This is needed to fully move at91rm9200ek board to dt (other boards may have
> the same needs).
> This board use a pin to drive an external switch which select between 2
> functionnalities:
> - mmc interface
> - spi interface
> The pin level is currently configured in the board init (init_machine) function
> based on user config choices (CONFIG_MTD_AT91_DATAFLASH_CARD).
>
> Instead of adding a new flag to the current (native) pin config binding, I
> tried to add support for the generic pin config used by some pinctrl drivers
> (i.e. rockchip).
>
> Is this the right way to do this or should I add a new at91 native flags for
> output config (OUTPUT_HIGH/LOW) ?
>
> The second patch introduce a new config parameter to add a glitch filter on a
> specific pin.
The first patch, not the second.
> Glitch filter is similar to bounce filter (or debounce) but with a smaller
> delay (expressed in nsecs ?).
>
> I'm not sure this is the right approach.
> Maybe we should reuse the debounce parameter and add a flag to specify the delay
> unit (usec or nsec).
>
> What do you think ?
>
> The third patch migrate sama5 dt boards to the new generic config syntax.
>
> Please feel free to share your thoughts.
>
> Best Regards,
>
> Boris
>
>
> Boris BREZILLON (3):
> pinctrl: add new generic pinconf config for deglitch filter
> pinctrl: at91: add support for generic pinconf
> ARM: at91/dt: move sama5 to generic pinconf
>
> .../bindings/pinctrl/atmel,at91-pinctrl.txt | 43 ++-
> .../bindings/pinctrl/pinctrl-bindings.txt | 1 +
> arch/arm/boot/dts/sama5d3.dtsi | 363 ++++++++++----------
> arch/arm/boot/dts/sama5d3xdm.dtsi | 2 +-
> arch/arm/boot/dts/sama5d3xmb.dtsi | 12 +-
> drivers/pinctrl/Kconfig | 2 +-
> drivers/pinctrl/pinconf-generic.c | 2 +
> drivers/pinctrl/pinctrl-at91.c | 265 +++++++++++++-
> include/linux/pinctrl/pinconf-generic.h | 5 +
> 9 files changed, 494 insertions(+), 201 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: boris brezillon <b.brezillon@overkiz.com>
To: Boris BREZILLON <b.brezillon@overkiz.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jiri Kosina <jkosina@suse.cz>,
Masanari Iida <standby24x7@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Richard Genoud <richard.genoud@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
James Hogan <james.hogan@imgtec.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 0/3] pinctrl: at91: add support for generic pinconf
Date: Sat, 24 Aug 2013 23:43:14 +0200 [thread overview]
Message-ID: <521928F2.4060605@overkiz.com> (raw)
In-Reply-To: <1377379926-11163-1-git-send-email-b.brezillon@overkiz.com>
On 24/08/2013 23:32, Boris BREZILLON wrote:
> Hello,
>
> This patch series is an attempt to add support for generic pin config
> syntax to at91 pinctrl driver.
>
> My primary goal is to add support for output configuration from dt definition.
> This is needed to fully move at91rm9200ek board to dt (other boards may have
> the same needs).
> This board use a pin to drive an external switch which select between 2
> functionnalities:
> - mmc interface
> - spi interface
> The pin level is currently configured in the board init (init_machine) function
> based on user config choices (CONFIG_MTD_AT91_DATAFLASH_CARD).
>
> Instead of adding a new flag to the current (native) pin config binding, I
> tried to add support for the generic pin config used by some pinctrl drivers
> (i.e. rockchip).
>
> Is this the right way to do this or should I add a new at91 native flags for
> output config (OUTPUT_HIGH/LOW) ?
>
> The second patch introduce a new config parameter to add a glitch filter on a
> specific pin.
The first patch, not the second.
> Glitch filter is similar to bounce filter (or debounce) but with a smaller
> delay (expressed in nsecs ?).
>
> I'm not sure this is the right approach.
> Maybe we should reuse the debounce parameter and add a flag to specify the delay
> unit (usec or nsec).
>
> What do you think ?
>
> The third patch migrate sama5 dt boards to the new generic config syntax.
>
> Please feel free to share your thoughts.
>
> Best Regards,
>
> Boris
>
>
> Boris BREZILLON (3):
> pinctrl: add new generic pinconf config for deglitch filter
> pinctrl: at91: add support for generic pinconf
> ARM: at91/dt: move sama5 to generic pinconf
>
> .../bindings/pinctrl/atmel,at91-pinctrl.txt | 43 ++-
> .../bindings/pinctrl/pinctrl-bindings.txt | 1 +
> arch/arm/boot/dts/sama5d3.dtsi | 363 ++++++++++----------
> arch/arm/boot/dts/sama5d3xdm.dtsi | 2 +-
> arch/arm/boot/dts/sama5d3xmb.dtsi | 12 +-
> drivers/pinctrl/Kconfig | 2 +-
> drivers/pinctrl/pinconf-generic.c | 2 +
> drivers/pinctrl/pinctrl-at91.c | 265 +++++++++++++-
> include/linux/pinctrl/pinconf-generic.h | 5 +
> 9 files changed, 494 insertions(+), 201 deletions(-)
>
next prev parent reply other threads:[~2013-08-24 21:43 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-24 21:32 [RFC PATCH 0/3] pinctrl: at91: add support for generic pinconf Boris BREZILLON
2013-08-24 21:32 ` Boris BREZILLON
2013-08-24 21:35 ` [RFC PATCH 1/3] pinctrl: add new generic pinconf config for deglitch filter Boris BREZILLON
2013-08-24 21:35 ` Boris BREZILLON
2013-08-26 16:50 ` Stephen Warren
2013-08-26 16:50 ` Stephen Warren
2013-08-26 17:01 ` boris brezillon
2013-08-26 17:01 ` boris brezillon
2013-08-27 3:55 ` Stephen Warren
2013-08-27 3:55 ` Stephen Warren
2013-08-27 6:16 ` boris brezillon
2013-08-27 6:16 ` boris brezillon
2013-08-27 6:16 ` boris brezillon
2013-08-27 7:42 ` Nicolas Ferre
2013-08-27 7:42 ` Nicolas Ferre
2013-08-27 7:42 ` Nicolas Ferre
2013-08-27 8:28 ` boris brezillon
2013-08-27 8:28 ` boris brezillon
2013-08-27 21:33 ` Stephen Warren
2013-08-27 21:33 ` Stephen Warren
2013-08-28 13:22 ` Linus Walleij
2013-08-28 13:22 ` Linus Walleij
2013-08-28 13:13 ` Linus Walleij
2013-08-28 13:13 ` Linus Walleij
2013-08-24 21:37 ` [RFC PATCH 2/3] pinctrl: at91: add support for generic pinconf Boris BREZILLON
2013-08-24 21:37 ` Boris BREZILLON
2013-08-26 16:53 ` Stephen Warren
2013-08-26 16:53 ` Stephen Warren
2013-08-26 17:17 ` boris brezillon
2013-08-26 17:17 ` boris brezillon
2013-08-27 3:57 ` Stephen Warren
2013-08-27 3:57 ` Stephen Warren
2013-08-27 6:40 ` boris brezillon
2013-08-27 6:40 ` boris brezillon
2013-08-27 21:35 ` Stephen Warren
2013-08-27 21:35 ` Stephen Warren
2013-08-26 17:53 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 17:53 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 18:45 ` boris brezillon
2013-08-26 18:45 ` boris brezillon
2013-08-26 19:18 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 19:18 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 19:18 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-26 19:48 ` boris brezillon
2013-08-26 19:48 ` boris brezillon
2013-08-27 7:51 ` Nicolas Ferre
2013-08-27 7:51 ` Nicolas Ferre
2013-08-27 7:51 ` Nicolas Ferre
2013-08-27 3:54 ` Stephen Warren
2013-08-27 3:54 ` Stephen Warren
2013-08-27 6:04 ` boris brezillon
2013-08-27 6:04 ` boris brezillon
2013-08-27 21:30 ` Stephen Warren
2013-08-27 21:30 ` Stephen Warren
2013-08-24 21:40 ` [RFC PATCH 3/3] ARM: at91/dt: move sama5 to " Boris BREZILLON
2013-08-24 21:40 ` Boris BREZILLON
2013-08-28 12:28 ` Linus Walleij
2013-08-28 12:28 ` Linus Walleij
2013-08-28 12:52 ` boris brezillon
2013-08-28 12:52 ` boris brezillon
2013-08-24 21:43 ` boris brezillon [this message]
2013-08-24 21:43 ` [RFC PATCH 0/3] pinctrl: at91: add support for " boris brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521928F2.4060605@overkiz.com \
--to=b.brezillon@overkiz.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.