All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] h8300/kernel/setup.c: add "linux/initrd.h" to pass compiling
Date: Mon, 26 Aug 2013 19:06:03 +0800	[thread overview]
Message-ID: <521B369B.4010602@asianux.com> (raw)
In-Reply-To: <CAMuHMdVXJvLfmNLFFW=TBLOi2_mVyZy+kr46oM5GVz_PK-bbvA@mail.gmail.com>

On 08/26/2013 07:00 PM, Geert Uytterhoeven wrote:
> On Mon, Aug 26, 2013 at 12:31 PM, Chen Gang <gang.chen@asianux.com> wrote:
>> --- a/arch/h8300/kernel/setup.c
>> +++ b/arch/h8300/kernel/setup.c
>> @@ -47,6 +47,9 @@
>>  #include <asm/regs267x.h>
>>  #endif
>>
>> +#if defined(CONFIG_BLK_DEV_INITRD)
> 
> Why have you added the #ifdef?
> 

The related code is below (maybe we need add additional related
comments in the patch for it ?).

in arch/h8300/kernel/setup.c

 94 void __init setup_arch(char **cmdline_p)
 95 {
 96         int bootmap_size;
 97 
 98         memory_start = (unsigned long) &_ramstart;
 99 
100         /* allow for ROMFS on the end of the kernel */
101         if (memcmp((void *)memory_start, "-rom1fs-", 8) == 0) {
102 #if defined(CONFIG_BLK_DEV_INITRD)
103                 initrd_start = memory_start;
104                 initrd_end = memory_start += be32_to_cpu(((unsigned long *) (memory_start))[2]);
105 #else
106                 memory_start += be32_to_cpu(((unsigned long *) memory_start)[2]);
107 #endif
108         }


>> +#include <linux/initrd.h>
>> +#endif
>>  #define STUBSIZE 0xc000
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
> 


-- 
Chen Gang

  reply	other threads:[~2013-08-26 11:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 10:31 [PATCH] h8300/kernel/setup.c: add "linux/initrd.h" to pass compiling Chen Gang
2013-08-26 11:00 ` Geert Uytterhoeven
2013-08-26 11:06   ` Chen Gang [this message]
2013-08-26 11:08     ` Geert Uytterhoeven
2013-08-26 11:19       ` Chen Gang
2013-08-26 22:12         ` Guenter Roeck
2013-08-27  1:58           ` Chen Gang
2013-08-30  3:54 ` Chen Gang
2013-08-30  3:59   ` [PATCH v2] " Chen Gang
2013-08-30  4:32     ` Guenter Roeck
2013-08-30  5:49       ` Chen Gang
2013-08-30 11:12         ` Guenter Roeck
2013-09-02  2:51           ` Chen Gang
2013-08-30  4:53     ` Guenter Roeck
2013-08-30  6:34       ` Chen Gang
2013-08-30 11:18         ` Guenter Roeck
2013-08-30 11:44           ` richard -rw- weinberger
2013-08-30 12:20             ` Guenter Roeck
2013-09-02  3:26               ` Chen Gang
2013-09-03  8:29                 ` [PATCH trivial] block/ioctl.c: let code match 'kernel code style' Chen Gang
2013-09-03  8:55                   ` Li Zefan
2013-09-03  9:06                     ` Chen Gang
2013-09-03  9:27                       ` Jiri Kosina
2013-09-03  9:58                         ` Chen Gang
2013-09-03  9:54                       ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521B369B.4010602@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.