All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizefan@huawei.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Joe Perches <joe@perches.com>,
	"'Jiri Kosina'" <trivial@kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Guenter Roeck <linux@roeck-us.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style'
Date: Tue, 3 Sep 2013 16:55:20 +0800	[thread overview]
Message-ID: <5225A3F8.5070008@huawei.com> (raw)
In-Reply-To: <52259DDE.6070401@asianux.com>

Please don't. Pure colding style cleanup is discouraged.

You're not going to run checkpatch.pl on the whole kernel tree and fix
all the complaints, are you?

On 2013/9/3 16:29, Chen Gang wrote:
> For 'switch case', remove redundancy '\t' (also can let related lines
> within 80 columns) and remove redundancy empty lines, just like other
> 'switch case' which match 'kernel code style' within the file.
> 
> Let blkpg_ioctl() within 80 columns. Let 2nd line of blkdev_ioctl() and
> __blkdev_driver_ioctl() align 1st line parameter's start position, just
> like blk_ioctl_discard() and blk_ioctl_zeroout() within the file.
> 
> For is_unrecognized_ioctl(), can shrink the 'return' statement into one
> line (so can save 2 lines), it still matches 'kernel code style' and it
> is no conflict with others within the file.
> 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  block/ioctl.c |  216 ++++++++++++++++++++++++++++-----------------------------
>  1 files changed, 105 insertions(+), 111 deletions(-)


  reply	other threads:[~2013-09-03  8:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 10:31 [PATCH] h8300/kernel/setup.c: add "linux/initrd.h" to pass compiling Chen Gang
2013-08-26 11:00 ` Geert Uytterhoeven
2013-08-26 11:06   ` Chen Gang
2013-08-26 11:08     ` Geert Uytterhoeven
2013-08-26 11:19       ` Chen Gang
2013-08-26 22:12         ` Guenter Roeck
2013-08-27  1:58           ` Chen Gang
2013-08-30  3:54 ` Chen Gang
2013-08-30  3:59   ` [PATCH v2] " Chen Gang
2013-08-30  4:32     ` Guenter Roeck
2013-08-30  5:49       ` Chen Gang
2013-08-30 11:12         ` Guenter Roeck
2013-09-02  2:51           ` Chen Gang
2013-08-30  4:53     ` Guenter Roeck
2013-08-30  6:34       ` Chen Gang
2013-08-30 11:18         ` Guenter Roeck
2013-08-30 11:44           ` richard -rw- weinberger
2013-08-30 12:20             ` Guenter Roeck
2013-09-02  3:26               ` Chen Gang
2013-09-03  8:29                 ` [PATCH trivial] block/ioctl.c: let code match 'kernel code style' Chen Gang
2013-09-03  8:55                   ` Li Zefan [this message]
2013-09-03  9:06                     ` Chen Gang
2013-09-03  9:27                       ` Jiri Kosina
2013-09-03  9:58                         ` Chen Gang
2013-09-03  9:54                       ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5225A3F8.5070008@huawei.com \
    --to=lizefan@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=gang.chen@asianux.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.